From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 819023CB56A for ; Fri, 17 Jul 2026 12:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784289728; cv=none; b=qGgjgyqYh2GdBErbjHKs5c9rdxtXbaEHFddoDeeME3Py8tt1gPXEOkbYgxiGzONg98OUGdniZVyPyER7CP0fazgjJYAzeK4aiM6+cR6CTIncovBDwiLk75cpj6Os3Ak6E7D8ukkdQvbAj27QMe3Gg64pa1yABn3RzzxIG5H5QAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784289728; c=relaxed/simple; bh=8Uw740j8vtVBDWekYMNzNzazdHY/o1xs3KjRekg8knY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S+00wM+lDxv9rLnBxJR1KnNSuOzY0fX5jYlqCgU6Cmu+olqMJPEhnnmp3VxHE4HxTZ3++1hp3LW+rX8y46XBtQCoZhLqPGvBJOwy0jofTvEnwlKSYBGPDUlyPPD/mjrXRi1eJU9rUO7QWmogXSkGJ/bcVmhvXeWybVZNvfk6BsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arturia.com; spf=pass smtp.mailfrom=arturia.com; dkim=pass (2048-bit key) header.d=arturia.com header.i=@arturia.com header.b=PsRRLhTK; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arturia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arturia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arturia.com header.i=@arturia.com header.b="PsRRLhTK" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493f45e20cdso45305585e9.2 for ; Fri, 17 Jul 2026 05:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arturia.com; s=arturia; t=1784289722; x=1784894522; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3ytxZbr+En2Se18JmJbsiXT61grY1p5Cg8Gm6wZ0DgQ=; b=PsRRLhTKfyASTINcz+00uDlWbgww+w9iib80uTKez4bEFSZvP06wco5hAPQGY8ESr1 ao41TM70S2MkIKtNPGatLYpB6lXDf7vM2fplVCZ8Jrulc8/6Ce9wb9VNeX+80BPZ9s2u lWB0IDP/Yd1h/33MUhhUu3/gKJvrYN6qyuTuaErusDknNjqFZiomzV6HOVmgnegbK6fJ eiKcKjMAcN7xvk0DJgDWNqzdUIzbhIakwdWYlaUFFG8ArHVbirotjoDM2iOpIYBNMOf3 XK6f0GrXm59ZhVcFx2U+UDF/uMZUWmJ5NRMqRRLMHM2FgJe4RcxnV93q7H2kQg4lB1Io nISw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784289722; x=1784894522; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3ytxZbr+En2Se18JmJbsiXT61grY1p5Cg8Gm6wZ0DgQ=; b=AL07JIer0zTLN6ZGKicNRT8MWLE8O3FXS7qSyffwUl1oLrAvjrv4Hb8L1K1JdyFPuE xMJ+O2jU2iLE5SW/vpPHt71g534rWwDX0QX6mGfO021Byru5FPTgOVeDn4ulgbfto8LD 7xFwTaUaqeSQ2XkTPO2oGZvY6eJP+2sY2otrvf42brqPSyKPIYFMnMaFx2aLXUrmNC2H DvtUq61Z0cCN89GNTZr7dPK+YtcnSq+r0W9/aZw0p5oAevTufM2UeTFufPMdhJfXJIdR nXYL+gJ0ODPldR8y5NkAT/AdlG6elnFxCFoFPAxTEAcELK1gsDUKWvtnu5aJ3cc4iktN uE4Q== X-Forwarded-Encrypted: i=1; AHgh+RrpYqCdUWpQpeLwHlrEIFQE86FVzhQxvrXCIEOCVJRDd0aH8MmJalGFdMysNtKQwe44xj+z6cSyPExnZRI=@vger.kernel.org X-Gm-Message-State: AOJu0YzUtLqlO7f3WKc9VRmT8MaOJ9R3ujXU+HbyTPBw/ck+sUqvJWc8 iBYgrHQ6XxR2fqyyVfuUAVZHBNT0lsKGmdV97LBUmUjuUlwN7rL544YYuQDSG0ScT1M= X-Gm-Gg: AfdE7ckP72O9W6T9bJXEITI9Yx10zD4DfJisDs6fnG+75mOcEswuwmBykZElxBjSxkX G6EK/3n3OqbmeBdGi/ZEMRLL4cp3IQsUkN8X9miD8c7oyBgtMoKQad16q9XuR1XJRSVD5b20dcb jhhiJAFJizhYaWTiPe0oPCk6x/m07oIuf4/Mq9jKLAXZ5Am6HHKhW1N6+GWnZA1i2K6agPOU3CX mG85C7RyFQqjePEkwtCGAFTyASL3YDNWKWAOnRYvTzTnfD3aLwq3V/bF6iQFTUygu1upL26Icvp qO8UFL2UTviYRpG10PmJDmCopC7+zMdTyb/hnTie1aqYCti7n6EJsaoMPN0SeC0e+Mml4kKuk+y r8Z5ODY+nZSUnJIowkmAYPfYZe61PYb+zb4AYY6dveSsE7SYiz3sPXaE5Gs3MJ9H4QjqKEPfDg/ tm+FIYKJXPUvX5HYF+Of2GZA+R7A6niV/hgXUXXDmJWQHPdWU7yl8rg8MiQCM= X-Received: by 2002:a05:600c:154e:b0:495:405c:38d3 with SMTP id 5b1f17b1804b1-4954a3df9f9mr31966885e9.9.1784289721703; Fri, 17 Jul 2026 05:02:01 -0700 (PDT) Received: from ?IPV6:2001:861:2128:c8c0:8e8c:fdab:4545:5849? ([2001:861:2128:c8c0:8e8c:fdab:4545:5849]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63ed2313sm3034899f8f.23.2026.07.17.05.02.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 05:02:01 -0700 (PDT) Message-ID: Date: Fri, 17 Jul 2026 14:02:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] regulator: dt-bindings: Add Silergy SYR82X allowed modes To: Krzysztof Kozlowski Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260715155141.128601-1-victor.krawiec@arturia.com> <20260715155141.128601-2-victor.krawiec@arturia.com> <20260717-nostalgic-raptor-of-sunshine-1aba9a@quoll> Content-Language: en-US From: Victor Krawiec In-Reply-To: <20260717-nostalgic-raptor-of-sunshine-1aba9a@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/17/26 11:08, Krzysztof Kozlowski wrote: > On Wed, Jul 15, 2026 at 05:51:38PM +0200, Victor Krawiec wrote: >> Make the PWM mode configurable from devicetree. Some boards require forced >> PWM mode to keep the supply ripple within acceptable limits under light >> load conditions >> >> Indexes are starting from 1 to keep backward compatibility with existing >> device trees >> >> Signed-off-by: Victor Krawiec >> --- >> .../dt-bindings/regulator/silergy,syr82x.h | 20 +++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 include/dt-bindings/regulator/silergy,syr82x.h >> > This header should be mentioned in the binding in property description. Thank you for the review. I'll add it to the binding in the next iteration. >> diff --git a/include/dt-bindings/regulator/silergy,syr82x.h b/include/dt-bindings/regulator/silergy,syr82x.h >> new file mode 100644 >> index 000000000000..6d4aa86bb5c1 >> --- /dev/null >> +++ b/include/dt-bindings/regulator/silergy,syr82x.h > Some confusing name. How is your binding file called? This must be the > same. The binding file is named fcs,fan53555.yaml and handles several devices including the Silergy SYR82X which I was targeting in this patch serie. I will rename the header to have the same name as the binding file. Should I also rename the macros defined inside the header (SYR82X_REGULATOR_MODE_*) ? The underlying implementation in the driver (in fan53555_device_mode_map_setup() it the patch serie) is limited to SYR82X because it is the only hardware that I'm able to test. That's why the binding part was referring to this specific device. Best regards, Victor