From: Paolo Bonzini <pbonzini@redhat.com>
To: Jing Liu <jing2.liu@linux.intel.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jing2.liu@intel.com
Subject: Re: [PATCH RFC] kvm: x86: Expose AVX512_BF16 feature to guest
Date: Thu, 20 Jun 2019 14:16:22 +0200 [thread overview]
Message-ID: <fd861e94-3ea5-3976-9855-05375f869f00@redhat.com> (raw)
In-Reply-To: <1561029712-11848-2-git-send-email-jing2.liu@linux.intel.com>
On 20/06/19 13:21, Jing Liu wrote:
> + for (i = 1; i <= times; i++) {
> + if (*nent >= maxnent)
> + goto out;
> + do_cpuid_1_ent(&entry[i], function, i);
> + entry[i].eax &= F(AVX512_BF16);
> + entry[i].ebx = 0;
> + entry[i].ecx = 0;
> + entry[i].edx = 0;
> + entry[i].flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
> + ++*nent;
This woud be wrong for i > 1, so instead make this
if (entry->eax >= 1)
and define F(AVX512_BF16) as a new constant kvm_cpuid_7_1_eax_features.
Paolo
next prev parent reply other threads:[~2019-06-20 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 11:21 [PATCH RFC] kvm: x86: AVX512_BF16 feature support Jing Liu
2019-06-20 11:21 ` [PATCH RFC] kvm: x86: Expose AVX512_BF16 feature to guest Jing Liu
2019-06-20 12:16 ` Paolo Bonzini [this message]
2019-06-20 15:09 ` Liu, Jing2
2019-06-24 3:10 ` Jing Liu
2019-06-24 8:33 ` Paolo Bonzini
2019-06-24 12:06 ` Jing Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd861e94-3ea5-3976-9855-05375f869f00@redhat.com \
--to=pbonzini@redhat.com \
--cc=jing2.liu@intel.com \
--cc=jing2.liu@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®