From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D40CE7A8C for ; Mon, 25 Sep 2023 05:19:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231742AbjIYFTs (ORCPT ); Mon, 25 Sep 2023 01:19:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjIYFTr (ORCPT ); Mon, 25 Sep 2023 01:19:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EC73B3 for ; Sun, 24 Sep 2023 22:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695619134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r/i6WgyU67cVGVuGb18YTCkwEV9jvnrS1YtYZ/55UF8=; b=PUFv/P72a5FBUeWy04nfvpu545RrreSKFscr0sb05sN/Jq7q/XQujt7aOq/jiywhlcn5zT +1k/IT1sKNZ+uZGytV7Gtf2pCPOasYTHHg6tumS8a2FWATcKV6tryyJVVkIa6Ljr4787TV Sw7fpCWvduh7yaKdoWzrAwQt4btJBgk= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-f3uYfep2MDSL_1WQ9N9OOw-1; Mon, 25 Sep 2023 01:18:52 -0400 X-MC-Unique: f3uYfep2MDSL_1WQ9N9OOw-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-27714a9f192so5174528a91.1 for ; Sun, 24 Sep 2023 22:18:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695619131; x=1696223931; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r/i6WgyU67cVGVuGb18YTCkwEV9jvnrS1YtYZ/55UF8=; b=wLu1838iQcSTflwQQDij0lRixHWxLf7mWmti9S8ZAlf5PrvOi4eOTKvPvL5GAHXTBR zvyIeml01rqz/mrSpCQGpk87SkBNyYV285iN7vMfmAGUJcxuuEGWJbceLuhZwKDWH+zk ABRUwkrXMvRPCLnMC8x1T5Wo3OL8ZsJGRuyf5Ygz0lSkW6qqvE7ulu+ohcepTA+rfCqe z0y1Xzb1OIL72VYVK60Jp01rn5r63V4MF0T6A0PMuVzpM89GA5rXOAOcRnXA5HgI9/ur iUbwzbENLzl0K4lpthgcI6iFY611uCsfdxyM7R7aWb3xeOdOJEuKAJUt4ZuEdysTcwR/ lqgQ== X-Gm-Message-State: AOJu0YxSpcwb5oj1kLnFs1WpI1e3VBPSboczf4Za+O3SIYq+S8ZTwg3V AVKqdZLlP+2AjKSQfgKt2ayhVezS2HC2GqA1UI0YVf2zIzGfz+wBNjtOWAYQNK9JaXvmfyBOLHm v9Ous+VSLWwtwKuOiSTajg2b1 X-Received: by 2002:a17:90b:4a88:b0:274:9be9:7ee3 with SMTP id lp8-20020a17090b4a8800b002749be97ee3mr9105813pjb.8.1695619131243; Sun, 24 Sep 2023 22:18:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGaLXQWcL0EzsDD99SelRh5aKaRr6prYyFl3V1yZtBj/fqTrmuvta2Vf2r/ggyiYAJG61rBQ== X-Received: by 2002:a17:90b:4a88:b0:274:9be9:7ee3 with SMTP id lp8-20020a17090b4a8800b002749be97ee3mr9105801pjb.8.1695619130954; Sun, 24 Sep 2023 22:18:50 -0700 (PDT) Received: from [10.72.112.123] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a005e00b00274c541ac9esm7832898pjb.48.2023.09.24.22.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Sep 2023 22:18:50 -0700 (PDT) Message-ID: Date: Mon, 25 Sep 2023 13:18:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] fs/ceph/debugfs: make all files world-readable To: Max Kellermann , Ilya Dryomov , Jeff Layton Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230922062558.1739642-1-max.kellermann@ionos.com> Content-Language: en-US From: Xiubo Li In-Reply-To: <20230922062558.1739642-1-max.kellermann@ionos.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/22/23 14:25, Max Kellermann wrote: > I'd like to be able to run metrics collector processes without special > privileges > > In the kernel, there is a mix of debugfs files being world-readable > and not world-readable is; with a naive "git grep", I found 723 > world-readable debugfs_create_file() calls and 582 calls which were > only accessible to privileged processe. > > From the code, I cannot derive a consistent policy for that, but the > ceph statistics seem harmless (and useful) enough. I am not sure whether will this make sense. Because the 'debug' under '/sys/kernel/' is also only accessible by privileged process. Ilya, Jeff Any idea ? Thanks - Xiubo > Signed-off-by: Max Kellermann > --- > fs/ceph/debugfs.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c > index 3904333fa6c3..2abee7e18144 100644 > --- a/fs/ceph/debugfs.c > +++ b/fs/ceph/debugfs.c > @@ -429,31 +429,31 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc) > name); > > fsc->debugfs_mdsmap = debugfs_create_file("mdsmap", > - 0400, > + 0444, > fsc->client->debugfs_dir, > fsc, > &mdsmap_fops); > > fsc->debugfs_mds_sessions = debugfs_create_file("mds_sessions", > - 0400, > + 0444, > fsc->client->debugfs_dir, > fsc, > &mds_sessions_fops); > > fsc->debugfs_mdsc = debugfs_create_file("mdsc", > - 0400, > + 0444, > fsc->client->debugfs_dir, > fsc, > &mdsc_fops); > > fsc->debugfs_caps = debugfs_create_file("caps", > - 0400, > + 0444, > fsc->client->debugfs_dir, > fsc, > &caps_fops); > > fsc->debugfs_status = debugfs_create_file("status", > - 0400, > + 0444, > fsc->client->debugfs_dir, > fsc, > &status_fops); > @@ -461,13 +461,13 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc) > fsc->debugfs_metrics_dir = debugfs_create_dir("metrics", > fsc->client->debugfs_dir); > > - debugfs_create_file("file", 0400, fsc->debugfs_metrics_dir, fsc, > + debugfs_create_file("file", 0444, fsc->debugfs_metrics_dir, fsc, > &metrics_file_fops); > - debugfs_create_file("latency", 0400, fsc->debugfs_metrics_dir, fsc, > + debugfs_create_file("latency", 0444, fsc->debugfs_metrics_dir, fsc, > &metrics_latency_fops); > - debugfs_create_file("size", 0400, fsc->debugfs_metrics_dir, fsc, > + debugfs_create_file("size", 0444, fsc->debugfs_metrics_dir, fsc, > &metrics_size_fops); > - debugfs_create_file("caps", 0400, fsc->debugfs_metrics_dir, fsc, > + debugfs_create_file("caps", 0444, fsc->debugfs_metrics_dir, fsc, > &metrics_caps_fops); > } >