From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06CC833D4E5 for ; Mon, 23 Mar 2026 09:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774258764; cv=none; b=Ken9uxD9PN184l7C3WcCWfLG0xVfGj32S98jUl+tFX1J6fYJ922A7JJtLMT90kTc0NvAv0ovMMqSwNm/i1NOlp5f/RDaDeuMdPcxssRQ7tKxEhiPwZ1DGt5BdqC+eatG41+Qu1U5jK7qNlvmaucyj5XKp8ZFQi6rNR4DY5Nb9p8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774258764; c=relaxed/simple; bh=pQxvm7ndzvWsuOsFpJlNW1nlGs8MwK3wXuI2d4hFdJE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mZO2f7a+4eCbIWyBYVddXclfZ97pA45DoJfN9LoEp8O/RrPIIBoR7/w7lYZl0a6W2HHB4RATh+X/BlZTGssI5J/xjA5GM8VMVRcFvOR6EWeyv4zkvAr83OU6Io7EEeK04JVLFIlfoie0h+YGwKbcVc6f9lT7pWSgC1EbRucAZpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iHgd3u9F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bvcjkVpr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iHgd3u9F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bvcjkVpr" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N72S3l1286035 for ; Mon, 23 Mar 2026 09:39:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JxAkSVz8M2FTfuo0qCgFYUBjaV8Dv/qmWNiMLDJQDBw=; b=iHgd3u9FbK4xwvrj a1aTOhWyTYw2JvhIe7GCJXL/rabxmZ89orNQcqAdPOeCrxrqeidBEk3lYqmLSiIZ 7Fn8/1LUXd0NO1TN+S0unUJfUSQ3mJDuj7TO2R8Pew+JJp2hxrnjlC3vdz997jw4 57qKCY+Y+81Qq6zAPVMcDoGodHjX7/sMfa97FVfxz0Up5FBriVs0Lu+CjZ0gAko0 Gelba6oDnE1faolgIfzeO2CQhzfCVLflXCvDGZ4WWeOX40dcwPXO1TfkgwHVgh2j /nInvJQ6x4z7CYbfWBCDVv3ukrzxt33LvN4PnuXfR/kRmRJaxYyK05j3YQBibprA gjqTHQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1kq5vrq7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:39:22 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89c68ac09f5so37053986d6.3 for ; Mon, 23 Mar 2026 02:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774258761; x=1774863561; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JxAkSVz8M2FTfuo0qCgFYUBjaV8Dv/qmWNiMLDJQDBw=; b=bvcjkVprNaeD4+op/lmVZLAJJrKeWbXUj8VPTaY9wlGnShpSYNXflFYqdCa/RNj0NU H1E9OaLhbyOfYHTZagN+1F8EBon9iayIUEREv6utgOKqrKbt4FR9kQ/vozv7AnXRB6b6 Uq4+2A2CDkFhmyPMhszpyi28L6YjqipOvEX85TkZpnCkpFOmRWmUpPlY04+QG0/kmSBf lzUILK+1vxDxw67433kIKf7hyd78ZTTT4Sp1cWWx0P22CArugIZjku2oCtg3OjqYaeFm 3TKzzUCPKxwuSdrMtenjlOwL31acVzg4DoGZgkm+svTIseu42fK2Lq8XTeFpAeGdBAwg SA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774258761; x=1774863561; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JxAkSVz8M2FTfuo0qCgFYUBjaV8Dv/qmWNiMLDJQDBw=; b=WG0jaHg11HLUv8R5QiU7ra7Pw61abe1uQG+gThbMIcYwEU7B84NyIQ0dsooA+5Cu2/ MW1i6bBFotEhVQ36DEOQS0/twb7HvDC9Elcxdi6VaMCxlCvlRb3p+NaMup2zfn0+vlbY 11ZuonTkZTTkdGqIR3UyqsEC9C+BFydBZpOcS2ZKXQsYjktH12LYL5tKWZAFJGjbrYb1 vxwC0TSejGuND3EYwe/j63mAaN6M8Pp86hJTy1/SH9ilxe5Mc/nvOxkuxFibD/XFkYqT rWUr8fI3Z9f1TYZH/Xh20BerXlGRr1oZgh27Ay/9cvdxiFGDyQ5VcR8n10dbjOxMwpAe 2pUA== X-Forwarded-Encrypted: i=1; AJvYcCW9xV/j3AjG2UcvbPpBgZqlPNdP1DBrspR66gcnp2120MEnLgDcNDYeW1II1L7Zt+qUWKbEC1Vv4Hg2QLQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzF2/0IZU+MvdlQwq1AJNfat/8letbCuMTA25IsR9odD9kvihHX FiYKs6x18KasBZiO6qhJ7iiGg2btJLT9p7Iu32uPBz6o1scbw/E7t1EFMkTWb/79NnQS3RNm15q Ow5o2hUn3ARXa/bSQY+w9mlmzz1My14jw+s9Hj4xibd4VX94QYnm6+DkaUcsg4wrqtYs= X-Gm-Gg: ATEYQzwgYIb/n8kLN11bI27eFQXqW81WtpXoO7VJ83PlPbwLrqu8T4Hu56DTGN1gWR/ 9sr+RUAkO1UIvuAdx7FAh1RQmlb8x6zFauB3f/r7/BlAdYP3EL4+RbGx5exF+nUPJwZx4UaJ9Dp 1n5tR49jE4evrK/9uVA/g/J9CW/yes5quYyDG2FEC1hdbAM4ZnfdcIOS85DXPFyzQXhpj/c47ic NYUXiychyM0WXBV5cPsx6YBF4mTVCsP52tq7AQ++T6guPVgrpyMadmmoOr0g5C7eaRUoluz/Mw6 f4KUcseLPEmwzn5klwWotOiQvezZUFfK180n4ZR8FJ2MBxxF6V2PHCSsTdkdeeO5O5pkTFGkhoU wpbmiVYFvpsLRHHfYF/eMg7sFG1QhGgv4qwIvz3UU+nW/umQQzTAn6FFz4KQdICHOMSAoJmmub9 f0k30= X-Received: by 2002:a05:6214:2588:b0:89a:50b4:bc94 with SMTP id 6a1803df08f44-89c858ec443mr152756646d6.0.1774258761383; Mon, 23 Mar 2026 02:39:21 -0700 (PDT) X-Received: by 2002:a05:6214:2588:b0:89a:50b4:bc94 with SMTP id 6a1803df08f44-89c858ec443mr152756386d6.0.1774258760871; Mon, 23 Mar 2026 02:39:20 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b983365d86asm476556666b.48.2026.03.23.02.39.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 02:39:20 -0700 (PDT) Message-ID: Date: Mon, 23 Mar 2026 10:39:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] arm64: dts: qcom: Add AYN QCS8550 Common To: Aaron Kling , Val Packett Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Teguh Sobirin References: <20260311-ayn-qcs8550-v2-0-e66986e0f0cb@gmail.com> <20260311-ayn-qcs8550-v2-2-e66986e0f0cb@gmail.com> <4757fd22-fe9f-4228-a0a5-11d9309549ac@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=GNoF0+NK c=1 sm=1 tr=0 ts=69c10a4a cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=pGLkceISAAAA:8 a=PRwFffclZ0ixmdfpURsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3NCBTYWx0ZWRfX2wnLAOfH8EmQ da9IhS+pNyTXWpFOoxMdbhslUtqmlpMkj1zdiBcJAVeU515Xkhq94uuR0FnzZtYcgFqHed1f6RC wjihGBPEF86oUTw63HXpBTWtNfqcEa0sqrcnHuvYsQYT5W47wsdf5+UZ5hLRxlZJOQS0//Yokzf rzG820DRuZlRsluvOoTAXd7VPyW5FNRw1Tp0KaUzIKXwu8G6bZT3Sa9HET+coYISpsVpE0UwXjy M8U/5C31/yL6C9usZ1UD8S+xHm9Smju4DKtGg3JHSHO8wcvvxi0GbOTG3ZxXu+4O3iQoINE6uvp eQ3b8h9P0vzkMCBJdqgZ0Z0MwsckPoZHyeJaBoUs+yQRXxTXlddTlwujNLfwdKUpL32O+mvqyer PQ0yPaoY6VHE6N9FtWc4Et7Uosq8OT3Li8zfk+nV230QyhhobZ2nxL9t6WL7pLLyRKIhBYjAtqV +6I3bgCXAfyguQVUoGg== X-Proofpoint-ORIG-GUID: lEmdVyNvm1d2JXayqacAuunZX-VtlgZq X-Proofpoint-GUID: lEmdVyNvm1d2JXayqacAuunZX-VtlgZq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_03,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230074 On 3/19/26 11:31 PM, Aaron Kling wrote: > On Wed, Mar 11, 2026 at 7:49 PM Val Packett wrote: >> >> On 3/11/26 2:44 PM, Aaron Kling wrote: >> >>> From: Teguh Sobirin >>> >>> This adds a base dtb of everything common between the AYN QCS8550 >>> devices. It is intended to be extended by device specific overlays. >>> >>> Signed-off-by: Teguh Sobirin >>> Co-developed-by: Aaron Kling >>> Signed-off-by: Aaron Kling >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 1 + >>> arch/arm64/boot/dts/qcom/qcs8550-ayntec-common.dts | 1777 ++++++++++++++++++++ >>> 2 files changed, 1778 insertions(+) >>> […] >>> +/ { >>> + model = "AYN QCS8550 Common"; >>> + compatible = "ayntec,qcs8550-common", "qcom,qcs8550", "qcom,sm8550"; >> >> Huh?.. All existing -common files are .dtsi includes without their own >> model/compatible, and the compile-time "dtbo" support is only used for >> EL2 where we want to apply the same thing to many many devices without >> polluting the tree with extra glue files. I don't see why this should be >> a "common device" with its own compatible string, and not just a dtsi. >> >>> […] >>> +&gpu { >>> + status = "okay"; >>> + >>> + zap-shader { >>> + firmware-name = "qcom/sm8550/a740_zap.mbn"; >>> + }; >>> +}; >> >> Please use the &gpu_zap_shader label. >> >> And does the generic zap actually just work? >> >>> […] >>> +&i2c0 { >>> + clock-frequency = <400000>; >>> + status = "okay"; >>> +}; >>> + >>> +&i2c4 { >>> + clock-frequency = <400000>; >>> + status = "okay"; >>> +}; >>> + >>> +&i2c12 { >>> + clock-frequency = <400000>; >>> + status = "okay"; >>> +}; >> If the individual devices actually use these busses, better to enable >> them inside of their .dts as well I think? >>> +&iris { >>> + status = "okay"; >>> +}; >> Works with generic firmware? >>> […] >>> +&pcie0 { >>> + wake-gpios = <&tlmm 96 GPIO_ACTIVE_HIGH>; >>> + perst-gpios = <&tlmm 94 GPIO_ACTIVE_LOW>; >> Current binding is to put these inside of the &pcieportN (renaming >> 'perst' to 'reset' which I just noticed I failed to do for one of my own >> files :D), see x1e78100-lenovo-thinkpad-t14s.dtsi for an example. > > I tried making this change, but the pcie port failed to probe. I also > notice that all existing sm8550 devices still use the 'old' syntax. There's a ""feature"" in the parsing code that will only let this work if both 'phys' and 'xxx-gpios' are under the same node (i.e. both under PCIe OR both under the root port), I think this may be changed by a single big change later on Konrad