From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
mchehab@kernel.org, gregkh@linuxfoundation.org
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: Hantro: Correct G2 init qp field
Date: Fri, 27 May 2022 16:05:51 -0400 [thread overview]
Message-ID: <fd8c9ef48b48e014c468fe8cf61cd44062d14b1d.camel@ndufresne.ca> (raw)
In-Reply-To: <20220524115945.2294015-1-benjamin.gaignard@collabora.com>
Le mardi 24 mai 2022 à 13:59 +0200, Benjamin Gaignard a écrit :
> Documentation said that g2 init_qp field use bits 24 to 30 of
> the 8th register.
> Change the field mask to be able to set 7 bits and not only 6 of them.
>
> Conformance test INITQP_B_Main10_Sony_1 decoding is OK with this
> patch.
>
> Fixes: cb5dd5a0fa518 ("media: hantro: Introduce G2/HEVC decoder")
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> With this patch and the patches needed for 10-bit support
> Fluster HEVC score is 137/147
>
> version 2:
> - Add Fixes tag
>
> drivers/staging/media/hantro/hantro_g2_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/hantro/hantro_g2_regs.h b/drivers/staging/media/hantro/hantro_g2_regs.h
> index 877d663a8181..82606783591a 100644
> --- a/drivers/staging/media/hantro/hantro_g2_regs.h
> +++ b/drivers/staging/media/hantro/hantro_g2_regs.h
> @@ -107,7 +107,7 @@
>
> #define g2_start_code_e G2_DEC_REG(10, 31, 0x1)
> #define g2_init_qp_old G2_DEC_REG(10, 25, 0x3f)
> -#define g2_init_qp G2_DEC_REG(10, 24, 0x3f)
> +#define g2_init_qp G2_DEC_REG(10, 24, 0x7f)
> #define g2_num_tile_cols_old G2_DEC_REG(10, 20, 0x1f)
> #define g2_num_tile_cols G2_DEC_REG(10, 19, 0x1f)
> #define g2_num_tile_rows_old G2_DEC_REG(10, 15, 0x1f)
prev parent reply other threads:[~2022-05-27 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 11:59 Benjamin Gaignard
2022-05-27 20:05 ` Nicolas Dufresne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8c9ef48b48e014c468fe8cf61cd44062d14b1d.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=benjamin.gaignard@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®