From: Guenter Roeck <linux@roeck-us.net>
To: Li Qiang <liqiang01@kylinos.cn>
Cc: thomas.richard@bootlin.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: cgbc-hwmon: Add missing NULL check after devm_kzalloc()
Date: Fri, 17 Oct 2025 05:42:30 -0700 [thread overview]
Message-ID: <fd8d7d4c-adcf-4703-9804-09a35aefc24f@roeck-us.net> (raw)
In-Reply-To: <20251017063414.1557447-1-liqiang01@kylinos.cn>
On Fri, Oct 17, 2025 at 02:34:14PM +0800, Li Qiang wrote:
> The driver allocates memory for sensor data using devm_kzalloc(), but
> did not check if the allocation succeeded. In case of memory allocation
> failure, dereferencing the NULL pointer would lead to a kernel crash.
>
> Add a NULL pointer check and return -ENOMEM to handle allocation failure
> properly.
>
> Signed-off-by: Li Qiang <liqiang01@kylinos.cn>
> Reviewed-by: Thomas Richard <thomas.richard@bootlin.com>
Applied.
Guenter
prev parent reply other threads:[~2025-10-17 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 6:34 Li Qiang
2025-10-17 8:12 ` Thomas Richard
2025-10-17 12:42 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8d7d4c-adcf-4703-9804-09a35aefc24f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiang01@kylinos.cn \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®