From: "Yu Zhang (Yuriy)" <quic_yuzha@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
<andersson@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: <agross@kernel.org>, <ath11k@lists.infradead.org>,
<dmitry.baryshkov@linaro.org>, <konradybcio@kernel.org>,
<kvalo@kernel.org>, <linux-media@vger.kernel.org>,
<mchehab@kernel.org>, <quic_jjohnson@quicinc.com>,
<quic_miaoqing@quicinc.com>, <quic_vgarodia@quicinc.com>,
<stanimir.k.varbanov@gmail.com>, <quic_jiaymao@quicinc.com>
Subject: Re: [PATCH v3] arm64: dts: qcom: qcs615: add WiFi/BT nodes
Date: Tue, 10 Dec 2024 10:37:44 +0800 [thread overview]
Message-ID: <fd8dd19a-a15b-48a3-ab14-9c63e617ed10@quicinc.com> (raw)
In-Reply-To: <7107275e-1ccf-4f09-ada3-e082833d9364@oss.qualcomm.com>
On 12/6/2024 8:16 PM, Konrad Dybcio wrote:
> On 6.12.2024 4:22 AM, Yu Zhang (Yuriy) wrote:
>>
>>
>> On 12/6/2024 1:14 AM, Konrad Dybcio wrote:
>>> On 3.12.2024 7:03 AM, Yu Zhang(Yuriy) wrote:
>>>> Add a node for the PMU module of the WCN6855 present on the qcs615
>>>> board. Assign its LDO power outputs to the existing WiFi/BT module.
>>>>
>>>
>>> subject:
>>>
>>> arm64: dts: qcom: qcs615-ride: ....
>>>
>>> [...]
>>>
>>>> +
>>>> + vreg_conn_1p8: vreg_conn_1p8 {
>>>> + compatible = "regulator-fixed";
>>>> + regulator-name = "vreg_conn_1p8";
>>>> + startup-delay-us = <4000>;
>>>> + enable-active-high;
>>>> + gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
>>>> + };
>>>> +
>>>> + vreg_conn_pa: vreg_conn_pa {
>>>> + compatible = "regulator-fixed";
>>>> + regulator-name = "vreg_conn_pa";
>>>> + startup-delay-us = <4000>;
>>>> + enable-active-high;
>>>> + gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
>>>> + };
>>>
>>> Are any of these boot-on?
>>>
>> Yes, these are used wcn6855-pmu:
>> vddio-supply = <&vreg_conn_pa>;
>> vddpmu-supply = <&vreg_conn_1p8>;
>
> What i meant is, whether these regulators are enabled at boot
> time (i.e. without software intervention). If that's the case,
> `regulator-boot-on;` should be added
>
No need regulator-boot-on, it was triggered by the
software(pci_pwrctl_pwrseq_driver).
> Konrad
Yu
prev parent reply other threads:[~2024-12-10 2:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 6:03 Yu Zhang(Yuriy)
2024-12-03 13:08 ` Dmitry Baryshkov
2024-12-05 17:14 ` Konrad Dybcio
2024-12-06 3:22 ` Yu Zhang (Yuriy)
2024-12-06 12:16 ` Konrad Dybcio
2024-12-10 2:37 ` Yu Zhang (Yuriy) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8dd19a-a15b-48a3-ab14-9c63e617ed10@quicinc.com \
--to=quic_yuzha@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_jiaymao@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_miaoqing@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®