From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6F68167DB7 for ; Fri, 3 Jan 2025 18:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735928903; cv=none; b=Cdm/AWOm39GNSHmv5hK6Hy/CEd1R8jgfoxLrat0j2wSeZK6rLpHULOGEBU7LVQpg11y08T3vDB3BS4biG2Nmc1suFRYkW0N1UPXft5HDdA1Ds9lVROQvQsAycz68L5INacQ/2sGDff9SsdNed4T0D5uESsRD6kcdcnpDUcZWo2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735928903; c=relaxed/simple; bh=OxHGNHUTwYx5DiOt271WvdXAMXFzbsdX1sSvU+iPY9E=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=kyYGJFTBgcdq1xlHOz5VHOPnC1js78WH47whzzqQoqHtnHmSWiFzeF9MQMCn+8VuTL8mWDkVOgPy3gFlzvlXrlx6kbeAwc/SUqE9HBbbyIxFK6MZ2a2sNZV6jyHISCFfM5V4gCKTmTm+aB9fhq3dh8fgeORPwiNzwZ1FFQd/kCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=shelob.surriel.com; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tTmOb-000000004eZ-2eZc; Fri, 03 Jan 2025 13:27:41 -0500 Message-ID: Subject: Re: [PATCH 03/12] x86/mm: add X86_FEATURE_INVLPGB definition. From: Rik van Riel To: Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Date: Fri, 03 Jan 2025 13:27:41 -0500 In-Reply-To: <20250102120450.GNZ3aA4oVPnoJYRVUL@fat_crate.local> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-4-riel@surriel.com> <20250102120450.GNZ3aA4oVPnoJYRVUL@fat_crate.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: riel@surriel.com On Thu, 2025-01-02 at 13:04 +0100, Borislav Petkov wrote: > On Mon, Dec 30, 2024 at 12:53:04PM -0500, Rik van Riel wrote: > >=20 > > +++ b/arch/x86/include/asm/cpufeatures.h > > @@ -338,6 +338,7 @@ > > =C2=A0#define X86_FEATURE_CLZERO (13*32+ 0) /* "clzero" > > CLZERO instruction */ > > =C2=A0#define X86_FEATURE_IRPERF (13*32+ 1) /* "irperf" > > Instructions Retired Count */ > > =C2=A0#define X86_FEATURE_XSAVEERPTR (13*32+ 2) /* "xsaveerptr" > > Always save/restore FP error pointers */ > > +#define X86_FEATURE_INVLPGB (13*32+ 3) /* "invlpgb" > > INVLPGB instruction */ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^^^^^^^^^ >=20 > We don't show random CPUID bits in /proc/cpuinfo anymore so you can > remove > that. I still see dozens of flags in /proc/cpuinfo here on 6.11. When did that change? >=20 > > =C2=A0#define X86_FEATURE_RDPRU (13*32+ 4) /* "rdpru" Read > > processor register at user level */ > > =C2=A0#define X86_FEATURE_WBNOINVD (13*32+ 9) /* "wbnoinvd" > > WBNOINVD instruction */ > > =C2=A0#define X86_FEATURE_AMD_IBPB (13*32+12) /* Indirect > > Branch Prediction Barrier */ > > --=20 >=20 > Also, merge this patch with the patch which uses the flag pls. The first real use is 3 patches further down into the series.=20 I'm not convinced things will be more readable if 4 patches get squashed down into one. Are you sure you want that? --=20 All Rights Reversed. --=20 All Rights Reversed.