mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Swamil Jain <s-jain1@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <jyri.sarha@iki.fi>, <tomi.valkeinen@ideasonboard.com>,
	<airlied@gmail.com>, <simona@ffwll.ch>,
	<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <devarsht@ti.com>, <praneeth@ti.com>,
	<bb@ti.com>, <vigneshr@ti.com>, <dri-devel@lists.freedesktop.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support
Date: Tue, 30 Dec 2025 19:52:51 +0530	[thread overview]
Message-ID: <fd9f0b37-001e-4721-82b7-ee29379eb9a9@ti.com> (raw)
In-Reply-To: <20251230022741.GA3217586-robh@kernel.org>

Hi Rob,

On 12/30/25 07:57, Rob Herring wrote:
> On Wed, Dec 24, 2025 at 07:01:50PM +0530, Swamil Jain wrote:
>> Update the AM65x DSS bindings to support AM62L which has a single video
>> port. Add conditional constraints for AM62L.
>>
>> Signed-off-by: Swamil Jain <s-jain1@ti.com>
>> ---
>>   .../bindings/display/ti/ti,am65x-dss.yaml     | 95 +++++++++++++++----
>>   1 file changed, 76 insertions(+), 19 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> index 38fcee91211e..ce39690df4e5 100644
>> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> @@ -36,34 +36,50 @@ properties:
>>     reg:
>>       description:
>>         Addresses to each DSS memory region described in the SoC's TRM.
>> -    items:
>> -      - description: common DSS register area
>> -      - description: VIDL1 light video plane
>> -      - description: VID video plane
>> -      - description: OVR1 overlay manager for vp1
>> -      - description: OVR2 overlay manager for vp2
>> -      - description: VP1 video port 1
>> -      - description: VP2 video port 2
>> -      - description: common1 DSS register area
>> +    oneOf:
>> +      - items:
>> +          - description: common DSS register area
>> +          - description: VIDL1 light video plane
>> +          - description: VID video plane
>> +          - description: OVR1 overlay manager for vp1
>> +          - description: OVR2 overlay manager for vp2
>> +          - description: VP1 video port 1
>> +          - description: VP2 video port 2
>> +          - description: common1 DSS register area
>> +      - items:
>> +          - description: common DSS register area
>> +          - description: VIDL1 light video plane
>> +          - description: OVR1 overlay manager for vp1
>> +          - description: VP1 video port 1
>> +          - description: common1 DSS register area
>>   
>>     reg-names:
>> -    items:
>> -      - const: common
>> -      - const: vidl1
>> -      - const: vid
>> -      - const: ovr1
>> -      - const: ovr2
>> -      - const: vp1
>> -      - const: vp2
>> -      - const: common1
>> +    oneOf:
>> +      - items:
>> +          - const: common
>> +          - const: vidl1
>> +          - const: vid
>> +          - const: ovr1
>> +          - const: ovr2
>> +          - const: vp1
>> +          - const: vp2
>> +          - const: common1
>> +      - items:
>> +          - const: common
>> +          - const: vidl1
>> +          - const: ovr1
>> +          - const: vp1
>> +          - const: common1
>>   
>>     clocks:
>> +    minItems: 2
>>       items:
>>         - description: fck DSS functional clock
>>         - description: vp1 Video Port 1 pixel clock
>>         - description: vp2 Video Port 2 pixel clock
>>   
>>     clock-names:
>> +    minItems: 2
>>       items:
>>         - const: fck
>>         - const: vp1
>> @@ -84,7 +100,8 @@ properties:
>>       maxItems: 1
>>       description: phandle to the associated power domain
>>   
>> -  dma-coherent: true
>> +  dma-coherent:
>> +    type: boolean
>>   
>>     ports:
>>       $ref: /schemas/graph.yaml#/properties/ports
>> @@ -195,6 +212,46 @@ allOf:
>>               port@0:
>>                 properties:
>>                   endpoint@1: false
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: ti,am62l-dss
>> +    then:
>> +      properties:
>> +        clock-names:
>> +          maxItems: 2
>> +        clocks:
>> +          maxItems: 2
>> +        reg:
>> +          maxItems: 5
> 
>             reg-names:
>               minItems: 8
>         else:
>           properties:
>             reg:
>               minItems: 8
>             reg-names:
>               minItems: 8
> 
> clocks needs similar constraints...

Sure, will add in v2.

> 
>> +
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: ti,am62l-dss
>> +    then:
>> +      properties:
>> +        reg-names:
>> +          items:
>> +            - const: common
>> +            - const: vidl1
>> +            - const: ovr1
>> +            - const: vp1
>> +            - const: common1
>> +    else:
>> +      properties:
>> +        reg-names:
>> +          items:
>> +            - const: common
>> +            - const: vidl1
>> +            - const: vid
>> +            - const: ovr1
>> +            - const: ovr2
>> +            - const: vp1
>> +            - const: vp2
>> +            - const: common1
> 
> Why are you defining the names twice?
>

For AM62L we don't have "vid", "ovr2" and "vp2", the dtbs_check will fail.
Could you please suggest a better way?

Regards,
Swamil.

> Rob
> 


  reply	other threads:[~2025-12-30 14:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-24 13:31 Swamil Jain
2025-12-30  2:27 ` Rob Herring
2025-12-30 14:22   ` Swamil Jain [this message]
2026-01-02 22:34     ` Rob Herring
2026-01-16  5:51       ` Swamil Jain
2026-01-30  6:04       ` Swamil Jain
2026-02-05 13:27         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd9f0b37-001e-4721-82b7-ee29379eb9a9@ti.com \
    --to=s-jain1@ti.com \
    --cc=airlied@gmail.com \
    --cc=bb@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jyri.sarha@iki.fi \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=praneeth@ti.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®