From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE27ACD13CF for ; Sun, 17 Sep 2023 09:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235942AbjIQJOi (ORCPT ); Sun, 17 Sep 2023 05:14:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235758AbjIQJOJ (ORCPT ); Sun, 17 Sep 2023 05:14:09 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31FD71B1 for ; Sun, 17 Sep 2023 02:13:56 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9ada2e6e75fso460671066b.2 for ; Sun, 17 Sep 2023 02:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694942035; x=1695546835; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NxqlGhwY2fUZ1yfWj7spM6aDi6ioSNbYpolJVQsFDKM=; b=siugGCj9SZS0BomloQwlUv1zg2uym/mHjE3Cy4jXcFYhsbLkY13zo0nLIywJXZ4wrd P8b3cpWJSFwI6V2KMwec4kWa55/5neHTSqgOURkShunFfaXgpsW41Tougnesf/xt/L3j CIJJH5W57cCHlCb7STf7NPrNttsetjJs8YtOQTP0zcv8ST9cNzIOe0HlSRFKEn30JePj xiCP8Y4i7IWxxKTw57Qu4VKC4wvmWX8rbYTtTsiUYoKl59l2sWD2Yym6qoFib261Bvvd SzmvZtGa16RE9IpbegxEuK3RmBSX0w9QmGzSZSXFccNCxjAM8CjAzHXDr9ghbXC+E+RQ g1Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694942035; x=1695546835; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NxqlGhwY2fUZ1yfWj7spM6aDi6ioSNbYpolJVQsFDKM=; b=pt9rlLWJGqew1S9r3zWanhCyWxqr0IkfdMCaB0ClbpMLWT+EKLCZE7JmzCQ+uEJ1rP aeTPF8sUjymvo71Y6589SaQlT7mnOJoWmE5aizXgSuJk94KNXDed8kmJXGs++oK1TKIX xDXcgKxSMFDZSUkndDFDbtAQxRxo77JBpLJx0MBgq80quJgyy2zY1STlTW6xAW+PWVgH 11P2/yD4psEcYZMwLTFhjV0Ugs4zYbSpy1G2N8iMgXu1N1zEHNYx7mi4MS0i34d4p1c0 QTd3rK6Pd0FBhpGV3dtYe245lLibYGWusfBz7cKoOSdG375b1kHOHYVMvO/gjZjee3Jz OPUA== X-Gm-Message-State: AOJu0YwYh8A9RcSJDHHd62MfwLXEy12nPJA7tz+Gt+aPefWWgN8OZjMF ChDX3sbvWbA86jf16sZF9a+A7A== X-Google-Smtp-Source: AGHT+IGznPIr/6FkDMahjI+c8MV7cCopeOQZUE2NeRKnvXfh8yjYJZkt5NVaMdJFOFmqqD2PMB4+Ew== X-Received: by 2002:a17:906:8a4c:b0:9a9:dfbe:ca99 with SMTP id gx12-20020a1709068a4c00b009a9dfbeca99mr5709211ejc.10.1694942035483; Sun, 17 Sep 2023 02:13:55 -0700 (PDT) Received: from [192.168.1.77] (150-140-187-31.ftth.glasoperator.nl. [31.187.140.150]) by smtp.gmail.com with ESMTPSA id o10-20020a1709061d4a00b0099293cdbc98sm4781973ejh.145.2023.09.17.02.13.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Sep 2023 02:13:54 -0700 (PDT) Message-ID: Date: Sun, 17 Sep 2023 11:13:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: Add pm8916 vm-bms and lbc Content-Language: en-US To: Nikita Travkin Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20230916-pm8916-dtsi-bms-lbc-v1-0-7db0b42f9fb1@trvn.ru> <20230916-pm8916-dtsi-bms-lbc-v1-1-7db0b42f9fb1@trvn.ru> <18bef7a4-608b-9ba3-ce8f-ca25999705c3@linaro.org> <011074e5-cec2-1c69-7324-30d9ab653577@linaro.org> <27adb905b990398989b4c13f03339ae9@trvn.ru> From: Krzysztof Kozlowski In-Reply-To: <27adb905b990398989b4c13f03339ae9@trvn.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/09/2023 10:54, Nikita Travkin wrote: >>>>> + "^battery@[0-9a-f]+$": >>>>> + type: object >>>>> + oneOf: >>>>> + - $ref: /schemas/power/supply/qcom,pm8916-bms-vm.yaml# >>>> >>>> That's just ref, so no need for oneOf... unless you already think this >>>> will grow with different schemas like the charger below? >>>> >>> >>> Yes, I think some other PMICs have different battery/fuel-gauge >>> blocks too so I'd like to have some room for expansion here. >> >> There is always room. Which other device will have different battery >> charger? >> > > I know of non-"VM" BMS block in PM8226. It's used on some Nokia > devices that people were working on so I expect it to appear in > the future. > > There is also some BMS block in more modern PM6150 that I've > seen being looked at by people interested in bringing sm7125 > phones upstream. > > Both of those, to my knowledge, are completely different from > this VM-BMS block, which I believe was present in the generation > of pm8916, pm8909 and was abandoned again shortly after... OK, sounds good. Best regards, Krzysztof