From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DB511DB145 for ; Wed, 15 Jan 2025 12:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736943154; cv=none; b=RHNzCf+wKCL8nyJMCsQmZ4Cw5AWgxbFHRvZXP30QLhD31Qu8EH7H5w0e6jJSusq4SdEobghkdYZSyhFj4IyIdIAe5V65sfvNRQmumQlXD6wiyJ5jjVVPF1vecIAdoePSb7Ir4XC2vapuEyRt7rF4Go2EUBNeMg0ZACesB4KDMak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736943154; c=relaxed/simple; bh=4fCBYRolOuX5rKFIv4j7DNBKyYaxKeMQalVJfvGst+M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OW7rcL/gspnKWj4TvS8S4VeZD1Qs2y8FrxP2u2DW0sTdOKxuwgf/U7B0yG5cPiVi8ZBaU9nQkWgX9b0ByNCroPXIlgFdOiixQGxG7s2QA5YdkYaAZbHYeInS/PgDqQT29hfljOYFas/Bw/4wfCqlPPPzzXfauBL4n6Skas7XhYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sRATwynI; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sRATwynI" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-38633b5dbcfso6731418f8f.2 for ; Wed, 15 Jan 2025 04:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736943151; x=1737547951; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cFKwmVwiS7IFaxPoXvsho9KfAcIhxJ1ZRpPv8inn8w8=; b=sRATwynIP6ikdnjAD+8TsQ+twOeCzUUs87D3ICq+C5GG/kfkw0aRMyo2zWiqxfjjCa pbIYkThtjvwTHngU//Cg52nDau41sG2718VCAeovMp6CjLrLWpHRHzMSJKSvRT3o82x7 hLLBM8yeT0xMcbRF/bzEfpbkviZgeNP7c8NlbUDzto/7MDT4JsSDUQiKZiEoEB2O1ogq dC0h1718b94r8H2VMUl73ily+hVRcFNhIfeWENkdMI5oKgoBx9Hmi3c//wAwZCOhqRlH VKzcN5sPvTOemkw9UqeibXe8xTAJoqpd2nN/n9bj81SSfFyOk2Udh38mFwu+t0HNntMJ RBUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736943151; x=1737547951; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cFKwmVwiS7IFaxPoXvsho9KfAcIhxJ1ZRpPv8inn8w8=; b=SgLg/mW7d/TU971GWptxX5f7deN+nmf1zDI8+vpr7EdS3j1l47VNfWhQm2DJ3voMVr Ddi2aI6LRNhr95GB6a7sCfldQ+lRVqQH0i0ZiQjV37A2ymxmplQQhBv4j0uuchON44Wm t/RHUWodKLy+wXpez4Bzkbx3vSIZFLM2WGetDBsuP7EFRy0+YyHOTplb0lE0slU81E4v 0bBrRJQdcrIP/dgtFP+Jd4XLb5y8F70Y42H/pa/8ulcdflKkZQtMs1f8iiMtPs+WnwjO m2RdW7uS37O1z8Dja2/SKLeF6SDnt9CXh5GsZLioBdk4buvU7j0IsilxY1X/Vl4n7fkt v0CA== X-Forwarded-Encrypted: i=1; AJvYcCWdfsPuzl19j0nRpO9vnZcoRWp9A5fJM/sCbSxWTky59TBUS0ZPR0VgLxJUmuLMBcanpOAJRhv5MpSM/m4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzed3D2KP1/jm4NUR44rQIF5C1u3JIc4LNbyWgGBvqncFH0knZF LAERgoIi5vfxz0bT5moJXbv7whVC9HE3qjXmtdqwcExYqrPY4Hwo4g+ocsg0H01H3HAcBpmg10+ 7 X-Gm-Gg: ASbGncu14Qt2aJ0CpMh8QgRZkuyh93AYKSBz7I/pnHHFqdLszrAO5Po0eb8AaHScX7N QPziJS3QPWDxkTMg6lcteMNlaR0tWZ///AvGGo4ArhgoGtKtiiQeoY4l/H2vXrzpbw38gRDF3+m TwoSfxB70t1E7JETWaNpmVB3+d3GQWu5OvpQMTDBiXK7ao/iH08iuGvU5MFwnBRkQO/P5R8x+UV DOgcnqvv4X3xuHE9nV81qpx+d0J2y/BVMi4MKwLaB03U+FqygNHhkens3PGiUiV8Z8LBrK+VJAc ZGf4g7YP53X9yq85fmcH0l9O3bTt X-Google-Smtp-Source: AGHT+IEnq6vo1E5LSI2Qrhm/y3n3Xe++W2QNQ6RQqz61y+rXMn7THrldWxmRVHgfkDHSnoXO9oEzlg== X-Received: by 2002:a05:6000:4802:b0:385:e877:c037 with SMTP id ffacd0b85a97d-38a87338d79mr24645826f8f.42.1736943150788; Wed, 15 Jan 2025 04:12:30 -0800 (PST) Received: from ?IPV6:2a01:e0a:5ee:79d0:cf13:bc18:6c34:e11a? ([2a01:e0a:5ee:79d0:cf13:bc18:6c34:e11a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4c1c01sm17722217f8f.97.2025.01.15.04.12.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2025 04:12:30 -0800 (PST) Message-ID: Date: Wed, 15 Jan 2025 13:12:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: mediatek: add mmc2 support for mt8365-evk To: AngeloGioacchino Del Regno , macpaul.Lin@mediatek.com Cc: vsatoes@baylibre.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger References: <20250109-mmc2-support-v1-1-9b9d1b1ae35d@baylibre.com> <91ac34bf-e184-486d-9af7-f9ddaf8f26ed@collabora.com> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: <91ac34bf-e184-486d-9af7-f9ddaf8f26ed@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/01/2025 11:38, AngeloGioacchino Del Regno wrote: >> +&mmc2 { >> +    assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL>; >> +    assigned-clocks = <&topckgen CLK_TOP_MSDC50_2_SEL>; >> +    bus-width = <4>; >> +    cap-sd-highspeed; >> +    cap-sdio-irq; >> +    hs400-ds-delay = <0x12012>; >> +    keep-power-in-suspend; > > Why keep-power-in-suspend? This slot is mainly used for WiFi / BT / GPS chip, which need to keep powered on. I guess this is to avoid to do full re-init, re-load firmware, lose context, wake-up from it... TBH, I didn't work on it, all I know is MTK need it. -- Regards, Alexandre