From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C5202FF153 for ; Wed, 4 Mar 2026 06:05:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772604330; cv=none; b=GCziE/wSorSsrWspbOx97lxPpl4HNJQIZr6YasSLinpRYND0pLq0NKZ7b/+4+Bw2znJzFQYqWqAiwB4B5k92KZCKfkaFPAgB8sCnF5DZIJWEx7O17BkeMPEjkF0POjAih3XtKS0ZFmRWTXdtQ7CH/JcxmuutRpjeI3jVYQze2BQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772604330; c=relaxed/simple; bh=D6bKcFrH2eJAhaghmI19rLoQQ4vDcxghtYuRg29WGcg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=NsalnyoPlE7rl/jnvfAIn2sOxHTxPeC2PdTvujrHj5vbFRN4wxJrByfPetNgMHKtom+0wa31YlCSc+DYNpyW6elawYvAKUC7Qr83LaqvKgMjpVxawQ16alZ6a5JVA4X0V3EAEpmiLZFFj55TOsNOrEBhgpA5Pr0fW7LlpBn6Xqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=meaIR0+8; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="meaIR0+8" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2aaf59c4f7cso29713925ad.1 for ; Tue, 03 Mar 2026 22:05:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772604328; x=1773209128; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=I4jzwjHLv2KUZF1szEBLqYn8fq/YjRSK6XfOmgw2EUs=; b=meaIR0+8jGThPtQZT0oYJ1qCBpdLEDdrkOU28QEseDuA6uatRw/V2xSpHSZxSnvgv8 zTqizQAMVnENl0+qy6fs3yAWk4G3EqgK0vc5yDVI4lBsvOC+jMOcSdaXyxRkPiHvLHls W57ryb9ljzyB03Xn1YNpSWLsROs0HtfSp59D8mWFqz4m+6KMxIG5wg7JSgGR4s0rvNig wzAsKdt32XW4LZzEzDQ/UZtrBEmlryZc7th5tJ/zpdNZElMqwGAdLqcA5gxfgUptPsaA 7cOklsp6U9/yDfd25/ZxABFH9IW/nSA+LImpRQhEGII5J5pjncxlA6k7EyRck2bAl5H9 HuUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772604328; x=1773209128; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I4jzwjHLv2KUZF1szEBLqYn8fq/YjRSK6XfOmgw2EUs=; b=nPMFr+5LxJhAhAcV9QVbPxMb2lgWw83Y4En+SG705KEaST8vy0QREGtLm7HQ/bfXMi QuUwlqADy3IXdmM1jhjQEjTLTnzb/UVn3gX+laZq1rCPofJtS8IpWtbRfW5dDSeEFgQn 8QeetyobIgUxbURm6Fr9I1oE1xJObIpJygCJtqZ+pMtbFq9tuT49YHWlauyCOAFZPftR nKZ4xMtrTQrLZ7Sy+1TJbv5mEL6EJSs8vE/drIEbj4YwmN/mwZKyKy6N+4lL+tkBtz6l G+1RlNoAAebuf3mlU6bqm/bXl2L97y+IUYL33uxrl43/QcIBwWomFnp3LkXz/uyN138Q RNfA== X-Forwarded-Encrypted: i=1; AJvYcCW1pUIlzEJrzZCVV8ndTwJd3OORRCGAI/37RUwCCsVWEZ9wrNz3C8/OcW01UI40sEbV/L29cqb0yZYCc8I=@vger.kernel.org X-Gm-Message-State: AOJu0YwZDPrRJtRv7oAIwp7HFFG4CcfarRRo3jKp0b6wQLbtQqilvC/L g0VRABfzxN3HgeBg2K773BCIS+LCcq4qQd298dI3iH4u9IG8uD5cC5vV X-Gm-Gg: ATEYQzyM44HGUoyWn1g0hbTxGoss3NCF4clEvMWyizmn6XFmYsBwVEEfPNGBjVRi6f3 ZeGvKkSmYITQTty7NOIyk24N4va0RrMvb50RSwwhxnzfkz/kwYeJjeWIuGR9iTrC0C4mCpRBf/1 +OVE6eJPKrPzoqUfPW7C31oNrfUdJkDCaBgQfnY9PpjRtZxH9UJXK+758KF/Qn7xbP/QClPIk3V aNXz/KJ4g9xAX7CIfajQMJ8IEM0qm3X0++g/r/19ZyC/RZR5UFHQQYlhrjlOW4U5ForSIq4HmNk fF0x0GDQaEILdyJ/O1a2EKpF5O+oG4tOABpdJkc8XolZ+10wDnBsTvlK31QeJI71sazGBAZnnD8 ywPcSMPYkVSgjVRdggdboqlZmW6M/xSpgqjyvoVcbx6jkQaAynriX7HbkrSMBXmVlFcWbAGJJRZ Tev40UCIUG3cnV6L9Kx5pdxmDBZGc7MaD4Qv8aJAQoI8OEVehipWJf X-Received: by 2002:a17:902:d590:b0:2ae:456d:b836 with SMTP id d9443c01a7336-2ae6ab365damr11199975ad.47.1772604328378; Tue, 03 Mar 2026 22:05:28 -0800 (PST) Received: from [192.168.0.226] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6f3436sm265491385ad.88.2026.03.03.22.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 22:05:27 -0800 (PST) Message-ID: Subject: Re: [PATCH bpf-next v5 1/5] bpf: Move JIT for single-subprog programs to verifier From: Eduard Zingerman To: Xu Kuohai , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Yonghong Song , Puranjay Mohan , Anton Protopopov Date: Tue, 03 Mar 2026 22:05:23 -0800 In-Reply-To: <20260302102726.1126019-2-xukuohai@huaweicloud.com> References: <20260302102726.1126019-1-xukuohai@huaweicloud.com> <20260302102726.1126019-2-xukuohai@huaweicloud.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-03-02 at 18:27 +0800, Xu Kuohai wrote: [...] > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > index fc4ccd1de569..ab2bc0850770 100644 > --- a/kernel/bpf/verifier.c > +++ b/kernel/bpf/verifier.c > @@ -26086,6 +26086,11 @@ int bpf_check(struct bpf_prog **prog, union bpf_= attr *attr, bpfptr_t uattr, __u3 > convert_pseudo_ld_imm64(env); > } > =20 > + /* constants blinding in the JIT may increase prog->len */ > + len =3D env->prog->len; > + if (env->subprog_cnt =3D=3D 1) > + env->prog =3D bpf_prog_select_jit(env->prog, &ret); > + I probably miss something important, but would it be possible to put a call to __bpf_prog_select_runtime() here and remove it from syscall.c:bpf_p= rog_load()? Thus avoiding the need for `jit_attempted` parameter. [...]