From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995F2C55ABD for ; Fri, 13 Nov 2020 18:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E17F5221EB for ; Fri, 13 Nov 2020 18:49:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jgYj4NIN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbgKMSt2 (ORCPT ); Fri, 13 Nov 2020 13:49:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726113AbgKMSt2 (ORCPT ); Fri, 13 Nov 2020 13:49:28 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1513EC0613D1 for ; Fri, 13 Nov 2020 10:49:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=zlmAODAdEVo5z5IEtpT54+dtERCJ2wuOwk2yef+rXKs=; b=jgYj4NINmhpBdN0qFRcvhqCIzX MjAoo9aZfOK7jIEmQXQjZogENH2Ew8RoEsF7prsrH5Nl6yM69Z+5ztESNSM337fn/KcF7krpKB+1C wpPx2JFdmYkuSLtmRbSvV0bO+oPPkCe7Ul7Ht2a33Gl2JOYOqYNkGNJHSUXjML/HS68ReAOJ7yZSU FSQRfck5NLt1VCylmchdkjedX8+kYaOxUgPeuLeKyUKZPUNwMPeY82ajsVFaXOQCAf5zyveEmllpg BRKmgojF1FJB5D4Wcj5v9udkDhpTPs6wHgWI9JrayZLLiqQ5eF6yeXALVSavvGF6UEd1paiN+0biu 1sEBTpGQ==; Received: from [2601:1c0:6280:3f0::662d] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kde8H-0004Nc-RY; Fri, 13 Nov 2020 18:49:14 +0000 Subject: Re: [PATCH] vdpasim: fix "mac_pton" undefined error To: Laurent Vivier , linux-kernel@vger.kernel.org Cc: "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, Jason Wang , kernel test robot References: <20201113155706.599434-1-lvivier@redhat.com> From: Randy Dunlap Message-ID: Date: Fri, 13 Nov 2020 10:49:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201113155706.599434-1-lvivier@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/20 7:57 AM, Laurent Vivier wrote: > ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined! > > mac_pton() is defined in lib/net_utils.c and is not built if NET is not set. > > Select GENERIC_NET_UTILS as vdpasim doesn't depend on NET. > > Reported-by: kernel test robot On Nov. 2, 2020: Reported-by: Randy Dunlap https://lore.kernel.org/lkml/d3d50a94-cdc5-572b-e9ca-3ee5638d21ee@infradead.org/ > Signed-off-by: Laurent Vivier > --- > drivers/vdpa/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig > index d7d32b656102..358f6048dd3c 100644 > --- a/drivers/vdpa/Kconfig > +++ b/drivers/vdpa/Kconfig > @@ -13,6 +13,7 @@ config VDPA_SIM > depends on RUNTIME_TESTING_MENU && HAS_DMA > select DMA_OPS > select VHOST_RING > + select GENERIC_NET_UTILS > default n > help > vDPA networking device simulator which loop TX traffic back > Thanks for the patch. -- ~Randy