From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B253D0BE9 for ; Thu, 21 May 2026 17:27:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779384433; cv=none; b=gVjK4/p4dW5PXZMMpkBNgkZUot8oUHR2YXStKllJ3GxfHFPrq8lK2cXeUT3Fj5jE2SjG6V7TooLpBZ7+IJ4LrQtBDvN8VA5XeH2Zs3aNcW0L5PgdNMSpdMuXzpiLPhLWRqEZlEVmeWcGqwitAtE+fWdaQnutZKEReXEbhKpbOII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779384433; c=relaxed/simple; bh=nUlLDXLr7tfwRxGNF7TRb9ZxBG1MttqUauLdbkr/FxM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Vq1DNkBS0KueJYsak7a++k5Qzf/BkFnDCEp5wkuxOfIVHzIj2UedOgrnOvqGUJVhXNVzDFg/53Sb8LJnpzxsGNiwX8cur3/8i8lYK7hV2YXpdcoHYfFSf6xPSgc+m7LoaRYLhtiUVytI97xJNPNyMs3BqdzgL0hw6hW5d3svy6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WSxreC+z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QfMyKU99; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WSxreC+z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QfMyKU99" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64LGkRE8613215 for ; Thu, 21 May 2026 17:27:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +FmAzQvTXDL4Pj4tgiqa+GkBPY2ik/1LnnIYJZAA6wU=; b=WSxreC+zI2Cjwhrd kQSl4+KqS2iyhyW758hXoX/WTxrBMQa7Y2ZZNSV2G9ecCLwnJTdbOXYKi0uHsWUH 5CSjSHTZqlA/MquVk/3k7NSsuSbq9kPn89xcAj9506uWle4Tj0BPf8rirACtJPEp AVEeBTZt7BbxFua3EngfyQYQBNHmTrgAeIkUAvjXv57fbGuJohUFEYrCXzTZFhQQ oShFmIj201Nio+qUCOoSaFRn8/ex61LhRKlxYtHaa1pLYVMYCh7XZD0+sgb4fjHy iOAFOTzxmvqIBLRoMrVxYOq+5E1H48oTjd29WaWrnOv3Kpcq56W6jWBa4qiWUsks xzgtqw== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ma44f4f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 17:27:10 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2f525565b33so7816169eec.0 for ; Thu, 21 May 2026 10:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779384430; x=1779989230; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=+FmAzQvTXDL4Pj4tgiqa+GkBPY2ik/1LnnIYJZAA6wU=; b=QfMyKU99Zty020hKcOYuqD2PbncVXgP8Hv1jAcN6dbhaTaGbYbvV0DejLJqJgXMlEz zAkrmfogn1IVoS4ZmGPzru0UHIhCktcDcA9950gyuMtC8tdrUrbU0Ys0FVkAoYveAzlH C7kx1c/afMmNs5QkOn4r7jGZgmggqRCLpNg9x8YIyKwyE/MYwIoV48XeiwG4QhqXKmY0 JaY+IRsK6rUT9NspH/ACsEHRvAqjOXz/P9dK0bSxB/31bDTRT/1EiNy6CGhMIcWajJRr OAlBK9SodmTAdoelrQC9xXn0RJSxi5GIi9NkZOeJIvktFdv9/sPLwxieP1Gk+RhIT1BX ZOvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779384430; x=1779989230; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+FmAzQvTXDL4Pj4tgiqa+GkBPY2ik/1LnnIYJZAA6wU=; b=MlbfTSB5vkZigqsw1MOZgXUWPuluG7vykF3gopSG8SmX8/Vh9ia+2OflkievakF2Oa dOd6BRN6amWU7XswYTASUN2rKymySFEiYqi1I1wjJ8Z6SJ1c8qu6HuwcxQAEWBn1a31X 18t2G29m/JVwdZGUy+qIx1esAwjyn+Enk6rVdBMvzBM/JDD2H9iUPmbQ7Lsxd1q7ETT+ dhTIwA9KJsa34pF30hhnAimwuP9Ieb8EZPoj1hlLE85N1VIzlclbgqks+JXP6r62p+SL UakYxosFsx5NyGEKxoWPfnmnnU2HHlcA71k77NIcXu8dqQnGoCOZeIhD98OY3UeQ32hY bTfw== X-Forwarded-Encrypted: i=1; AFNElJ+1uurn0nY15fbb2DXM6JHiB+7AV15TyVODB7T6G3g/Cn0MelrH9XXlv/thoIGyxCFu+pm1j207gGcMXbY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/ASKE/DciVqaQpkcYyW8dQjzieZLECxBLYRpVwoG12ZMWLada XxzfV3tKrSHCA33OaRDXP1HVZDtWeGGDd379E9Nx3vAdjZRvfl4OeOxRAt8zz8+HregbOLz/lbf DCtwGsri9iIMoEt6dmMxk02pqposrs3O2B4JLAGOtV73GlaTX4Io7Fsydcf3fLseUxvY= X-Gm-Gg: Acq92OFhrLR4P+3dgu7z/z3LbIs0x1j3i5zw8j/SddelSKVnjA83aTrhhiqQ063EzN3 RLRrtNWnQzSWpji14Rm30CW85ldZZpvuljNTtM2cvOs0TYA4RO0c5qdLUctcj9x8f/wc2eCaE8V ALFGhXqiNmqqXFAuGxPCW85lwG1LECW3pVlfvx4J/C46ZU6+paR9jz2vRnnW7IKUi29KY/dOfuU IeIN1zQptqmqkXBxv2LHGBd/nyqMU3xXctiDQa/fMXMs8ib3j6PA5BQs1GWQjOJRKVJIrf+ouce fsQ1VmEGZwbTYfEZt3rcVC/rBYKoVFEmLgKX6HgErKt/bu8CPTTcSlzVN1HzCXGcphf1tkcpOEf CohM9InN+BBGi74Jef78VPmvnAezcF7Nt9/JqYC3seP5fV1A+lGa2JeU= X-Received: by 2002:a05:7301:608e:b0:2f2:b544:2fca with SMTP id 5a478bee46e88-304490e65femr33140eec.33.1779384429991; Thu, 21 May 2026 10:27:09 -0700 (PDT) X-Received: by 2002:a05:7301:608e:b0:2f2:b544:2fca with SMTP id 5a478bee46e88-304490e65femr33100eec.33.1779384429350; Thu, 21 May 2026 10:27:09 -0700 (PDT) Received: from [192.168.1.106] ([106.51.193.136]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3044359ecaesm941567eec.25.2026.05.21.10.27.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 10:27:08 -0700 (PDT) Message-ID: Date: Thu, 21 May 2026 22:57:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Srivathsa L Rao Subject: Re: [PATCH 1/5] arm_mpam: Parse the rest of the ACPI table To: Andre Przywara , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Ben Horgan , Reinette Chatre , Fenghua Yu Cc: Jonathan Cameron , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ganapatrao Kulkarni References: <20260429141339.3171205-1-andre.przywara@arm.com> <20260429141339.3171205-2-andre.przywara@arm.com> Content-Language: en-US In-Reply-To: <20260429141339.3171205-2-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=K9kS2SWI c=1 sm=1 tr=0 ts=6a0f406e cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=7w7G2qr1pZSYnhmQ0Jjmug==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=7CQSdrXTAAAA:8 a=DsZDJ7UI_9TAX8a9LM0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: 3kwygcm-Msg3gR9zimyn4Hv-ijo97iA1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDE3NSBTYWx0ZWRfXwpdM5or5g6ZL 87+abry+LK2ReO8Ma+TuazKEzFK7zmJ58Ip0/RxAr3nz1Vz7U7DNjGL7/RepYHT9KVloCZKHWxZ da9U06Cu/2wCvOYMHVKAxHnS3qw7I57ui8pWdyxMK+MdTZ0+bG7dDPmcxkoBncyBOx5csgv/cs7 i/zb5MlTO+h7V40iLBqFF94lu2bZjTXAcohpto6r2tqxF37wQ1J7fnYUgesCesyVgJrcmnmXARc Bzt+kjoUowqbB8q0j1kSMeYOYbHPmbDY97UhGJVOzz6JzYE++YwhoNIYPpgYn3ZoYjWeGjSC7+A 6DGF6HQRCC5kaTABV67SxOaON47TNKtFlKwdC7Mgk5cCTvXRbWeK4SHS5i3VYzl+QMVi4loroIW xaLYd+dbxiJo8msbJqU5am6lrufYlpH1Fn9yyBUPwGx8ZW0lKSoN+GBZLpR1hecv6DHhGns4czo JspaRWU6Avqy3EHJXPQ== X-Proofpoint-ORIG-GUID: 3kwygcm-Msg3gR9zimyn4Hv-ijo97iA1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210175 Hi Andre, On 4/29/2026 7:43 PM, Andre Przywara wrote: > From: James Morse > > The MPAM ACPI table lists the MPAM MSCs and indicates which resources > in the system they control. Not everything this table can describe is > supported by resctrl, e.g. memory-side-caches. > > Add the additional table parsing to avoid reporting these as 'unknown' > to the MPAM driver. This allows class+component hierarchys to be built. > > Until resctrl has support for any of these resources, users would be > in-kernel managers of a resource/PARTID or perf to query bandwidth > counters on a resource resctrl is unaware of. > > Signed-off-by: James Morse > Signed-off-by: Andre Przywara > --- > drivers/acpi/arm64/mpam.c | 91 +++++++++++++++++++++++++++++++++++++-- > 1 file changed, 88 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/arm64/mpam.c b/drivers/acpi/arm64/mpam.c > index 84963a20c3e7..99c2bdbb3314 100644 > --- a/drivers/acpi/arm64/mpam.c > +++ b/drivers/acpi/arm64/mpam.c > @@ -95,17 +95,51 @@ static void acpi_mpam_parse_irqs(struct platform_device *pdev, > res[(*res_idx)++] = DEFINE_RES_IRQ_NAMED(irq, "error"); > } > > -static int acpi_mpam_parse_resource(struct mpam_msc *msc, > +#define UUID_MPAM_INTERCONNECT_TABLE "fe2bd645-033b-49e6-9479-2e0b8b21d1cd" > + > +struct acpi_mpam_interconnect_descriptor_table { > + u8 type_uuid[16]; > + u32 num_descriptors; > +}; > + > +struct acpi_mpam_interconnect_descriptor { > + u32 source_id; > + u32 destination_id; > + u8 link_type; > + u8 reserved[3]; > +}; > + > +static int acpi_mpam_parse_resource(struct acpi_mpam_msc_node *tbl_msc, > + struct mpam_msc *msc, > struct acpi_mpam_resource_node *res) > { > + struct acpi_mpam_interconnect_descriptor_table *tbl_int_tbl; > + struct acpi_mpam_interconnect_descriptor *tbl_int; > + guid_t int_tbl_uuid, spec_uuid; > int level, nid; > u32 cache_id; > + off_t offset; > > + /* > + * Class IDs are somewhat arbitrary, but need to be co-ordinated. > + * 0-N are caches, > + * 64, 65: Interconnect, but ideally these would appear between the > + * classes the controls are adjacent to. > + * 128: SMMU, > + * 192-192+level: Memory Side Caches, nothing checks that N is a > + * small number. > + * 255: Memory Controllers > + * > + * ACPI devices would need a class id allocated based on the _HID. > + * > + * Classes that the mpam driver can't currently plumb into resctrl > + * are registered as UNKNOWN. > + */ > switch (res->locator_type) { > case ACPI_MPAM_LOCATION_TYPE_PROCESSOR_CACHE: > cache_id = res->locator.cache_locator.cache_reference; > level = find_acpi_cache_level_from_id(cache_id); > - if (level <= 0) { > + if (level <= 0 || level >= 64) { > pr_err_once("Bad level (%d) for cache with id %u\n", level, cache_id); > return -EINVAL; > } > @@ -120,6 +154,57 @@ static int acpi_mpam_parse_resource(struct mpam_msc *msc, > } > return mpam_ris_create(msc, res->ris_index, MPAM_CLASS_MEMORY, > MPAM_CLASS_ID_DEFAULT, nid); > + case ACPI_MPAM_LOCATION_TYPE_SMMU: > + return mpam_ris_create(msc, res->ris_index, MPAM_CLASS_UNKNOWN, > + 128, res->locator.smmu_locator.smmu_interface); > + case ACPI_MPAM_LOCATION_TYPE_MEMORY_CACHE: > + cache_id = res->locator.mem_cache_locator.reference; > + level = res->locator.mem_cache_locator.level; > + if (192 + level >= 255) { > + pr_err_once("Bad level for memory side cache with reference %u\n", > + cache_id); > + return -EINVAL; > + } > + > + return mpam_ris_create(msc, res->ris_index, MPAM_CLASS_CACHE, > + 192 + level, cache_id); > + > + case ACPI_MPAM_LOCATION_TYPE_INTERCONNECT: > + /* Find the descriptor table, and check it lands in the parent msc */ > + offset = res->locator.interconnect_ifc_locator.inter_connect_desc_tbl_off; > + if (offset >= tbl_msc->length) { > + pr_err_once("Bad offset for interconnect descriptor on msc %u\n", > + tbl_msc->identifier); > + return -EINVAL; > + } > + tbl_int_tbl = ACPI_ADD_PTR(struct acpi_mpam_interconnect_descriptor_table, > + tbl_msc, offset); > + guid_parse(UUID_MPAM_INTERCONNECT_TABLE, &spec_uuid); > + import_guid(&int_tbl_uuid, tbl_int_tbl->type_uuid); > + if (guid_equal(&spec_uuid, &int_tbl_uuid)) { > + pr_err_once("Bad UUID for interconnect descriptor on msc %u\n", > + tbl_msc->identifier); > + return -EINVAL; > + > > Looks like the condition seems to be inverted. This currently returns -EINVAL when the UUID matches the expected spec UUID, and accepts mismatched UUIDs.It probably should be: > if (!guid_equal(&spec_uuid, &int_tbl_uuid)) { > > > + offset += sizeof(*tbl_int_tbl); > + offset += tbl_int_tbl->num_descriptors * sizeof(*tbl_int); > + if (offset >= tbl_msc->length) { > + pr_err_once("Bad num_descriptors for interconnect descriptor on msc %u\n", > + tbl_msc->identifier); > + return -EINVAL; > + } > + > + tbl_int = ACPI_ADD_PTR(struct acpi_mpam_interconnect_descriptor, > + tbl_int_tbl, sizeof(*tbl_int_tbl)); > + cache_id = tbl_int->source_id; > + > + /* Unknown link type? */ > + if (tbl_int->link_type != 0 && tbl_int->link_type == 1) > + return 0; > > And here I think != 0 && == 1 simplifies to just == 1, so this drops the valid PROC link type (0x01) while letting any unknown value (≥ 2) fall through to mpam_ris_create with an arbitrary class ID. Per DEN0065B, only 0x00 (NUMA) and 0x01 (PROC) are defined. So it probably should be: > > if (tbl_int->link_type != 0 && tbl_int->link_type != 1) > return 0; > > + > + return mpam_ris_create(msc, res->ris_index, MPAM_CLASS_UNKNOWN, > + 64 + tbl_int->link_type, cache_id); > default: > /* These get discovered later and are treated as unknown */ > return 0; > @@ -150,7 +235,7 @@ int acpi_mpam_parse_resources(struct mpam_msc *msc, > return -EINVAL; > } > > - err = acpi_mpam_parse_resource(msc, resource); > + err = acpi_mpam_parse_resource(tbl_msc, msc, resource); > if (err) > return err; > > Best Regards, > Srivathsa