From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72BFCC352BE for ; Fri, 17 Apr 2020 08:40:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47FF32137B for ; Fri, 17 Apr 2020 08:40:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JpYAGBWM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729880AbgDQIkH (ORCPT ); Fri, 17 Apr 2020 04:40:07 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:40204 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729796AbgDQIkH (ORCPT ); Fri, 17 Apr 2020 04:40:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587112805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0FUsH4tufAJaMC98c0oFTGbfyRpyKw0gpf2wi60SU+8=; b=JpYAGBWMOBKA7ScThz0V9X4NcKKxgpodgzzWm62AJcrTFFt8PJ7QzKKVoX7yDxmjWK4LnX Ya5IoHvtfKpNZd4YpVIZcXwqgzwmoXR2QUCKGlrXme8+4B97Owkx7ZpYvx7qb+6W+/3HJF /bJ3BHXIP1LQuy5FmGAkO0pbO9MT8CA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-wDRv0H_YMDq_MOxphoyW1g-1; Fri, 17 Apr 2020 04:40:01 -0400 X-MC-Unique: wDRv0H_YMDq_MOxphoyW1g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B23A107ACC4; Fri, 17 Apr 2020 08:39:59 +0000 (UTC) Received: from [10.72.13.202] (ovpn-13-202.pek2.redhat.com [10.72.13.202]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54BCA8D57F; Fri, 17 Apr 2020 08:39:50 +0000 (UTC) Subject: Re: [PATCH V2] vhost: do not enable VHOST_MENU by default To: "Michael S. Tsirkin" Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, geert@linux-m68k.org, tsbogend@alpha.franken.de, benh@kernel.crashing.org, paulus@samba.org, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, Michael Ellerman References: <20200415024356.23751-1-jasowang@redhat.com> <20200416185426-mutt-send-email-mst@kernel.org> <20200417022929-mutt-send-email-mst@kernel.org> <4274625d-6feb-81b6-5b0a-695229e7c33d@redhat.com> <20200417042912-mutt-send-email-mst@kernel.org> From: Jason Wang Message-ID: Date: Fri, 17 Apr 2020 16:39:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200417042912-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/17 =E4=B8=8B=E5=8D=884:29, Michael S. Tsirkin wrote: > On Fri, Apr 17, 2020 at 03:36:52PM +0800, Jason Wang wrote: >> On 2020/4/17 =E4=B8=8B=E5=8D=882:33, Michael S. Tsirkin wrote: >>> On Fri, Apr 17, 2020 at 11:12:14AM +0800, Jason Wang wrote: >>>> On 2020/4/17 =E4=B8=8A=E5=8D=886:55, Michael S. Tsirkin wrote: >>>>> On Wed, Apr 15, 2020 at 10:43:56AM +0800, Jason Wang wrote: >>>>>> We try to keep the defconfig untouched after decoupling CONFIG_VHO= ST >>>>>> out of CONFIG_VIRTUALIZATION in commit 20c384f1ea1a >>>>>> ("vhost: refine vhost and vringh kconfig") by enabling VHOST_MENU = by >>>>>> default. Then the defconfigs can keep enabling CONFIG_VHOST_NET >>>>>> without the caring of CONFIG_VHOST. >>>>>> >>>>>> But this will leave a "CONFIG_VHOST_MENU=3Dy" in all defconfigs an= d even >>>>>> for the ones that doesn't want vhost. So it actually shifts the >>>>>> burdens to the maintainers of all other to add "CONFIG_VHOST_MENU = is >>>>>> not set". So this patch tries to enable CONFIG_VHOST explicitly in >>>>>> defconfigs that enables CONFIG_VHOST_NET and CONFIG_VHOST_VSOCK. >>>>>> >>>>>> Acked-by: Christian Borntraeger (s390) >>>>>> Acked-by: Michael Ellerman (powerpc) >>>>>> Cc: Thomas Bogendoerfer >>>>>> Cc: Benjamin Herrenschmidt >>>>>> Cc: Paul Mackerras >>>>>> Cc: Michael Ellerman >>>>>> Cc: Heiko Carstens >>>>>> Cc: Vasily Gorbik >>>>>> Cc: Christian Borntraeger >>>>>> Reported-by: Geert Uytterhoeven >>>>>> Signed-off-by: Jason Wang >>>>> I rebased this on top of OABI fix since that >>>>> seems more orgent to fix. >>>>> Pushed to my vhost branch pls take a look and >>>>> if possible test. >>>>> Thanks! >>>> I test this patch by generating the defconfigs that wants vhost_net = or >>>> vhost_vsock. All looks fine. >>>> >>>> But having CONFIG_VHOST_DPN=3Dy may end up with the similar situatio= n that >>>> this patch want to address. >>>> Maybe we can let CONFIG_VHOST depends on !ARM || AEABI then add anot= her >>>> menuconfig for VHOST_RING and do something similar? >>>> >>>> Thanks >>> Sorry I don't understand. After this patch CONFIG_VHOST_DPN is just >>> an internal variable for the OABI fix. I kept it separate >>> so it's easy to revert for 5.8. Yes we could squash it into >>> VHOST directly but I don't see how that changes logic at all. >> >> Sorry for being unclear. >> >> I meant since it was enabled by default, "CONFIG_VHOST_DPN=3Dy" will b= e left >> in the defconfigs. > But who cares? FYI, please see https://www.spinics.net/lists/kvm/msg212685.html > That does not add any code, does it? It doesn't. Thanks > >> This requires the arch maintainers to add >> "CONFIG_VHOST_VDPN is not set". (Geert complains about this) >> >> Thanks >> >>