From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B376C83006 for ; Wed, 29 Apr 2020 12:56:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47276208FE for ; Wed, 29 Apr 2020 12:56:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="LtGQzHfQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726861AbgD2M4O (ORCPT ); Wed, 29 Apr 2020 08:56:14 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:57066 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726637AbgD2M4O (ORCPT ); Wed, 29 Apr 2020 08:56:14 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 03TCuAAm080212; Wed, 29 Apr 2020 07:56:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1588164970; bh=AR3qTisxwY2ajPBIFrmPomkWxiBKguIAfuOxuTrvtfs=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=LtGQzHfQd9wumaUk1FMScn+QXAJJCDISkOWcnbvftt8e0P2XA7mytc9K2hAG1us/v Ab+MVQ6RDyCR4O5Pbczw7OEgbaQQ3hCTEHNuoMssKqWm3XaIQkx0QuRCnPfoLcSga/ Hur2wh9yOvIsw46axvmU3hPxF6r3Ri38uJvhtKu0= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 03TCuAGC037068 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Apr 2020 07:56:10 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 29 Apr 2020 07:56:10 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 29 Apr 2020 07:56:10 -0500 Received: from [10.250.52.63] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 03TCuAKt078130; Wed, 29 Apr 2020 07:56:10 -0500 Subject: Re: [PATCH v21 04/16] leds: lp50xx: Add the LP50XX family of the RGB LED driver To: Jacek Anaszewski , CC: , References: <20200428160338.2793-1-dmurphy@ti.com> <20200428160338.2793-5-dmurphy@ti.com> From: Dan Murphy Message-ID: Date: Wed, 29 Apr 2020 07:50:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jacek On 4/28/20 3:25 PM, Jacek Anaszewski wrote: > Hi Dan, > > Thanks for the update. There is one remnant from the > previous stages that you already scheduled for removal AFAIR. > > On 4/28/20 6:03 PM, Dan Murphy wrote: >> Introduce the LP5036/30/24/18/12/9 RGB LED driver. >> The difference in these parts are the number of >> LED outputs where the: >> >> LP5036 can control 36 LEDs >> LP5030 can control 30 LEDs >> LP5024 can control 24 LEDs >> LP5018 can control 18 LEDs >> LP5012 can control 12 LEDs >> LP5009 can control 9 LEDs >> >> The device has the ability to group LED output into control banks >> so that multiple LED banks can be controlled with the same mixing and >> brightness.  Inversely the LEDs can also be controlled independently. >> >> Signed-off-by: Dan Murphy >> --- > [...] >> + >> +        init_data.fwnode = child; >> +        init_data.devicename = priv->client->name; > > Namely this line. We don't need devicename for new drivers like this. > Removed Dan