From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751957AbdANKsd (ORCPT ); Sat, 14 Jan 2017 05:48:33 -0500 Received: from mail-dm3nam03on0087.outbound.protection.outlook.com ([104.47.41.87]:6224 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751733AbdANKsa (ORCPT ); Sat, 14 Jan 2017 05:48:30 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v7 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug To: Borislav Petkov References: <1484019227-11473-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1484019227-11473-5-git-send-email-Suravee.Suthikulpanit@amd.com> <20170112101942.5z6e6s344awbi4uk@pd.tnic> CC: , , , , From: Suravee Suthikulpanit Message-ID: Date: Sat, 14 Jan 2017 17:13:33 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170112101942.5z6e6s344awbi4uk@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [114.109.128.54] X-ClientProxiedBy: SG2PR0302CA0023.apcprd03.prod.outlook.com (10.170.129.33) To MWHPR12MB1455.namprd12.prod.outlook.com (10.172.55.136) X-MS-Office365-Filtering-Correlation-Id: 2d8323de-8517-450c-5f62-08d43c660c11 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR12MB1455; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1455;3:DrHwfky0H7WDeVV0hvZOV7GYnZFw/cFbN3iL9avdeCdfIEHFcHqY6q/k6qCh9J7h8w777yoyqdOENxGllLavtJsFGynJ7aYmZ3EJaP4/f79fP017Tp5KWxT0A52gBzlRi2j3HO1GNIjcGnr1V5vlh/kWcDjiHU2eHR93hmrua7jz1BACXZqUD+qJx83BsanMeJnA/rk1TIzFWOpFpgqPFik8Mz9liVUPzruo+CRk5W4TFzNO5hnHgMhPb8Do9IUJwTW1YSBPXfy6YoemziKaWA== X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1455;25:5/hPUPb1B/8PjFtH7QZ7Uv4zyhU+G149ZW7S7hrk7qWMA5QJDdZ1nNL/Tjv3s9HmgRzwCdcsIquF87Th3OU9r/SpWBQnSX0zMsh9s5+Oukj7Kz986cc3UgjFZarj+77o3iyfkIyY/SUcbpdCG34dguoIfotxY2Vbd+FqH0BGqPm6k3NNRj0ZSTlJ2ZDS78vGIhSVnNIs3ltRc+Bl0AsddfGM0tJIXjS6SskBM3sfEEUQ3Tm6mQ78oO8KxBzpqGj7yhfP8HPs8JDjwc6eK//TXzjgmVTd3DtvG4q8wVYKYa2SHBGUVravLawdUJlBBAIjY68AGlS6CifGSZas40JlvtoWvOXoVFf6PQNoygoFjYWOl0KXAOSI+G06w6oDwMbzsSY/gEuCQoEouxrRYVL2UooZgQxdnz+iF3U9DA1NWOalQC6VgQjoGoPZU2sOGL1OlMSm/W6ZmZU26HNMxNG+jWcw2Vb1ozi3RwCoE+wHG8HwmQ/FMDg4mDs4BHbXZ3+JAlM/7Z+fWNVNPrXHdnshyQZzt8VTsUIDwMXNbZU0LbNnDm3VlGwu8877QwVOKYBLuuSIMg951VoNgGqorSDrmpxXJVmivLw/ox0c5cmgT1mv+5p62zEZSTi3NzcSjJei74Y6XRlmAB/kKZqbXRc3B3HiQNzw2yjJsh72VqppLLEwgxB4DfC1bsqsQ7Zj8n16IwRPVRnCet1BSdpwGlvXfc+d9q3E6nSrFmsZMFgQrXmQZTf+1Jb8deIsyHCgKHpwTYE2dsbA6Y5zKeBd3cQn1w== X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1455;31:7i2vuD6qGTivXMturffaWob9bjzaZwX/3JhubL5I1OPSUUJMPuU2Gq5iV2U8LzKT+FTKEY+hbF3BKrxN2fMZY6KODVFqvMkJWRSVFdgU2S8I9joYn/XOSCkwsyRkMDa9Y7hC4PWT8nEjZ9Gy3cKLXBdQEIXyJxBz6mQ4MXcy0AJRsy94nrsnjggTT0ADpwSmAj6zrjpl4QtEyQIbuAuJJkc2KL4dz/fFMo3LUwLlnkRqZFS6p3RgGE/XQkhVRBL3iuhia7V1nw/DPr/8SVL3veAZZkgGPHW5bDusTRkkvjA=;20:UnX/+6vXIYVrxx3a81gJvEwaIUaGGAv+tzWBHXakvpRJi2TmCvDdt4NlFdmGrmLmVrBdY32pa1VGPWmXKCY9Y9DG9zpvow5dukabzkBsVJS7jxGovEp8d19RP/aLNbwfs10tClwA2MpRflThuYEpIPiFSGc+0klCUu3h/nCwl1dGteyrJR2s79/+2uKhppzT+ojAmUPvBRAOA9X8IxNrkfnGC1QYLzreK9c/bDGx9abwHo6qEImq9kHoMBs6rZpDqGeSVqtrYHEtfapdxd+rkvU4wt4Je6+iWK+80kW/7b7j8bz9GiIIXaCZFqui5RgD0D5ubbAe5JDEICkAwRHcI8wq11dhSouuvswbORwiCgwe2xpgZJ6eaWRSy6cYVW99NCwmP/f2ddS1IeCuIjC1pnyvi20btMdIt1xjNmxoLFMkG6xJBFyJ0D6AYXK8DN6GYt6qNnGEmqSjGA9JNJzAvK/ECmM2fyhm4F05mn8mh6l0m3OxTDeQPw+Qd5PlKMoY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148);SRVR:MWHPR12MB1455;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1455; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1455;4:WbGgHNisn2MykY4gVTdpXUpH9NBg+YIyUnkRgBts3QmVq+PKEa8e3dyw3B63GrgBjB+3UamIQ4JZXzGQiUK5wEAwcmSpnAbbiltFRU8ahb/jiEIsyfk6Px4x/G0+ajy9kWdtPku/264q0J7uBg44/X//0o1e3tjhG6h9ONvPb5x3G9jCRLqNZhP+a0py0v1Q7J7ZwWEtVDguRaKAkQMc0+JSarPvS673l9GSgTPR3uwMBsbnNevy1h+ezDUbcP5/RgzjXkrwyzSPkK3G2WCy6TlPL+TCdcDRVGqz4YULMz4HYGA6F/n5ZjhDIrQVUCP0cuX9/eefQwsCTXnRUDzaKy+XUIVCJLelRULj3V+0hLDrSLQQgeo6fFfr5J5HPdFYb5+O7urveoYTlw8paCMzT7APvSqb6so8ABCqNXXWNOWVby9LVd2Ze6xdUINmsWkytBZcAfOu7qYr6yfdSQEyXnSheRxCoXzW4hsVgnYsBdbuAiAZzUKO92JKZ4WG9Ykci6j3Ekubxc4J1OC6rx7B9W+oa3uH7SL72zwv0gwy2DCv+pZlP5Y/aGoNqQl8gLShMg/t9iIQqnvHWc+kASFlPQ== X-Forefront-PRVS: 0187F3EA14 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39860400002)(39850400002)(39410400002)(39840400002)(39450400003)(199003)(189002)(24454002)(2906002)(6916009)(6116002)(2950100002)(110136003)(64126003)(3846002)(65826007)(86362001)(31696002)(4326007)(5660300001)(83506001)(4001350100001)(65806001)(6666003)(66066001)(47776003)(50466002)(33646002)(92566002)(97736004)(65956001)(81166006)(305945005)(6512007)(189998001)(31686004)(36756003)(105586002)(23676002)(7736002)(42186005)(8676002)(106356001)(54906002)(229853002)(68736007)(54356999)(6486002)(50986999)(38730400001)(101416001)(6506006)(27001)(81156014)(230700001)(25786008)(76176999);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1455;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxNDU1OzIzOkFLTG5QUW1neTJzK0tHWVlla0dlWS9lZmRK?= =?utf-8?B?bDlNNWtvVzhLS2o2Yno1bzhacGMrRC9JekEzdHJUQ09JeXJHVjlsRlFJRGRy?= =?utf-8?B?Z3U0YmEyeHZneWU5bGM0b3dYMHFPVkJheUYrWXIrUXpKSFdQa1lrMjdNUUpP?= =?utf-8?B?Zzh5ZndhZzZEOW00OEh6OEZXV0tjMXhGcHY2MUNXRWJxYTAxVldiM01SWVJy?= =?utf-8?B?Y0YrSDhBY282RG9Dem8wQWdDQU9IWklLUi9Qd2w3Y1U0bzVzT1RpZENFUWMr?= =?utf-8?B?ODVCZXp4L2hpOWpzeXUzSVZUYVhzeDBoS3RtYkFOeVhBb1o4ZDRxWCt6d09Y?= =?utf-8?B?NlMzZE5tanFiYXpGTkVJZkF5Y0FrQzRwc0JxWGpMd3pUUVJYaC9jN1lDbWlU?= =?utf-8?B?NFhLU01Yc1F1RjlaKzVvb1gvZFdrUlpCN3ZvTk9oeUNmdHhtSXJZODFlbitt?= =?utf-8?B?OExEekI4L2hoY0dqTFVvQ1djRWlpMGttbG9HUWtYZ1U2VHR2eVo1NDdGWnZt?= =?utf-8?B?ZWdLYkRqK1AzQllXWnpXV3U4eVRZL09qeGduUkxsQjZ1T05MNm4rekdsemEz?= =?utf-8?B?MEFxckpraEtKNldxRUZ2cG9QMnh2aXRRRHZVckkvdXpNM01lSGdveE1jMis2?= =?utf-8?B?VWFpaU1MY3Jra2FtK0JSWFRNMDJWSkkxS0FyellGQ2lGZGFWYkN5SGpMT2F3?= =?utf-8?B?NVo2cDRFeUc2THZPOGJ5YTZEZ056Z2tPSlFiWHpzWUR4aVpTckErRnRGRWRK?= =?utf-8?B?MDg2NnRETjZLb2pmV3pQUENpeWJIWGVsMld1ZXFUL1VpQmVWZ0NaT2s5QVJa?= =?utf-8?B?UWNNcnVVVVlkdkYrRjZXRFZSZHRTMDk4SVROZ2UzMG50TGljU2VKbWk1c1FS?= =?utf-8?B?Ymp0VGUrY3VjTjVPa2UwRE5MNlo5NWprcyt4QXlIcXFqM2ZucHpwbVFER3BW?= =?utf-8?B?U1dXVDd0OUhrSHZoY0Jiam0wNWcwaFBlaU5INldNQjcrOFcrMEVtTmtmYU9Z?= =?utf-8?B?bnpuTXh6RDh5a2tuSzVJL1c0MnhaYzFTQXMrUCtFRzRMdWN6UDAzSzZFc1hl?= =?utf-8?B?YTZYSGpLWGxqejZ5blpHcVVtL2NzaCsxYzhJY1M4Y3ZqT3RJVHRlN05YRVBX?= =?utf-8?B?cjYzLyttOFNRWDFyYjZtV2pFako3YWUwdEMrV0VtWVpWbDN3MEZ6M241UlpH?= =?utf-8?B?MXo4RXlEQWVWeWJMNHZLcHJJK0pYaTlPaVU5S0hEd0xkbDFGWEdQZXJRRnJI?= =?utf-8?B?cW5WOXFrVWVMYTd2ZGRkc2kzaXA5SmZYdXllOHRVemNuOHA0cjFPYmZXVmRY?= =?utf-8?B?OWNOVHlVbXFSUlg1SU1wSUxOYW90Y0pORHRiY3czSkd3aUZIeDU4a0FTZkt6?= =?utf-8?B?SEpOMUpCUkYrVzVqTldJdHY0cWxJOWFmL1ZRR1N3R2d1c3o5MS81S2g5b1ly?= =?utf-8?B?K0VoY3hBSFE4a3lvenBKLzQrOTF3b2EzU2prdGt0MjFqOXRLa3p6eTh4TkN6?= =?utf-8?B?dTNEbmtoU0RWdXNXRDNqQ0F4M29qNmkrUnY3QWtjcFJod085NVE2bTZUdVpR?= =?utf-8?B?ekF3YStBWitTNG9CUExrbG5QdlgyQ0JvLzU0bldxZWNURXBFSDhjZ05jdW00?= =?utf-8?B?NGYrWlhYQTgzekpjMTg3QWFWWUZLdXJRbUl2ZjRkZWpCQ1p6OW5sdnRyb1Za?= =?utf-8?B?UFpIazJJY0dqQzVUNElRaU9pNXBxejlpWWJYeWN5a00vRUN2YVJYQ2t0OVdF?= =?utf-8?B?QTBxakFFOVNDUnNhYnl3YndGbWRJV1NxeGFrbWYyZmdURzFhQzl5Ulh5c2E4?= =?utf-8?B?THdVcTQrOFZndEtwNFkzYlduYnZWZm9QYmY3U0UxakMzRzRZSGs1OE94MjdY?= =?utf-8?B?WnFBS1Z3cC9ZZkhBQkJCNDNxUEo3RkxZTCtTZm11elM3RmVSMzBJS1RrSys0?= =?utf-8?Q?Syvln0cWnvK5cl85jK6eUPCqIdnCkM=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1455;6:+wlMaPDmAoog6xl92nXuH8GvNzaO9FaSypKxBtV9yohudADO0BRw3A4e/XZ/Pfe0eilYLfs0bQNvn5OGUwWjCY4cINdfTBzfXf1dTcuxzLI5DJ8xblui9SiPSkT3Gc8lDOWCh0vyuHbJd3c+YsBZVdGAbbpd55MAmk3cRkiRk+1d9qOLJOmVZOW0pK48ayJxj0gdf5LvJ1UadxkJCcu7hrA3iAVVokDqUCSi4qpcPEyKVuNNTcZXoVQlRtaGjaLrnvCDSBE93wf/y5LoaMY/dkWkrdV6KunhTsk0LYQ6jcfFNTtdzVm7tVgaqB66o9Wu4Jb77QHmdRi4y8YON9Sqk0HnPAr3mwf4j6msRbGlz4cl4BeROu3/vzEqUEvbV2DmQ9xy9n49jq8ocC6KTlsNHkdeZx4h1M5GD37fUOKpAEH8A8ODRGPVrvYY/IPQVIwpg8g8roubNl+8j6nD4/34Dg==;5:6YO7TSyK7ZpaCsHxA+u0SJRX9k6PySHzRrIJPcjXBLk+5J73pj1nUSSDfwuUhDpjWzzUndT+uGZlyCRM+oxRQmJLjt4kOsaHMPY8FvRxHcsRQQ+YQiq+8KjT/1C/Pmh676IAOOSQ190GtAwQZpqIqA==;24:yS/U1gHhDmkemnHuR4juLkHgGhFGIoOwQtcmyvwcet6sWTfnGkf6t7htkFIp5zMbNsZPnCXAFQHJL+h3dpYQTGO8iII/y/51YkAH4zNoLWw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1455;7:0Aheozp0ErFj1ddaAr5MD854SkqZHlQxWBP4crEOdw9zuujPoAbDuJawcSvsvRxYOalg0BR8zO0e9muJ7yJh0LPP+GDdjHiTbgUHRW7M45srxWUYfC7MfxXrd8D2C4bLRm4+Aa+QB6Oe4ow0PNWZXZG2wfvN4mYI38zrxumVsC+0lnpzKMyfAMhUfZwy8zQw2FcCOcpSfZcsg6mEkJC+KoT7rDfCtu6Xzw2+x1lneiOYN3sqmEFghSkmDRmjIVxB8V7GB8+lN3evP+wmQOddx3f5djw/SnBlsegDc7HWnn5x8xqndXMyO5TjDBvXH1Fs4xjq789vE0b9J+8RJ9jzyAofN9PrSZTBAw91jmzq1LL/t9iK/TuGxFI/ZEYCHHAml8wjSHnQJ/EtJo8nJnb/6SBtkQ2W1FWn3p1LCxunBPYyF5jwevVkYD8/AWTn69BWx2KqS4NRHwMAlAvSWX4bPg==;20:789KkGSZjWWp7dv+OwKWhHI5vKAM6fJXzQxS39NGtIDe+pkDmlAwIi/VVC57oHPBkQBxITBZBRxF3jWKzrvFW5bS26iMvQpeKclzYtkFxzhQdDkP96EbqKBq6hTiG/Wj1SjbIqSDg9A6z+BcdxZW7ozhlhJ2zNJCBbiQItWFiSl9mSk0Sybn/CWrmIA6c9HArqJrV0p631J0fnrV0AArYHwDjfdvratKY3GWzwDK9Dc28lBYDRicDOh3n225/IVW X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2017 10:13:53.4632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1455 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/12/17 17:19, Borislav Petkov wrote: > Also, looking at that driver more, this needs to die, like now: > > #define format_group attr_groups[0] > #define cpumask_group attr_groups[1] > #define events_group attr_groups[2] > #define null_group attr_groups[3] > > Like, kill it dead. Define a separate array, look what the other drivers > do, whatever, but this is too ugly to live. > > Thanks. > > -- Okay... you got it :) S