From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Markus Elfring <Markus.Elfring@web.de>, <linux-nvdimm@lists.01.org>
Cc: <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Oliver O'Halloran" <oohall@gmail.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH 1/3] libnvdimm: Fix memory leaks in of_pmem.c
Date: Wed, 19 Aug 2020 09:07:59 +0800 [thread overview]
Message-ID: <fdbd9d2d-2e5d-8190-5d7c-eec5c4cdadbb@huawei.com> (raw)
In-Reply-To: <5ca9f6e3-38d7-fc65-5010-22c992ecf851@web.de>
On 8/19/2020 3:00 AM, Markus Elfring wrote:
>> The memory priv->bus_desc.provider_name allocated by kstrdup() should be
>> freed.
>
> * Would an imperative wording be preferred for the change description?
>
> * I propose to add the tag “Fixes” to the commit message.
Thanks for your suggestion, I will add it in v2.
Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")
>
> Regards,
> Markus
>
>
parent reply other threads:[~2020-08-19 1:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <5ca9f6e3-38d7-fc65-5010-22c992ecf851@web.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdbd9d2d-2e5d-8190-5d7c-eec5c4cdadbb@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=oohall@gmail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome