From: "Paul E. McKenney" <paulmck@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: bartosz.golaszewski@linaro.org, linux-kernel@vger.kernel.org,
sfr@canb.auug.org.au, bigeasy@linutronix.de
Subject: Re: [PATCH -next] reset: Remove unused variables
Date: Thu, 13 Nov 2025 06:49:38 -0800 [thread overview]
Message-ID: <fdc04e4a-3930-41ca-9147-ce5bbf2d41ac@paulmck-laptop> (raw)
In-Reply-To: <def3319117b2d2d71d0585e69d648b1a0f217bc4.camel@pengutronix.de>
On Thu, Nov 13, 2025 at 10:51:50AM +0100, Philipp Zabel wrote:
> On Mi, 2025-11-12 at 12:59 -0800, Paul E. McKenney wrote:
> > Neither reset_lookup_mutex nor reset_lookup_list are used anymore, which
> > results in build errors, so remove them. It would be best if this were
> > to be folded into commit 205b261463ff ("reset: remove legacy reset lookup
> > code"), the better for bisection efforts.
> >
> > Reproduce on armv8 with:
> >
> > tools/testing/selftests/rcutorture/bin/torture.sh --duration 10 --do-none --do-rt
> >
> > Fixes: 205b261463ff ("reset: remove legacy reset lookup code") # -next
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> >
> > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > index 22f67fc77ae5..93575d5064a5 100644
> > --- a/drivers/reset/core.c
> > +++ b/drivers/reset/core.c
> > @@ -25,9 +25,6 @@
> > static DEFINE_MUTEX(reset_list_mutex);
> > static LIST_HEAD(reset_controller_list);
> >
> > -static DEFINE_MUTEX(reset_lookup_mutex);
> > -static LIST_HEAD(reset_lookup_list);
> > -
> > /* Protects reset_gpio_lookup_list */
> > static DEFINE_MUTEX(reset_gpio_lookup_mutex);
> > static LIST_HEAD(reset_gpio_lookup_list);
>
> Thank you, just applied to reset/next for now:
>
> [1/1] reset: Remove unused variables
> https://git.pengutronix.de/cgit/pza/linux/commit/?id=3754bc97926e
>
> I'll rebase this branch and squash this fix into 205b261463ff before
> sending a pull request. There's also the 25d4d4604d01 / f5c877fb74f4
> patch / revert pair that I should drop.
Thank you both!
Thanx, Paul
prev parent reply other threads:[~2025-11-13 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 20:59 Paul E. McKenney
2025-11-13 8:35 ` Bartosz Golaszewski
2025-11-13 9:51 ` Philipp Zabel
2025-11-13 14:49 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdc04e4a-3930-41ca-9147-ce5bbf2d41ac@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®