mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ming Lei <tom.leiming@gmail.com>, Hannes Reinecke <hare@suse.de>,
	Omar Sandoval <osandov@fb.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] loop: fix error handling regression
Date: Fri, 9 Jun 2017 08:19:19 -0600	[thread overview]
Message-ID: <fdc139d7-7f7c-2268-ac89-29292b779138@fb.com> (raw)
In-Reply-To: <20170609101938.2807152-1-arnd@arndb.de>

On 06/09/2017 04:19 AM, Arnd Bergmann wrote:
> gcc points out an unusual indentation:
> 
> drivers/block/loop.c: In function 'loop_set_status':
> drivers/block/loop.c:1149:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
>    if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
>    ^~
> drivers/block/loop.c:1152:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
>     goto exit;
> 
> This was introduced by a new feature that accidentally moved the opening
> braces from one condition to another. Adding a second pair of braces
> makes it work correctly again and also more readable.

Thanks for fixing this Arnd, I did notice (and complained to Hannes) this
yesterday. Added.

-- 
Jens Axboe

  reply	other threads:[~2017-06-09 14:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 10:19 Arnd Bergmann
2017-06-09 14:19 ` Jens Axboe [this message]
2017-06-10  8:04 ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdc139d7-7f7c-2268-ac89-29292b779138@fb.com \
    --to=axboe@fb.com \
    --cc=arnd@arndb.de \
    --cc=hare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®