mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Meghana Madhyastha <meghana.madhyastha@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Sean Paul <seanpaul@chromium.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v18 08/10] drm/omapdrm: Use backlight_enable/disable helpers
Date: Tue, 23 Jan 2018 15:20:11 +0100	[thread overview]
Message-ID: <fdc96264-b927-38d4-908b-3e7328add06e@tronnes.org> (raw)
In-Reply-To: <30d5b26c3c7d75de3d2ab3cff9dee67084fc3caf.1516632388.git.meghana.madhyastha@gmail.com>


Den 22.01.2018 15.54, skrev Meghana Madhyastha:
> Use backlight_enable/disable helpers instead of changing
> the property and calling backlight_update_status for cleaner
> and simpler code and also to avoid repetitions.
>
> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> ---

Reviewed-by: Noralf Trønnes<noralf@tronnes.org>


>   drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 11 ++---------
>   1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> index e065f7e10..ac9596251 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> @@ -87,11 +87,7 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev)
>   	}
>   
>   	gpiod_set_value_cansleep(ddata->enable_gpio, 1);
> -
> -	if (ddata->backlight) {
> -		ddata->backlight->props.power = FB_BLANK_UNBLANK;
> -		backlight_update_status(ddata->backlight);
> -	}
> +	backlight_enable(ddata->backlight);
>   
>   	dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;
>   
> @@ -106,10 +102,7 @@ static void panel_dpi_disable(struct omap_dss_device *dssdev)
>   	if (!omapdss_device_is_enabled(dssdev))
>   		return;
>   
> -	if (ddata->backlight) {
> -		ddata->backlight->props.power = FB_BLANK_POWERDOWN;
> -		backlight_update_status(ddata->backlight);
> -	}
> +	backlight_disable(ddata->backlight);
>   
>   	gpiod_set_value_cansleep(ddata->enable_gpio, 0);
>   	regulator_disable(ddata->vcc_supply);

  reply	other threads:[~2018-01-23 14:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 14:48 [PATCH v18 00/10] Add backlight helper functions Meghana Madhyastha
2018-01-22 14:49 ` [PATCH v18 01/10] video: backlight: Add helpers to enable and disable backlight Meghana Madhyastha
2018-01-23 10:00   ` Daniel Thompson
2018-01-23 14:47     ` Noralf Trønnes
2018-01-22 14:50 ` [PATCH v18 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable Meghana Madhyastha
2018-01-22 14:51 ` [PATCH v18 03/10] video: backlight: Add of_find_backlight helper in backlight.c Meghana Madhyastha
2018-01-28 17:15   ` Andy Shevchenko
2018-01-22 14:51 ` [PATCH v18 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight Meghana Madhyastha
2018-01-22 14:52 ` [PATCH v18 05/10] video: backlight: Add devres versions of of_find_backlight Meghana Madhyastha
2018-01-22 14:53 ` [PATCH v18 06/10] drm/tinydrm: Call devres version " Meghana Madhyastha
2018-01-22 14:54 ` [PATCH v18 07/10] drm/panel: Use backlight_enable/disable helpers Meghana Madhyastha
2018-01-23 14:19   ` Noralf Trønnes
2018-01-22 14:54 ` [PATCH v18 08/10] drm/omapdrm: " Meghana Madhyastha
2018-01-23 14:20   ` Noralf Trønnes [this message]
2018-01-22 14:55 ` [PATCH v18 09/10] drm/panel: Use of_find_backlight helper Meghana Madhyastha
2018-01-23 14:24   ` Noralf Trønnes
2018-01-22 14:56 ` [PATCH v18 10/10] drm/omapdrm: " Meghana Madhyastha
2018-01-23 14:37   ` Noralf Trønnes
2018-01-23 16:55     ` Meghana Madhyastha
2018-01-23 17:41       ` Noralf Trønnes
2018-01-23 17:43         ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdc96264-b927-38d4-908b-3e7328add06e@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=daniel.thompson@linaro.org \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=meghana.madhyastha@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®