From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45AF3C25B47 for ; Wed, 25 Oct 2023 10:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343739AbjJYKk3 (ORCPT ); Wed, 25 Oct 2023 06:40:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234735AbjJYKkO (ORCPT ); Wed, 25 Oct 2023 06:40:14 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6E1B10DD for ; Wed, 25 Oct 2023 03:40:08 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-507a98517f3so7667670e87.0 for ; Wed, 25 Oct 2023 03:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698230407; x=1698835207; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c6Z1p4kKtgAXkbhWcm2d+hA00mC2LWkNVOmS2pvrIIs=; b=OiE+5DpllivC1t3kS6P/G9QplJqPWhgDbwtjnMg5RtU0YL++rttT2d25WEuba0H2dz qSqphjuNoWC3dwpY73z5iXARaaXbO9+twD2+Hl7nyfunjxrBF5T2v8Z3lu39MNJH38FK XhFUwZFdl+F4zw/12QLc7cHXjzYFk+QmJI2A32rBcF0HrQxz8L1cF/cxD7ZcKGKPyaP/ 7NC5xcwje0Q82YgxURxn7NUBT7DkrEndRLtZiPjkVLhSllbpM1NRMG25q7DSM1zP2dap 6D+j9wYfx+AzMExiX29m4UgmxM+1Rwg6EkPmQzc6tbnpaYfvye7yxiGwXjh/daE72kgr b2Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698230407; x=1698835207; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c6Z1p4kKtgAXkbhWcm2d+hA00mC2LWkNVOmS2pvrIIs=; b=cO/RdKLyyf2X2jkdpkByIotmjydk4ebI/K8dtTE29iFX3WTzcc9AOsFVH4gkBhz6u5 I5VZ2aVxwWmBfBCXryEWS2z7WKCcEsgjMMRauFu0Q7NWfDdlqqKmgJtd0OH3z6WupUjF WLEpL7yrSMB4VC+w+ee1fT3rlxGgLYKb/M8pbDh/9wupQX3niMU/6nN0ydvJth20xKnz tC2PbUM0dcBK8zb0JMQ6XCaEGpo31VmXGKAnEGfiU9zpWNZnLNvlI8fJ/wAwJ1v/N/va RFJHYhmvkk1HYxg4ZY7/4OS9HYrDMsN20iBIBiWniMGBEeICX6Q/qGbbbcg7sFNMnxjq YgfQ== X-Gm-Message-State: AOJu0YwUQ7J6EzugWewW8z80nmyaSupLnzXy5W7XlN6fv53Ft2OKVeS0 obnbv/vENZ8WisgRXsqTRTapNw== X-Google-Smtp-Source: AGHT+IFVRmNXMEbNQPkppWpMfxB5GZ00/ir8cT0Q4jJSneFXioGp9uwFQafN49hR/A7039iEqUXmKg== X-Received: by 2002:ac2:58e7:0:b0:500:b53f:fbc2 with SMTP id v7-20020ac258e7000000b00500b53ffbc2mr10374360lfo.26.1698230406696; Wed, 25 Oct 2023 03:40:06 -0700 (PDT) Received: from [192.168.100.102] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id f7-20020adff587000000b0031fb91f23e9sm11788220wro.43.2023.10.25.03.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Oct 2023 03:40:05 -0700 (PDT) Message-ID: Date: Wed, 25 Oct 2023 11:40:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable Content-Language: en-US To: Konrad Dybcio , hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231024224255.754779-1-bryan.odonoghue@linaro.org> <20231024224255.754779-3-bryan.odonoghue@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/10/2023 10:18, Konrad Dybcio wrote: >> educe the pattern down to a common callback. VFE 4.1 is a special case >> which to me also indicates that it is worthwhile maintaining an >> indirection >> for the vfe_pm_domain_{on|off} for now. > Are there issues when powering it off like all the others? 4.1 doesn't have a VFE power-domain just a top level controller PD, however I think a blank callback is neater than if (vfe->pm_domain_on) { vfe->pd_domain_on(); } its just vfe->pm_domain_on(); at the cost of 1 or 2 instructions for indirection. --- bod