From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF86AFBF6 for ; Mon, 23 Dec 2024 14:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734963485; cv=none; b=DN4XdKrI1M3jtrN56MMJ0d5g+pXHna7HhEg5lPDLc+7UhhYcGybf4x41AW1DzaZekyLFrCV63oEi6TYcazDv7q6kjJDR0EbWyiN110OL3D0bPp7Z8ZP5UZeUAw70YG8HzRZlxxhSCq2SMHDaHiO/LPzDojbjQpzRL7a4ZdEeSSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734963485; c=relaxed/simple; bh=XTU+vlqtXeeHOOIoe2EWIgZrUhV2CUswvVm/Ujuim4c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oBlTIa7zkfHJC75WAfODp3lPAd2mgYBiLBb7wusCuS5bO909mcTzTwDvBJyyd4ipljlxtIRwnAznCutYceH7ndyzUR82mBaOxGwboPN52srwwHykK0WsKLEUB2aXcfyf7mfpWW4SD6H6Cc1eUi0gZwxJOxlQlWToaqZJJSEt0oc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bvuBeFIj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bvuBeFIj" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BNDLMqC018359 for ; Mon, 23 Dec 2024 14:18:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= H8jWZ4RVBkQFzgMbQPoAekGo+aUiaBBpyu//XLY0V5A=; b=bvuBeFIjh6wyaix2 KywSx7nzLhvd8LzVAo2BYekCY6TT6aGWNTt1RM6DlrwZVeGSEjhNx2x8QrQQVNBQ 3QGTMQP0v1gXTLpbFpoN4nCOpN5LnIKFpLdakfpgIKF81i5hazMVxtU8pOO6FBdc SsClrs3xOnnVZxsWtLThw43xMsDdCe7Sth/tw6iMbzSly15tlL1GDUb0FMOrALex zNcrb5BOUNVL7eWaRzWZuotUNSK8IyXmGmfgxWIqF04ATm02znFjM0jlZCs2a51S 0Yo7PpR7zPmiWQhhNjvh4IpKcL0tqNKWjuGaWUpewIhUNFOpznA4c3+M26PSFqJ2 1VZc9A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43q2459fqw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 23 Dec 2024 14:18:03 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7b6ee03d7d9so20257985a.0 for ; Mon, 23 Dec 2024 06:18:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734963482; x=1735568282; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H8jWZ4RVBkQFzgMbQPoAekGo+aUiaBBpyu//XLY0V5A=; b=kaczgwaqWDwFhRqZanBxIkqrcRkKqXD4tXhkAgVAmvFv5GjqV/WHkV1RMfE/mGq+II q1KiysGxAuv0v9WXY7ZKDMIJ2MVJNR49gB0/JQuvw+4KGorhXM2lp6qnjGAxQ7P94/nK IuC8jvfRStXtoil6tKemHt8h1Iot2tYLwlPqYTRZM6VZ1cxapw5CWo71Q/mi7SMem8AA 8lTs17fF3q+Gtd+d562d8wHN55w95rcXlvKu7QErWi7eBmAQZK9OuIvVbejNldfrN4fI N6bpZ6HswbEw3Qzo0IdQSLvJqE0RKTWvj+07HY48Wa19z2xoOXiEwKL6opfwhk38Ua1L KuzQ== X-Forwarded-Encrypted: i=1; AJvYcCWmvocAO7JfvwIaaX8e/pTjf15xa66EDMOLOT31nnV7YbSZLbCp1gH0OMwiCPhhwvP9azk/pgZzUvirGoQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq3LJmIZnpnW1FjPkxm2Yb2oRW67n3j5p20sejeS2DNtxuMYad 0nzzriDtROPfxZKKJa3IaHe0IA0Iem+dBHeUmehiPmq+FTR6I1NSjptnn2udczXGRASJLpiDZfP QFTO3yfJs2C2Vt8ERYwbEPskEhBBFkBN1X5aN9nxHkW3A7Xd2XZmpr6abBKdYzl4= X-Gm-Gg: ASbGncuTnLS/3EEWYD4ZX7swtQ9LgWWgle9a/CJeQPYGkv+57gO9UYM820gZTAxaeAj A71QajovLXaDjwoB95NtZi6Leo4QnaEyt6HbESHv4kh0mtR18vE0z3A0lRt4rPXmZEFjN+ooLx4 ns+DsCW8j8Ls2K4NyO91O8diVJIrL0CCRMxdLG5VWwjfFVKpRYiA56VMvjATKVyhFxq39fVTajW PjIB0rS3PPyCjDW31tn+x4ntBUvYsK+ZlM9KKk9Lg2hRUdGE4auat7mLKlfV7leFDvtLEo8VDyH 7x9DtJXrXNw6TtWFFFAHyNFdtHbCPNVyMkA= X-Received: by 2002:a05:620a:4455:b0:7a9:bc9b:b27 with SMTP id af79cd13be357-7b9ba733805mr676981185a.6.1734963481618; Mon, 23 Dec 2024 06:18:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5mDH6W1vcPlFhnTy5y2Kiwrye7mKSnekDwlY0l6aOYBufWCIaRB1qlepbhjrjk5HeHuxcsQ== X-Received: by 2002:a05:620a:4455:b0:7a9:bc9b:b27 with SMTP id af79cd13be357-7b9ba733805mr676979885a.6.1734963481269; Mon, 23 Dec 2024 06:18:01 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0efe4e5csm522086466b.115.2024.12.23.06.17.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Dec 2024 06:18:00 -0800 (PST) Message-ID: Date: Mon, 23 Dec 2024 15:17:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/4] media: venus: pm_helpers: use opp-table for the frequency To: Renjiang Han , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241219-add-venus-for-qcs615-v6-0-e9a74d3b003d@quicinc.com> <20241219-add-venus-for-qcs615-v6-2-e9a74d3b003d@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241219-add-venus-for-qcs615-v6-2-e9a74d3b003d@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: c7pVEAdLUwo0d2aDPHNF93BjLKaC1lDS X-Proofpoint-GUID: c7pVEAdLUwo0d2aDPHNF93BjLKaC1lDS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 mlxscore=0 spamscore=0 suspectscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412230128 On 19.12.2024 6:41 AM, Renjiang Han wrote: > The frequency value in the opp-table in the device tree and the freq_tbl > in the driver are the same. > > Therefore, update pm_helpers.c to use the opp-table for frequency values > for the v4 core. > If getting data from the opp table fails, fall back to using the frequency > table. > > Signed-off-by: Renjiang Han > --- > drivers/media/platform/qcom/venus/pm_helpers.c | 53 +++++++++++++++++++------- > 1 file changed, 39 insertions(+), 14 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c > index 33a5a659c0ada0ca97eebb5522c5f349f95c49c7..b61c0ad152878870b7223efa274e137d3636433b 100644 > --- a/drivers/media/platform/qcom/venus/pm_helpers.c > +++ b/drivers/media/platform/qcom/venus/pm_helpers.c > @@ -43,14 +43,20 @@ static int core_clks_enable(struct venus_core *core) > const struct venus_resources *res = core->res; > const struct freq_tbl *freq_tbl = core->res->freq_tbl; > unsigned int freq_tbl_size = core->res->freq_tbl_size; > + struct device *dev = core->dev; > + struct dev_pm_opp *opp; > unsigned long freq; > unsigned int i; > int ret; > > - if (!freq_tbl) > - return -EINVAL; > - > - freq = freq_tbl[freq_tbl_size - 1].freq; > + opp = dev_pm_opp_find_freq_ceil(dev, &freq); > + if (IS_ERR(opp)) { > + if (!freq_tbl) > + return -EINVAL; > + freq = freq_tbl[freq_tbl_size - 1].freq; > + } else { > + dev_pm_opp_put(opp); > + } I'm not super convinced how this could have ever worked without scaling voltage levels, by the way. Perhaps this will squash some random bugs :| Konrad