From: Taehee Yoo <ap420073@gmail.com>
To: Yu Zhe <yuzhe@nfschina.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
liqiong@nfschina.com
Subject: Re: [PATCH] amt: remove unnecessary type castings
Date: Wed, 6 Jul 2022 13:40:28 +0900 [thread overview]
Message-ID: <fde90f42-6ad0-ead2-3d10-6a37dbbd708e@gmail.com> (raw)
In-Reply-To: <20220706011449.11269-1-yuzhe@nfschina.com>
Hi Yu,
Thanks for your work!
2022. 7. 6. 오전 10:14에 Yu Zhe 이(가) 쓴 글:
> remove unnecessary void* type castings.
>
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
> drivers/net/amt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/amt.c b/drivers/net/amt.c
> index be2719a3ba70..6b4402c26206 100644
> --- a/drivers/net/amt.c
> +++ b/drivers/net/amt.c
> @@ -1373,11 +1373,11 @@ static void amt_add_srcs(struct amt_dev *amt,
struct amt_tunnel_list *tunnel,
> int i;
>
> if (!v6) {
> - igmp_grec = (struct igmpv3_grec *)grec;
> + igmp_grec = grec;
> nsrcs = ntohs(igmp_grec->grec_nsrcs);
> } else {
> #if IS_ENABLED(CONFIG_IPV6)
> - mld_grec = (struct mld2_grec *)grec;
> + mld_grec = grec;
> nsrcs = ntohs(mld_grec->grec_nsrcs);
> #else
> return;
You already sent the same patch[1] and it is merged[2], it can't be applied.
[1] https://marc.info/?l=linux-netdev&m=165577785300445&w=2
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/amt.c?id=d13a3205a7175d673d5080ddf155dc69aad6085c
Thanks a lot!
Taehee Yoo
prev parent reply other threads:[~2022-07-06 4:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 1:14 Yu Zhe
2022-07-06 4:40 ` Taehee Yoo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fde90f42-6ad0-ead2-3d10-6a37dbbd708e@gmail.com \
--to=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®