From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6798F3B2FC9 for ; Tue, 14 Apr 2026 08:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155554; cv=none; b=sBdDr/n3lAtjc2oSK/3UbOT1Mnta70yySd1UWzv943PGpxhdgiGSy6qXyp6BoxEvTHZH/7MTyMXjOjOlTIjT0cMpE9PZ2lNaYkvNh1VfhwSE+kD4bIFdjUgnweUFBXEkNAl8MJ3+eHDz/xuxvIHHzt9T8npGuTp8Fj8rgtG5Uls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155554; c=relaxed/simple; bh=oOScpENHzavLOWGVgafokoO2WeuQKSvCI7PDd6PCPyU=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=G3YakHAmEphb5dcCveZVO6kX6FyJnhvYU6Vi0d3yjSbyKbBFF/o6NvTMoEwM7wdSl2uOnDqvahoOwotdunfZlYzy1hpSyLMrpECbdvBbqEozQyKnk/Hv+Xr8WvxJXGO/3buwYY/vyy48x+y43U1WrJjPDSLDLTx28J9U6r5TBow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pIjtoJj1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WTctfiPt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pIjtoJj1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WTctfiPt" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E6NdZX2386540 for ; Tue, 14 Apr 2026 08:32:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oEIeYgZn/55wFznsq6tgBfUJhO0jP3QkGZsmt7PhTzs=; b=pIjtoJj1Fwnf+CAb tjyCnKqkkQK3j/wsy7OKpGK6r4u6O14gyifM+LskH48V3hehqrF817ckWM4/ARWE xh1dKTX8b1KIWZzjNg5owyHPRZNe9DLtvaXE1Iaxf+8YJzAONMUDzYSlrJ8iEazM XfA4qsacvH611y3joEIhaomNMwy2TbnqPJXXe+/bs3V/q6jA+UlPJqLiO9KMWKiW NfSLNDRmT/7qQKUFnWoicPeqOCk9QhWi0kwXumf/peGux7T33ZaIvTNNHFvgI3s1 eZBAQ87Wucwvm4DUcdHSUTZBXrg4/V4Hk/Z+Xc8Rtpt1Afvmkpygpep2lYilq8ZV ta6JVQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh86w1t19-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 08:32:32 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82c7a84a43eso6425059b3a.0 for ; Tue, 14 Apr 2026 01:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776155552; x=1776760352; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oEIeYgZn/55wFznsq6tgBfUJhO0jP3QkGZsmt7PhTzs=; b=WTctfiPt1gpRqGKRpcTHX1vpH/P1DCSkomP2hhiE27QR27NTYzmCL4kmcIwbLK/dYb c+Ci6BQvuQ03u6OpUIgiVD2tc+Tb6pLfU/VcRpKca78ptlFlwlYmp2BiXn0cwYPKxyFH l8DltAvoVTz1lcSkmHeUr+i0NHtGk6og6AEU6eWfPKStiNqDTBtzGy9Omb0g+lrk6ry5 CahOQsrpmc3ccK1pvjAb67KFvUlSmCfChiXZdXpx59DRoGJikLAj9qatxmu4kNCUVoc5 EIIMCu6laGDuiLG7RLMkHDd4KeLGve/1rYOCGmnuiABq3i0R9aY21Zq0E4z9Shze8LTb WZwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776155552; x=1776760352; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oEIeYgZn/55wFznsq6tgBfUJhO0jP3QkGZsmt7PhTzs=; b=HBN4Yghhnp7Vutke6dVSGo8GTz9KO8RcBwsvbQODPmsjZWreFLefZvkepQCiMFepg5 RyE/kUumpLbSaxPPvOEH7EdZNiXDeI2vQ7tdbmBPWdDeS9b4YZy19iiuz67Cc8qhJLca 5n2lNsP8c1KTzWufeQyTmgcPQg8rMlVfgxGoXOPTdubO2WnIQJ5HRaZ/f/j3GdO9D5hX +S8HevVgdhCOJHDj3D8uKaNSscazBLTFre8Az2mjy/DV9hOEPAaBEnFVOXM5N7r2mJG2 G8wJm2mc5zTCI3+5Pbs5/LOqfvmpu6NFwijOpa5FyDXxZQfPSBNIgWYOJ0t+TuLk7Hs2 KHJw== X-Forwarded-Encrypted: i=1; AFNElJ9Z8QNyj5XbqnALOwZ3IDeeiAlQqgZMgJMDt9I9eYTuR/mbphJWx3BTpFZPhTDWBYl9OnF3WyoFDSQI/i8=@vger.kernel.org X-Gm-Message-State: AOJu0YyrD614oBdyfmKzJsjE1azxM2DXmqryr+QCC/WgPy7V6L2zmTIB OqMjxOSohDNIvR3o7DxX2k6rrvJ2Z3uWQrgPA3Y8+2+acwG6DSRxz2FAEef4z9lEbgIaHSEzQX+ izOn8POAIKq7HKeINHbkgR8ev2tO7FhwvellWG81/cj8rD4+MQcxvmy+UlnBhRChNHfw= X-Gm-Gg: AeBDievmQjcOJJIiFrxQyL7VFeD2G4C9ARmBcwr3fzLMW12DVNysWRoSUsDNa8xRYTg PHIpMZdVKm9RYfVw1oaerrkvz1bHQBclub+/PeaqrHoCFplviy4L7CjEfc7550Xugyqm5ukwF3D pSUAMSKFOm70k77Aez+9T1IvszZJpfo55XHcfvwNTmr/xdXXOfFcx3vnJJIDkaz17752Ff758bx kWwGYoHksj1asVXcZDMkfBtSvIDDkvMoUP58SxrcvkxC0iNllzXV1EAm9Z5dnHakwYuaNr4FR1z lYA/XXYry3CYjNuNe18SIjDsDq6mV1u7xUOgbfHhbgUbh9hOrCWy9F1sKzs9lqNZGDg4KeT4pIH dw0FdtVaKRIyunka+lVpLQJMUEzEV9ltnipKaNZlo0VqrljbLyjVNvLnAPdQmkblaGl30BEREq4 s1/P15zagepiWiM5b2D+7RxiYuFw== X-Received: by 2002:a05:6a00:8c83:b0:82f:1b50:d2f2 with SMTP id d2e1a72fcca58-82f1b50e2d6mr9600304b3a.18.1776155552018; Tue, 14 Apr 2026 01:32:32 -0700 (PDT) X-Received: by 2002:a05:6a00:8c83:b0:82f:1b50:d2f2 with SMTP id d2e1a72fcca58-82f1b50e2d6mr9600284b3a.18.1776155551545; Tue, 14 Apr 2026 01:32:31 -0700 (PDT) Received: from [10.249.17.86] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c311a06sm15356803b3a.10.2026.04.14.01.32.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 01:32:30 -0700 (PDT) Message-ID: Date: Tue, 14 Apr 2026 16:32:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: wangao.wang@oss.qualcomm.com, Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/5] media: iris: Add hardware power on/off ops for X1P42100 To: Dmitry Baryshkov References: <20260401-enable_iris_on_purwa-v4-0-ca784552a3e9@oss.qualcomm.com> <20260401-enable_iris_on_purwa-v4-2-ca784552a3e9@oss.qualcomm.com> <20260402-lurking-tested-marmoset-f315b4@quoll> <9bd4e289-9cf1-4502-baa5-d85cf6e07df1@oss.qualcomm.com> Content-Language: en-US From: Wangao Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: iRcQeuItuSwVISzQSbexSiNpBAN7gPop X-Authority-Analysis: v=2.4 cv=HKfz0Itv c=1 sm=1 tr=0 ts=69ddfba0 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=Qnz2KnwcCDuQAHdkxh4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA3OSBTYWx0ZWRfX2BKw9xAgMsvw sIvPgtMV0rhGIWc2h78u1aQVWIC61HwowATybtjql9ymAESJonmmotabb8Zh/lOiuo0Raht8duQ pB5eI9qHQyLZqsn892x59STZwI0r74SbIkK7OsFrLtJUEBhHCf5uJ9/6VdFgA3hND0XzacQLifS uO/ELSQwnXhoOIWaqb3OMuVmzZRNTLEmPmzAo2K4zj2WjMgTdAmWvCp4K4x6V2GigyJ9SaGgTzH JfC5fIdlf2uniKJyO1M470I1zDkCUvevE6m4oROopfWK27NJmNtJrcGCnq8Yy1P59QH2fW3Am5/ nPqJDu3j9FfgVriNKM0L8/lW0m6M+ZndwbdRmEyw+T7FhcQKRS1Gz5z0RI1w4La2g5WDM3DeNW5 K2gSEMnVT2fPvAKqve15jXWGs9qy/mjFEkZT0GmDaGOQQBx6EnIzRYOJBxYbUvplj0Dv+uaXcK3 jzvW0QFXk8sSIMIs3SQ== X-Proofpoint-GUID: iRcQeuItuSwVISzQSbexSiNpBAN7gPop X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140079 On 2026/4/8 18:41, Krzysztof Kozlowski wrote: > On 08/04/2026 11:16, Wangao Wang wrote: >> >> >> On 2026/4/2 15:08, Krzysztof Kozlowski wrote: >>> >>> Why no IRIS_HW_AHB_CLK in power on sequence? >>> >>> So if you rewrite the code that you have list of clocks for hw power on >>> (IRIS_HW_CLK + IRIS_HW_AHB_CLK for all variants, +IRIS_BSE_HW_CLK on >>> this variant) you could have just one function for all of them and >>> devices will be fully compatible. >>> >>> No? >>> >> The original patch was to add the IRIS_BSE_HW_CLK operation into the >> common API, but Dmitry requested to separate Purwa's implementation out >> independently. > > So you don't know why you are doing things? I don't understand what sort > of argument is that. > > You are duplicating code, while all this is simply the same logic - > three clocks which need to be enabled. > > Best regards, > Krzysztof Hi Dmitry, I think this can be moved into the common code, so that any future VPU3-related changes will also be applied to purwa. What do you think? If that works, I’ll update it in the next version. -- Best Regards, Wangao