From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC3A3274B23 for ; Wed, 31 Dec 2025 04:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767153658; cv=none; b=MLfjRPGhhSBiW4oHXhdxsWyx1/8qgDsTxwC5H73k07B+rSbMlrfS+ttXwYMBiUxLVwd2vQ5IkDadN2MdThpklXmwpvwtEE04KuZct4cjYP5jEUarfHLsxkYeInFoG7IOiTYiQeEhk+x5L/qBwgRdaTCFOYzqTdzJZRa/j0S/fIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767153658; c=relaxed/simple; bh=aVCmmmffctXfw9cmZQsxfxcu0pYDd14gTER5bJ+1/Fg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q6xVLbjpHAfxO/Uy3aa5bOdWhuvvzLPDyzna39n/Sz2PZtQGeSPezAPB3BPBhrUhlNpQN4zT39YXdcae8YyE4lmYNhHMRVD/QCCxIxoIuHW7ejk2YSt5FbLkeoHg12BiixgZLpx2vfMLL04CDTMW6DXJ7jrgJXdCCRFu0elL7SM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QDEAe+mn; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QDEAe+mn" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7c52fa75cd3so11921930a34.3 for ; Tue, 30 Dec 2025 20:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1767153655; x=1767758455; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7VNylGeHty3hhb1+O1+8twZmND0tnjr8y4TdbwY0GSg=; b=QDEAe+mnC/VsAfBqky7/IRbgRoTvJAl7BM7WcwiOTLIms2lXrO2720xXpfkHf61doS qXYhv75kdZzHbCeFh/4uiZLD/GGLoPsXgSgLYvVw+UtsQvAZH/1OpNG8Y+7y6LDOxzkk xppVNr7ai/8qj7xdxDkwe+VHefXGpkXF7KQEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767153655; x=1767758455; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7VNylGeHty3hhb1+O1+8twZmND0tnjr8y4TdbwY0GSg=; b=EsG5t1APNz25E7ub6rHfBv/qzR3f0dUje3WHzA3o9qo3Hda2sremWZ/sLAd39/3IVv I0syJbeDIRa9ZWDPi8ah+s8LB2+I6AFqkfNaCOKQx5IlToDBo7kIIGttH/6iKNG3KyiW hN7OzrEC+4sUThZ9UV3aRPmzme4pdG63Lf/XMNBmRQKJa36Qyu4K3N1DmBIX92C2Xjiy KuGl6S1wfaeYg/R2RsYKBlLIPKHnwwwb4Lq9ohzssu8kIINdEKaJVbS4rJ8IIUIhnS/g 3RnuWFNo9eU8pnLyPzM0sKavJ1v1ttsGSJU/VRt1BjRCkrSUfonWFpmflydR3uHN9oiE bf5g== X-Forwarded-Encrypted: i=1; AJvYcCVEQH4EIcz8XWtMojvovhx2qIXJYMtpSCcsMVOxIT5syEBHh//Rjxds/UT+0g2T81j6bDImw2+5Lju5y6U=@vger.kernel.org X-Gm-Message-State: AOJu0YyW/YZ8K3SICPI8+u7pQJAJmC+yBd0uniYyTthMegfmbUXp3fkF khx0w7NYMqrVDA4sP1G8kXFkNMx1+etuhE90VkCuuxD63gyuzquIK+KryaqrKLGIA5o= X-Gm-Gg: AY/fxX7beKL07iv4nZ5NV8w3C8RUwQxzKhgxtZeJrshBFuEm/vwnrFIEu0rhYiYF910 dgE6Q5kf/yxQSfRu8PkxwTZ9+FHzrgUADgSWxmv+Lfhbupw80C5emC5TsLIwHcOkcfSz41UxPCe FCyzX2E/WfMHzLTKTOgsERQkB6/kYcDu8TyLs3/z9T1OwlbK99FmnIG2A19aIYxSqlSEzHozBgf Vz3haXd9hbUh1Zw3FfxgOI2bXbp3+AIkS5fMyYATLa6ZxmUCGYt0SDksNzdFB3z+Tn0rAg/VMT2 YUCwWrI99+7mNkNa8M/odlXAaIACyPfmerjCbSpz7c/RPjuy0g8dLZiMk5/EE+JaX2aiu3I45jM GK74Sg//MPm3InAKkT0PLz50SWQ9w9Z5EH4j0ybuRpA/c9MI6IB543OYPmUxFW+t0VEXcJyDD2X 1GmpodSpjRFsBd9I+k4w3nQEQ= X-Google-Smtp-Source: AGHT+IF9F/siqhgAslvMOnVu4nsfQJ2/g/8vSzR2SppngNQxxoARtodDwAouloJqhdkdH2KDxgw/hQ== X-Received: by 2002:a05:6830:6688:b0:7c7:5974:3563 with SMTP id 46e09a7af769-7cc66a15846mr16285625a34.29.1767153655626; Tue, 30 Dec 2025 20:00:55 -0800 (PST) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cc66727e37sm24112013a34.1.2025.12.30.20.00.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 20:00:54 -0800 (PST) Message-ID: Date: Tue, 30 Dec 2025 21:00:53 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Linux 6.19-rc1 mediatek mt7921e broke badly To: Eric Biggers , Linus Torvalds Cc: Matthew Schwartz , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Mikhail Gavrilov , Mario Limonciello , Johannes Berg , quan.zhou@mediatek.com, Felix Fietkau , lorenzo@kernel.org, ryder.lee@mediatek.com, linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , linux-mediatek@lists.infradead.org, shuah , Shuah Khan References: <756e3f65-b2f2-4da3-985a-17754a7a872d@t-8ch.de> <6fc04df5-b753-4b2d-b978-0e59a7f48ff7@linux.dev> <20251231015712.GA2299@sol> Content-Language: en-US From: Shuah Khan In-Reply-To: <20251231015712.GA2299@sol> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/30/25 18:57, Eric Biggers wrote: > On Tue, Dec 30, 2025 at 05:27:13PM -0800, Linus Torvalds wrote: >> On Tue, 30 Dec 2025 at 15:57, Shuah Khan wrote: >>> >>> I would recommend reverting f804a5895eba instead of trying >>> fix it. Then find a better way to eliminate extra newline that >>> shows up in dmesg when firmware build date happens to have >>> a newline. >> >> Yeah. Let's revert it. >> >> And the way to fix the extra newline is trivial: just remove it from >> the "dev_info()" format string. >> >> Our kernel printing logic will add a newline for the next line anyway >> if it is missing (unless somebody explicitly uses PR_CONT). >> >> Can whoever saw the problem confirm that just a revert and a "remove >> \n from that dev_info()" fixes the output for them? > > That works for me. The revert by itself makes the FORTIFY_SOURCE crash > go away and reintroduces a blank line in the log. Removing the \n from > the string passed to dev_info as well makes the blank line go away. > I just sent the revert. I will try removing \n from dev_info() later on tomorrow. My quick trial still showed extra line which didn't make sense to me. More trials have to wait for tomorrow. thanks, -- Shuah