From: Daniel Scally <djrscally@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>, Mark Gross <mgross@linux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86/intel: int3472: Use y instead of objs in Makefile
Date: Fri, 6 Aug 2021 23:13:35 +0100 [thread overview]
Message-ID: <fdf5b050-2c8d-f3f1-f8bd-0dbc616c9bc6@gmail.com> (raw)
In-Reply-To: <20210806154951.4564-1-andriy.shevchenko@linux.intel.com>
Hi Andy
On 06/08/2021 16:49, Andy Shevchenko wrote:
> The 'objs' is for user space tools, for the kernel modules
> we should use 'y'.
Oops, now you mention it I remember you saying that for the cio2-bridge
code too - thanks.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Daniel Scally <djrscally@gmail.com>
> ---
> drivers/platform/x86/intel/int3472/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/Makefile b/drivers/platform/x86/intel/int3472/Makefile
> index 48bd97f0a04e..2362e04db18d 100644
> --- a/drivers/platform/x86/intel/int3472/Makefile
> +++ b/drivers/platform/x86/intel/int3472/Makefile
> @@ -1,5 +1,5 @@
> obj-$(CONFIG_INTEL_SKL_INT3472) += intel_skl_int3472.o
> -intel_skl_int3472-objs := intel_skl_int3472_common.o \
> +intel_skl_int3472-y := intel_skl_int3472_common.o \
> intel_skl_int3472_discrete.o \
> intel_skl_int3472_tps68470.o \
> intel_skl_int3472_clk_and_regulator.o
next prev parent reply other threads:[~2021-08-06 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 15:49 Andy Shevchenko
2021-08-06 22:13 ` Daniel Scally [this message]
2021-08-07 9:46 ` Andy Shevchenko
2021-08-07 9:48 ` Andy Shevchenko
2021-08-09 9:00 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdf5b050-2c8d-f3f1-f8bd-0dbc616c9bc6@gmail.com \
--to=djrscally@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®