From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 802A1285CA8 for ; Sun, 18 Jan 2026 10:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768732031; cv=none; b=MMqF8AyrrY5GakV5ldDzeCz2I3kxybHAWJVmcO3Ia+t8YX1nnEFGNYFNEXCHijT6XZFop3OeczJ3NyoMoKmtdk8ilzx8/QWx240wqG78VUF90bBHXJriGEVobWjtsRvmGrxvYhuPU95JRZ7aWZP/NfZ8K/EfNYKVkaXUZSFGWIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768732031; c=relaxed/simple; bh=g3v9aNdNytZLZ6rBo2v8ocKbRD+tgP/M2fp0XY9ZWC4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o/cYoY8uIVApZ1GvUNALBcdNWQfX0+UG0EuQ2s63dRi95xo/7D+Axe7bcXkDzZ5nw7VsyVPMgjHlsCH1VA65qXkPPd9EzzWUrpFIatlEDk0RXRi6X4SwSZivhC2WrhzUjSjxgp5qJjFGDSKlrVSyj2UWUjzRzSlnbpQu7I/YF1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WisN+iYo; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WisN+iYo" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47f3b7ef761so17661415e9.0 for ; Sun, 18 Jan 2026 02:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768732029; x=1769336829; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2wVayVrE8vfLjDsbFPedYadpWwsg6eC8hmmLmvT9NIU=; b=WisN+iYoyZlLt8E6rcLH8jHzINlF5qvyjphoOLJW/ZzznGjOj4lDpJIgfD8XoNA4ot xY6IkwkZ9AiJYXPWD6t7fZ2O1DVDnwoXjIbihHmaISUWs+feLk1NJRyvrFU+uhwd7isC 0tbCJ4Pg/f+39JD0rwu+toacbbI00n2kY76pMm4oKWsTbF8HEuuZmyQfUbP/PEuvbpqx mPA4vYNCMybaruxJuKLuHszEGgvetQU5weXT7528KJdFvqYXYg5lplGjoXJgEe/0Mk3f zBq1mpNKhDgGnKpuLKME0iRNpjG7aNSwl64zEg2PrdpnJpeR/AYQBacvYVkqNzSFamua 9eFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768732029; x=1769336829; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2wVayVrE8vfLjDsbFPedYadpWwsg6eC8hmmLmvT9NIU=; b=vCLS3ZBkQFSm2zW3DCd5U8H0qdwPgg8c2Cy3+qV8NShTgSg0NvLPbfkijfs48gkhLz mv2g91w0on7uRLIvZ420e1l4Hz+orWZE+4+a3qWHKY1s6xCTfXb5726rNOTfXjVLXlit Wo89TZ1BTL3M3ShHiRR+pjuA7KSWr0RvSSV9ZX/kFGCDs3Cg1X72B3/33Bt74tjNStGO UPGyTlmMRLknht2yZJTkGkjUmgX0gZui20AjGdwt5XInxXuDplqowuWfODEb1hxk30Fc nAnr9WXqf7xtSWjkMTbYoqxBs6n0CiveW3DLIbHkmSFqJDNt4zBtfPVKnESMMwkSD1Dd 3Txw== X-Forwarded-Encrypted: i=1; AJvYcCUFp4bp3JofFwRsb7qkY83dNWYH/Vxx95CBGHzBwR8njyj57Ae432KPRvMeC4aDiT8KSWraki8ixGtOenE=@vger.kernel.org X-Gm-Message-State: AOJu0YwdgPhiRD7Qxi1dik5kXFrfbXCTuZI7L47tRn7X/OaC5+R4lzlT E4IX1wCivY0OFf0IzZOhcZWJRfGEd+vhhXvtCUahey0WMaCluzdZZm8SVg/c8R2fvlo= X-Gm-Gg: AY/fxX5M1Qo3T6SQEPLYiLR/GBxUSg/OW++Uq9Fglrz2uPLC+GpVR0FsbEy349OQar/ UvigzB3+Hx7K1TFHP437XG2T2gXat6bDP5M/Jh4hQIVP5w9xH9lpgJ2fk1GNZ0M35dMT52llovp 1L87EEBgL2T3F8qmSTArdnW0yOmm7GEqm/XTWoqoqVt9/EF2ZTqp3ENmuPnZTu/bLQz+PeGpGTr sYjQqfiJNmIrHs/q3UxRtBEJ94zZ/1TjvgXqbN7dCq4HQkiV5AqD/vMfuy3XCwtYFhs1hGVtLeh UUxM+xCDiQbqeMPvdEWbmMpAfKTqXl7WGzKm2gv9s/E+QV4+QinwbiHlElStFz9Ip3IW5wcy8PM bpp8yKk3agNYP95fOsnxbPGh7yd6KENEI0noF5fyXCr4Hx4fOrhoyS0AR6sv/qvJbql0lDfsw1t /Ly/pSqNppab0OIX0MmxqQfdy8Fqgu8sRC82u6h/5gk5uiP0i1VKdf7854XYAHPiw= X-Received: by 2002:a05:600c:8714:b0:479:3a86:dc1c with SMTP id 5b1f17b1804b1-4801e3531c2mr111870855e9.36.1768732028854; Sun, 18 Jan 2026 02:27:08 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f428acae8sm190955195e9.4.2026.01.18.02.27.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jan 2026 02:27:08 -0800 (PST) Message-ID: Date: Sun, 18 Jan 2026 10:27:05 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/8] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 CPHY init To: David Heidelberg , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , Casey Connolly , "Dr. Git" Cc: Konrad Dybcio , Joel Selvaraj , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260117-qcom-cphy-v3-0-8ce76a06f7db@ixit.cz> <20260117-qcom-cphy-v3-5-8ce76a06f7db@ixit.cz> <4936947b-f402-4817-acf7-299abbeeb23b@linaro.org> <010df7e2-ea01-4b32-ae4f-40bff3ad278b@ixit.cz> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <010df7e2-ea01-4b32-ae4f-40bff3ad278b@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/01/2026 09:51, David Heidelberg wrote: >> >> If checkpatch.pl doesn't complain about it, I think it probably should. >> >> Please standardise the location of the comment and have one for the >> CPHY and one for the DPHY configs. > > Then I can rather replace the else with elseif (== DPHY) and make the > comment irrelevant. What is your recommendation? > > David> I think the code is pretty self-documenting without a comment. --- bod