From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D79112AF1D for ; Tue, 21 Apr 2026 08:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776761421; cv=none; b=sBJ9H2gjvh73J8TSR9i/hNBU8BmFlop/1R6QD2EIkR5eyt4ppRboELEnWOQrPJcNlFdzjo9zP314rompupuxkpCRxk2vfLaVDrOzRdpQ02VYy7uGvFQb/Z+dd/fZL6PULlYYyWSdhYjATvs9azQgoN/1sTQyztGsRFz1//mJ11s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776761421; c=relaxed/simple; bh=HMKhRQDZ6VybJ+xiqnuGn8VaE1KO7V0xQaywDs6oYsE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jXi1k6t+i8cSaRb0viPQKPYaE6Qkk9WzgRQfS2pbjyep8ftxSS218X5Z3zkM7QFhGngOjCn9SIVywMvs3yu8h5RuwVOWhGfNTtDLbbjgvrTUUmfhVf/vondjJ3lZnP/rl4O12fOkN73+WYS3ZhPjUDnluzm4Thhzu/NPyerzAsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=u4q/Fbcb; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="u4q/Fbcb" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3AED25E0; Tue, 21 Apr 2026 01:50:13 -0700 (PDT) Received: from [10.57.17.241] (unknown [10.57.17.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D529C3F915; Tue, 21 Apr 2026 01:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776761419; bh=HMKhRQDZ6VybJ+xiqnuGn8VaE1KO7V0xQaywDs6oYsE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=u4q/Fbcbwj/LshtkxLDhcmX03cPJ6K03eXdCPhBWm9u6vnpU0lYHTZ3LxURJLhL4K y85M0k6grCwXX9K278d9FkdvM79PK7u2ES9U6/Mz4WKsGFqtk25P/NwMb58D5YACv3 hb42Rec2w3ygdHfZlseEGfKUH4uUjoO/MW3qQ7zw= Message-ID: Date: Tue, 21 Apr 2026 09:50:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/12] coresight: etm4x: fix underflow for nrseqstate Content-Language: en-GB To: Leo Yan , Yeoreum Yun Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com References: <20260415165528.3369607-1-yeoreum.yun@arm.com> <20260415165528.3369607-3-yeoreum.yun@arm.com> <20260416151102.GL356832@e132581.arm.com> From: Suzuki K Poulose In-Reply-To: <20260416151102.GL356832@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/04/2026 16:11, Leo Yan wrote: > On Wed, Apr 15, 2026 at 05:55:18PM +0100, Yeoreum Yun wrote: >> TCRSEQEVR is implemented only when TCRIDR5.NUMSEQSTATE is 0b100, >> in which case n ranges from 0 to 2; otherwise, TCRIDR5.NUMSEQSTATE is 0b000. > > My suggestion in previous version is not quite right, thanks for > making this correct. > > [...] > >> @@ -1395,6 +1395,8 @@ static ssize_t seq_idx_store(struct device *dev, >> struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); >> struct etmv4_config *config = &drvdata->config; >> >> + if (!drvdata->nrseqstate) >> + return -EINVAL; > > For "nrseqstate = 0" case, would it return -EOPNOTSUPP instead? Or should we make this only visible if the nrseqstore is meaningful ? Suzuki > > Otherwise, LGTM: > > Reviewed-by: Leo Yan