From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337F7C0502A for ; Tue, 30 Aug 2022 06:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230321AbiH3G7m (ORCPT ); Tue, 30 Aug 2022 02:59:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230311AbiH3G7k (ORCPT ); Tue, 30 Aug 2022 02:59:40 -0400 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52952C00DA; Mon, 29 Aug 2022 23:59:39 -0700 (PDT) Received: by mail-ej1-f41.google.com with SMTP id fy31so19781075ejc.6; Mon, 29 Aug 2022 23:59:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=udLDyvqYEWiFFMc7PF4o3+l6dw+FJ84syS3HsmSGTcA=; b=nybnJGTvo1weV/qzWwUP+2cXrQ3ED9Pyh5MQbj+W47K8nM0QkwohrSGjtUZ+enM9Dd 9H/dpixKrroTtehrQoZBETDDFHs4Lc16eS4ItdSSEgnMOEp0zkiuO/KFIynJQ5q7AtmX WhwzJWS8uCNmND9xfR0x9cBEwLrV6lLM1UUITeH7CJYAN9G47QWEjWoHyFWjd6Ril9cJ cpZu5YJayw8DVVe4g++Bqihs6zwGPm6opVytoqD5Hb3FP1J6WvLmj8WeZsDZ1eAHzQ+G XRsvh/gqMh+imm+GUJuZC0Qy1V4cHNjpT9t+TCLjfo+rzfsBaWpzh1Mb20MnoUcrvwZv KiYQ== X-Gm-Message-State: ACgBeo3Qk8xuvnHZGreVeZ3nBWoPFxikEv1ww6ESppxi9QtkRGIbtoTf nFtxQtobfkPdmDH+RUP6S9U7jbk7N9ltVA== X-Google-Smtp-Source: AA6agR6Flm8qe4jXyOfHveehL6f0JSYaqRNWgZurTFrHZIkwS7S7R7X/1vOMlUKm8gI2O12IYevEbg== X-Received: by 2002:a17:907:728d:b0:731:8396:ea86 with SMTP id dt13-20020a170907728d00b007318396ea86mr16058182ejc.361.1661842777858; Mon, 29 Aug 2022 23:59:37 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id w23-20020aa7cb57000000b0043a61f6c389sm5638914edt.4.2022.08.29.23.59.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Aug 2022 23:59:37 -0700 (PDT) Message-ID: Date: Tue, 30 Aug 2022 08:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 4/6] tty: n_gsm: introduce gsm_control_command() function Content-Language: en-US To: "D. Starke" , linux-serial@vger.kernel.org, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org References: <20220823062259.4754-1-daniel.starke@siemens.com> <20220823062259.4754-4-daniel.starke@siemens.com> From: Jiri Slaby In-Reply-To: <20220823062259.4754-4-daniel.starke@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23. 08. 22, 8:22, D. Starke wrote: > From: Daniel Starke > > Move the content of gsm_control_transmit() to a new function > gsm_control_command() with a more generic signature and analog to > gsm_control_reply(). Use this within gsm_control_transmit(). > > This is needed to simplify upcoming functional additions. > > Signed-off-by: Daniel Starke > --- > drivers/tty/n_gsm.c | 30 +++++++++++++++++++++++------- > 1 file changed, 23 insertions(+), 7 deletions(-) > > No changes since v1. > > diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c > index 9535e84f3063..5a20561c0a5d 100644 > --- a/drivers/tty/n_gsm.c > +++ b/drivers/tty/n_gsm.c > @@ -1316,6 +1316,28 @@ static void gsm_dlci_data_kick(struct gsm_dlci *dlci) > */ > > > +/** > + * gsm_control_command - send a command frame to a control > + * @gsm: gsm channel > + * @cmd: the command to use > + * @data: data to follow encoded info > + * @dlen: length of data > + * > + * Encode up and queue a UI/UIH frame containing our command. These tabs after asterisks are not understood by kernel-doc. You should add no new ones. > + */ > +static int gsm_control_command(struct gsm_mux *gsm, int cmd, u8 *data, int dlen) Can gsm and data be const? I assume gsm cannot due to call to gsm_data_queue(). And what about cmd & dlen being uint? cmd seems to be u8 at least... > +{ > + struct gsm_msg *msg = gsm_data_alloc(gsm, 0, dlen + 2, gsm->ftype); > + > + if (msg == NULL) > + return -ENOMEM; \n here > + msg->data[0] = (cmd << 1) | CR | EA; /* Set C/R */ > + msg->data[1] = (dlen << 1) | EA; > + memcpy(msg->data + 2, data, dlen); > + gsm_data_queue(gsm->dlci[0], msg); \n here > + return 0; > +} > + > /** > * gsm_control_reply - send a response frame to a control > * @gsm: gsm channel > @@ -1623,13 +1645,7 @@ static void gsm_control_response(struct gsm_mux *gsm, unsigned int command, > > static void gsm_control_transmit(struct gsm_mux *gsm, struct gsm_control *ctrl) > { > - struct gsm_msg *msg = gsm_data_alloc(gsm, 0, ctrl->len + 2, gsm->ftype); > - if (msg == NULL) > - return; > - msg->data[0] = (ctrl->cmd << 1) | CR | EA; /* command */ > - msg->data[1] = (ctrl->len << 1) | EA; > - memcpy(msg->data + 2, ctrl->data, ctrl->len); > - gsm_data_queue(gsm->dlci[0], msg); > + gsm_control_command(gsm, ctrl->cmd, ctrl->data, ctrl->len); > } thanks, -- js suse labs