From: <Parthiban.Veerasooran@microchip.com>
To: <kuba@kernel.org>
Cc: <piergiorgio.beruto@gmail.com>, <andrew@lunn.ch>,
<hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 1/2] net: phy: phy-c45: add SQI and SQI+ support for OATC14 10Base-T1S PHYs
Date: Sun, 30 Nov 2025 09:13:50 +0000 [thread overview]
Message-ID: <fe02fb6f-b9f9-4fb1-ba63-893ae18f0376@microchip.com> (raw)
In-Reply-To: <20251127184417.203c643e@kernel.org>
Hi Jakub,
Thank you for reviewing the patch.
On 28/11/25 8:14 am, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Wed, 26 Nov 2025 16:19:54 +0530 Parthiban Veerasooran wrote:
>> /**
>> * struct phy_device - An instance of a PHY
>> *
>> @@ -772,6 +796,8 @@ struct phy_device {
>> /* MACsec management functions */
>> const struct macsec_ops *macsec_ops;
>> #endif
>> +
>> + struct phy_oatc14_sqi_capability oatc14_sqi_capability;
>
> kdoc sayeth:
>
> include/linux/phy.h:800 struct member 'oatc14_sqi_capability' not described in 'phy_device'
Thanks for catching this. Somehow missed my radar. I will add the
description for the struct member 'oatc14_sqi_capability' in the next
version.
Best regards,
Parthiban V
> --
> pw-bot: cr
next prev parent reply other threads:[~2025-11-30 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 10:49 [PATCH net-next v3 0/2] Add SQI and SQI+ support for OATC14 10Base-T1S PHYs and Microchip T1S driver Parthiban Veerasooran
2025-11-26 10:49 ` [PATCH net-next v3 1/2] net: phy: phy-c45: add SQI and SQI+ support for OATC14 10Base-T1S PHYs Parthiban Veerasooran
2025-11-28 2:44 ` Jakub Kicinski
2025-11-30 9:13 ` Parthiban.Veerasooran [this message]
2025-11-26 10:49 ` [PATCH net-next v3 2/2] net: phy: microchip_t1s: add SQI support for LAN867x Rev.D0 PHYs Parthiban Veerasooran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe02fb6f-b9f9-4fb1-ba63-893ae18f0376@microchip.com \
--to=parthiban.veerasooran@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®