From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755453AbcHSNw6 (ORCPT ); Fri, 19 Aug 2016 09:52:58 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:42111 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753973AbcHSNw4 (ORCPT ); Fri, 19 Aug 2016 09:52:56 -0400 Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: Don't attempt to enable schedutil governor as module To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org References: <1471612328-6467-1-git-send-email-javier@osg.samsung.com> <1471612328-6467-2-git-send-email-javier@osg.samsung.com> <9c71ddbd-deb1-1e07-7421-53bb58359bad@kernel.org> <7dd6278d-bdc4-14e5-6b2e-062a59cd29d4@osg.samsung.com> Cc: Arnd Bergmann , Olof Johansson , linux-arm-kernel@lists.infradead.org, arm@kernel.org From: Javier Martinez Canillas Message-ID: Date: Fri, 19 Aug 2016 09:52:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <7dd6278d-bdc4-14e5-6b2e-062a59cd29d4@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 08/19/2016 09:46 AM, Javier Martinez Canillas wrote: > > On 08/19/2016 09:40 AM, Krzysztof Kozlowski wrote: >> On 08/19/2016 03:12 PM, Javier Martinez Canillas wrote: >>> The schedutil CPUFreq governor could be built as a module but the commit >>> 58919e83c85c ("cpufreq / sched: Pass flags to cpufreq_update_util()") >>> made it non-modular so attempting to enable as module leads to a warning: >>> >>> warning: symbol value 'm' invalid for CPU_FREQ_GOV_SCHEDUTIL >>> >>> Signed-off-by: Javier Martinez Canillas >>> >>> --- >>> >>> arch/arm/configs/multi_v7_defconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Looks good. >> >> Applied... wait, no, these are not in samsung-soc list so they miss also >> from patchwork. For reference: >> Reviewed-by: Krzysztof Kozlowski >> > > Sigh, get_maintainers.pl suggested me an insanely large cc list so I added > it manually... but I forgot linux-samsung-soc. I'll post v2. > Damn... and now I forgot to include your collected tags in v2. I should not post patches before having enough coffee, sorry about that. Please let me know if you don't mind or if you prefer a resend. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America