From: Guo Samin <samin.guo@starfivetech.com>
To: Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<devicetree@vger.kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
"Conor Dooley" <conor@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Hal Feng <hal.feng@starfivetech.com>
Subject: Re: [-next v1 1/1] riscv: dts: starfive: jh7110: Fix GMAC configuration
Date: Fri, 11 Aug 2023 09:38:23 +0800 [thread overview]
Message-ID: <fe0b5497-93f1-74c6-7e53-e15a62f4692f@starfivetech.com> (raw)
In-Reply-To: <CAJM55Z_AKXa-cKy8kS4-8XPcqgFb4ts2ywhcWwL7Nf3wMBCWJA@mail.gmail.com>
On 2023/8/10 19:28:23, Emil Renner Berthing wrote:
> On Thu, 10 Aug 2023 at 09:46, Samin Guo <samin.guo@starfivetech.com> wrote:
>>
>> Fixed configuration to improve the speed of TCP RX.
>>
>> Before:
>> # iperf3 -s
>> -----------------------------------------------------------
>> Server listening on 5201 (test #1)
>> -----------------------------------------------------------
>> Accepted connection from 192.168.1.4, port 47604
>> [ 5] local 192.168.1.3 port 5201 connected to 192.168.1.4 port 47612
>> [ ID] Interval Transfer Bitrate
>> [ 5] 0.00-1.00 sec 36.3 MBytes 305 Mbits/sec
>> [ 5] 1.00-2.00 sec 35.6 MBytes 299 Mbits/sec
>> [ 5] 2.00-3.00 sec 36.5 MBytes 306 Mbits/sec
>> [ 5] 3.00-4.00 sec 36.5 MBytes 306 Mbits/sec
>> [ 5] 4.00-5.00 sec 35.7 MBytes 300 Mbits/sec
>> [ 5] 5.00-6.00 sec 35.4 MBytes 297 Mbits/sec
>> [ 5] 6.00-7.00 sec 37.1 MBytes 311 Mbits/sec
>> [ 5] 7.00-8.00 sec 35.6 MBytes 298 Mbits/sec
>> [ 5] 8.00-9.00 sec 36.4 MBytes 305 Mbits/sec
>> [ 5] 9.00-10.00 sec 36.3 MBytes 304 Mbits/sec
>> - - - - - - - - - - - - - - - - - - - - - - - - -
>> [ ID] Interval Transfer Bitrate
>> [ 5] 0.00-10.00 sec 361 MBytes 303 Mbits/sec receiver
>>
>> After:
>> # iperf3 -s
>> -----------------------------------------------------------
>> Server listening on 5201 (test #1)
>> -----------------------------------------------------------
>> Accepted connection from 192.168.1.4, port 47710
>> [ 5] local 192.168.1.3 port 5201 connected to 192.168.1.4 port 47720
>> [ ID] Interval Transfer Bitrate
>> [ 5] 0.00-1.00 sec 111 MBytes 932 Mbits/sec
>> [ 5] 1.00-2.00 sec 111 MBytes 934 Mbits/sec
>> [ 5] 2.00-3.00 sec 111 MBytes 934 Mbits/sec
>> [ 5] 3.00-4.00 sec 111 MBytes 934 Mbits/sec
>> [ 5] 4.00-5.00 sec 111 MBytes 934 Mbits/sec
>> [ 5] 5.00-6.00 sec 111 MBytes 935 Mbits/sec
>> [ 5] 6.00-7.00 sec 111 MBytes 934 Mbits/sec
>> [ 5] 7.00-8.00 sec 111 MBytes 935 Mbits/sec
>> [ 5] 8.00-9.00 sec 111 MBytes 934 Mbits/sec
>> [ 5] 9.00-10.00 sec 111 MBytes 934 Mbits/sec
>> [ 5] 10.00-10.00 sec 167 KBytes 933 Mbits/sec
>> - - - - - - - - - - - - - - - - - - - - - - - - -
>> [ ID] Interval Transfer Bitrate
>> [ 5] 0.00-10.00 sec 1.09 GBytes 934 Mbits/sec receiver
>>
>> Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
>> Signed-off-by: Samin Guo <samin.guo@starfivetech.com>
>> ---
>> arch/riscv/boot/dts/starfive/jh7110.dtsi | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> index a608433200e8..76884cf373bf 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> @@ -318,8 +318,8 @@
>>
>> stmmac_axi_setup: stmmac-axi-config {
>> snps,lpi_en;
>> - snps,wr_osr_lmt = <4>;
>> - snps,rd_osr_lmt = <4>;
>> + snps,wr_osr_lmt = <0xf>;
>> + snps,rd_osr_lmt = <0xf>;
>
> nit: this is a limit, so presumably counting things and not an address
> or bitmask, so I'd prefer decimal numbers here, eg <15>.
>
> It works fine either way, so
> Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
Thanks Esmil, that's right.
I refer to examples of snps,dwmac.yaml, so I use 0xf...
Best regards,
Samin
>
>> snps,blen = <256 128 64 32 0 0 0>;
>> };
>>
>> @@ -839,7 +839,7 @@
>> rx-fifo-depth = <2048>;
>> tx-fifo-depth = <2048>;
>> snps,multicast-filter-bins = <64>;
>> - snps,perfect-filter-entries = <8>;
>> + snps,perfect-filter-entries = <256>;
>> snps,fixed-burst;
>> snps,no-pbl-x8;
>> snps,force_thresh_dma_mode;
>> @@ -870,7 +870,7 @@
>> rx-fifo-depth = <2048>;
>> tx-fifo-depth = <2048>;
>> snps,multicast-filter-bins = <64>;
>> - snps,perfect-filter-entries = <8>;
>> + snps,perfect-filter-entries = <256>;
>> snps,fixed-burst;
>> snps,no-pbl-x8;
>> snps,force_thresh_dma_mode;
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2023-08-11 1:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 7:46 [-next v1 0/1] Fix StarFive JH7110 gmac TCP RX speed issue Samin Guo
2023-08-10 7:46 ` [-next v1 1/1] riscv: dts: starfive: jh7110: Fix GMAC configuration Samin Guo
2023-08-10 10:48 ` Conor Dooley
2023-08-10 10:54 ` Guo Samin
2023-08-10 11:28 ` Emil Renner Berthing
2023-08-11 1:38 ` Guo Samin [this message]
2023-08-10 15:37 ` [-next v1 0/1] Fix StarFive JH7110 gmac TCP RX speed issue Conor Dooley
2023-08-11 1:42 ` Guo Samin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe0b5497-93f1-74c6-7e53-e15a62f4692f@starfivetech.com \
--to=samin.guo@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®