From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819B2C433DF for ; Wed, 8 Jul 2020 12:00:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 535BE2065C for ; Wed, 8 Jul 2020 12:00:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iZ+Kbz4u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728759AbgGHMA4 (ORCPT ); Wed, 8 Jul 2020 08:00:56 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:60129 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728770AbgGHMAz (ORCPT ); Wed, 8 Jul 2020 08:00:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594209654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hmKCNmXWHhIbbQdWVp5s2pqNmp2UrKc3xUPz10fSo04=; b=iZ+Kbz4ua+EUZocUzuoCWBdFpszHp6e6lP+lZuNM/UlEvhIwxHfeJp21UyapfW0UEECeCJ xndJzRboovZsRY+yoSdirCnAZQhcdJVwFDDZpDoyweg9iie3xHrk9fy7aHaUtkMR3dpdzz XSBqYyJSENXfdM0sqFmFHzdl06EhW8w= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-307-BbC1tbxpPTuwlOuJe9zjwQ-1; Wed, 08 Jul 2020 08:00:53 -0400 X-MC-Unique: BbC1tbxpPTuwlOuJe9zjwQ-1 Received: by mail-wr1-f72.google.com with SMTP id 89so28290581wrr.15 for ; Wed, 08 Jul 2020 05:00:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hmKCNmXWHhIbbQdWVp5s2pqNmp2UrKc3xUPz10fSo04=; b=pgTf8MEWQApCUKjYWtS25cLwBiWSRhpBPLFYmbP9VumLxZjoWH1VC+gz76POWNdthf 9zlQgYkvpObWDpIvo0TVUfDFZyaKzoPLUasGzjkV2BWHiBZ7dUjI0IP0sWHTQkhn+iKJ Be5WnyFB4RzyJ6tCkYar2oJl0Cozhp9E5BGbHtdYa9Md2XhVWD+/kUJ90xThBn5KChgA jVCrN4pghA9JQndzjnkDCPirv+DZ9lJbs/f1hUbgR2xm1GTYkj7lhTaQqNpzef5L1lku 9WcX2eFxDIU9/mepjHE7shkY+q/ucIK+mRYwDD4tua7er/vn4JTPSvsSYNyodh4D0aCa N6Gg== X-Gm-Message-State: AOAM533pTbktJjkFYhw918gJF6kNVr62WJjDhb67WDDr39fsz8HKSAjG nToY0ADYxbhCzPRAe5kk259a7HwB6oG/UOMg5QR2pmAbtExtBt+xm2gPmngdPo1coq88pFK+bZM Dgvj8ymiPdmx/jouitu7vo7we X-Received: by 2002:a7b:c116:: with SMTP id w22mr8656734wmi.97.1594209652195; Wed, 08 Jul 2020 05:00:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgDZMDB93ZlhsJ1XHsTJ4kZPxli+b1em/HHGjRGIBMn+xiyVQ/u5J5G/Zj7RI/Q8hS/gq2xQ== X-Received: by 2002:a7b:c116:: with SMTP id w22mr8656716wmi.97.1594209651993; Wed, 08 Jul 2020 05:00:51 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9541:9439:cb0f:89c? ([2001:b07:6468:f312:9541:9439:cb0f:89c]) by smtp.gmail.com with ESMTPSA id k126sm6226407wme.17.2020.07.08.05.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 05:00:51 -0700 (PDT) Subject: Re: [PATCH v3 1/8] KVM: X86: Reset vcpu->arch.cpuid_nent to 0 if SET_CPUID* fails To: Xiaoyao Li , Sean Christopherson , Jim Mattson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel References: <20200708065054.19713-1-xiaoyao.li@intel.com> <20200708065054.19713-2-xiaoyao.li@intel.com> From: Paolo Bonzini Message-ID: Date: Wed, 8 Jul 2020 14:00:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200708065054.19713-2-xiaoyao.li@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/20 08:50, Xiaoyao Li wrote: > +Note, when this IOCTL fails, KVM gives no guarantees that previous valid CPUID > +configuration (if there is) is not corrupted. Userspace can get a copy of valid > +CPUID configuration through KVM_GET_CPUID2 in case. > + > :: I assume you mean "of the resulting CPUID configuration". Paolo