From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D95B41428F for ; Mon, 15 Jan 2024 12:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QubxQ2GF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705322475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RN4+60YEcn4PqEDlBqzvGVSUMG+gaLHq8yCyKiNki8Q=; b=QubxQ2GFrgGzic+um9kMNOAXvjnyLFE9rRcASzRQlOKoB8Ye8GHpVx5hP9OvLrtPl15NQq pnjMjWUE+P8eHACggmMvANd6XUvdgXU2Fe6D6yOLtEx62CrgqFGPGigL5CfU9VS/toSAtF hvbLmGEII32Odzdg2wHUA+YaOEtyc2I= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-QWups78xN4StVxT5lG3h9Q-1; Mon, 15 Jan 2024 07:41:13 -0500 X-MC-Unique: QWups78xN4StVxT5lG3h9Q-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ccb53bc5ceso61262151fa.3 for ; Mon, 15 Jan 2024 04:41:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705322472; x=1705927272; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RN4+60YEcn4PqEDlBqzvGVSUMG+gaLHq8yCyKiNki8Q=; b=ZrHDir72P1lHLDUvn6h53JHtJJA8WG8yFEkytBRNE0T4YGxBI16Udsy9xMLcMiWklQ WP9+sA1FpLqXcjacEXdCqmYoQIg/M8ndQuwss6rlwxc4lAK3GHvAyvWEW43R51mHzvNh HmbIo5Wiqr376iA6gnpYljJo5C7KfgNEx4cWwJWQYQ+mZMeoGD0+xZ+sITJf1AYWIN0E bE//22JQLnmOLoowicKn1OhXiCbFBXchV3vh72nVqDfPEgnUGpsWhAP2y7fx0k9I3qiZ irt59i5djtTILclaO/ouyz+6CHH5D0hxJfDeh1zvrR5VJn4e0N9V3GgWiKOyj+RPC3UV BJUg== X-Gm-Message-State: AOJu0Yz2a/wCiPjTZw6z+Z04ZiqDSobwfl6mJ5KHWOSxH6YoeHYLJSPH avwtQQ4Mz271fWayhhRzQIEkQ/XdQfEWN/44+Imuc6LU0qOtVx4wBBV4yt7MNA5w2aAVP4R0fmA 5lvbYaz/CKw4VQno6AuFiv8RKemQ7B1M/ X-Received: by 2002:a05:651c:2db:b0:2cd:a311:6aec with SMTP id f27-20020a05651c02db00b002cda3116aecmr1663452ljo.21.1705322472111; Mon, 15 Jan 2024 04:41:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFh6MV8S/jx25nu+KhW6rqjE6D8TB8SMynj16U5CkhQTGS1xGRgDM7SBJi6joRz0znwNa158w== X-Received: by 2002:a05:651c:2db:b0:2cd:a311:6aec with SMTP id f27-20020a05651c02db00b002cda3116aecmr1663446ljo.21.1705322471809; Mon, 15 Jan 2024 04:41:11 -0800 (PST) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id n7-20020a056402434700b0055915dc8e74sm2574816edc.81.2024.01.15.04.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jan 2024 04:41:11 -0800 (PST) Message-ID: Date: Mon, 15 Jan 2024 13:41:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform/x86: intel-wmi-sbl-fw-update: Fix function name in error message Content-Language: en-US To: Armin Wolf , jithu.joseph@intel.com Cc: ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240106224126.13803-1-W_Armin@gmx.de> From: Hans de Goede In-Reply-To: <20240106224126.13803-1-W_Armin@gmx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 1/6/24 23:41, Armin Wolf wrote: > Since when the driver was converted to use the bus-based WMI > interface, the old GUID-based WMI functions are not used anymore. > Update the error message to avoid confusing users. > > Compile-tested only. > > Fixes: 75c487fcb69c ("platform/x86: intel-wmi-sbl-fw-update: Use bus-based WMI interface") > Signed-off-by: Armin Wolf Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/x86/intel/wmi/sbl-fw-update.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel/wmi/sbl-fw-update.c b/drivers/platform/x86/intel/wmi/sbl-fw-update.c > index 9cf5ed0f8dc2..040153ad67c1 100644 > --- a/drivers/platform/x86/intel/wmi/sbl-fw-update.c > +++ b/drivers/platform/x86/intel/wmi/sbl-fw-update.c > @@ -32,7 +32,7 @@ static int get_fwu_request(struct device *dev, u32 *out) > return -ENODEV; > > if (obj->type != ACPI_TYPE_INTEGER) { > - dev_warn(dev, "wmi_query_block returned invalid value\n"); > + dev_warn(dev, "wmidev_block_query returned invalid value\n"); > kfree(obj); > return -EINVAL; > } > @@ -55,7 +55,7 @@ static int set_fwu_request(struct device *dev, u32 in) > > status = wmidev_block_set(to_wmi_device(dev), 0, &input); > if (ACPI_FAILURE(status)) { > - dev_err(dev, "wmi_set_block failed\n"); > + dev_err(dev, "wmidev_block_set failed\n"); > return -ENODEV; > } > > -- > 2.39.2 >