From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932336AbcJLLMQ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 12 Oct 2016 07:12:16 -0400
Received: from foss.arm.com ([217.140.101.70]:57700 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932575AbcJLLMI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 12 Oct 2016 07:12:08 -0400
Subject: Re: [PATCH 1/7 v4] sched: factorize attach entity
To: Vincent Guittot <vincent.guittot@linaro.org>
References: <1474892393-5095-1-git-send-email-vincent.guittot@linaro.org>
 <1474892393-5095-2-git-send-email-vincent.guittot@linaro.org>
 <0bc8d5b8-9ba9-c4b5-4109-20aa6f1a3497@arm.com>
 <CAKfTPtC64kRtARyVmUiQzHHz3Ci36htC6kHNS1YD5o5mascoWg@mail.gmail.com>
 <CAKfTPtCh4Hrb5rVVdfS2G29imHkYLwyRCHc6n-8h_pkO3gUuVg@mail.gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Wanpeng Li <kernellwp@gmail.com>, Yuyang Du <yuyang.du@intel.com>,
        Morten Rasmussen <Morten.Rasmussen@arm.com>,
        Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
        Paul Turner <pjt@google.com>, Benjamin Segall <bsegall@google.com>
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <fe0f79fa-9e94-b153-4c20-bccf087bd001@arm.com>
Date: Wed, 12 Oct 2016 12:12:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAKfTPtCh4Hrb5rVVdfS2G29imHkYLwyRCHc6n-8h_pkO3gUuVg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/10/16 11:59, Vincent Guittot wrote:
> On 7 October 2016 at 01:11, Vincent Guittot <vincent.guittot@linaro.org> wrote:
>>
>> On 5 October 2016 at 11:38, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>>> On 09/26/2016 01:19 PM, Vincent Guittot wrote:

[...]

>>>> -static void attach_task_cfs_rq(struct task_struct *p)
>>>> +static void attach_entity_cfs_rq(struct sched_entity *se)
>>>>  {
>>>> -     struct sched_entity *se = &p->se;
>>>>       struct cfs_rq *cfs_rq = cfs_rq_of(se);
>>>
>>>
>>> Both callers of attach_entity_cfs_rq() already use cfs_rq_of(se). You
>>> could pass it into attach_entity_cfs_rq().
>>
>> Yes that would make sense
> 
> In fact there is a 3rd caller online_fair_sched_group which calls
> attach_entity_cfs_rq and doesn't already use  cfs_rq_of(se) so i
> wonder if it's worth doing the interface change.

OK, this change gets in w/ patch 6/7. Yeah, skip it, it's not so important.