From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED82B347FD1 for ; Mon, 16 Mar 2026 10:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773655688; cv=none; b=Ed3VfbSwOzOhMG0K1QvKcNJL2RouO9ZnuOt9MuDzEQJwZ2ILbj7ZOxHMKEBiQ+N3V9IHLCUZ9Xh1DbKrW3sFncok01wMbjZG5C8VJ1ikzMTBzpW47jVADfuZ9G4p0i93Pf5T6fbrBfHUfv8mEbVuqZuObp2I1ZTVF6DpPZwqM5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773655688; c=relaxed/simple; bh=udC/GqyllmqetDayCChsqG/dwbY35kRsxF+Hq6XzcB4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=elJMTusiIL/tOnvValtzE4Q/KolyzWdm8epfRpI3IOOF0HtKaeSr2QUN0v4k05GnK+UTMchrOp+7M7DvalHvXdTtPvCZyQpo8LKz8URz+IE0/ydrBFozCReuDk2WzCs9Zk/5K95HfMK8jSWlee55XjZUo6sKgOptdfRci0pCXpg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NDh2WZx/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IsYPscjG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NDh2WZx/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IsYPscjG" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G64hYa1724707 for ; Mon, 16 Mar 2026 10:08:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jCKxTdgkdhUfhMWVS3bqu1wMEwzKvP/Qe5TgTlQaWwI=; b=NDh2WZx/rg9oCG3+ rKpsQ9IW5iKg3abY7aAEIGITLM0KxtNekaJQVZz2ueZUyGBfNTaj0KSme3ZBLXkv asbB/C8OMNZD/zYenZLU26hULxRUQErIb0MZQ4KZ4RokZ4OFx31KISOJrmxy7w9d 5eawRa0ZpdhJzV9JGifJhVXfm7RhqorehiG7mbSbBlycAASZUa0pdS98GU5QOurC +kIROciR7fgvKUDSJBQ1QEPwzJdS3/sT515te7IxXBqXyAEd9HncdNQ1VbRktmmJ TTT6BZ7fexIhtNVV/1j9uz2XvGQUy2KElp1INJCT8QVPgMef7oWYOfZpIrv7c/HE AsGJRg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cw0udn2mv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 10:08:05 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb485c686cso279819285a.1 for ; Mon, 16 Mar 2026 03:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773655684; x=1774260484; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jCKxTdgkdhUfhMWVS3bqu1wMEwzKvP/Qe5TgTlQaWwI=; b=IsYPscjGlO5hQ5TLMbEvT1lgao64CGXjuswV0hRVDqzWTtCgpIioDjlDzUFHA3iRW7 FFebZTi6S9HfFX/qdhhwgumVMDtnwizDvw8mJy5G1Mh+4XHk6UVGV3mwb4l/Kj1oKBWy 5AZL80GFwaRbqR13fyLUIo12Wkye35uYO8bxXVgVPx9R7b6a22rTq/3xKlJ61FFSeQO0 MAa6WWu9Man4RLmZ4LiRf8UrXM69Rb4yLihV57ruLmupN/hr2zxOCPa9yWwDFK6xCxqh RFrGZQpBdO+0DGbePOOZnW8n+gxCLZkDZ0bM/xLXz205k4WqYFjKUxjANllvcbxXTkUj ddPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773655684; x=1774260484; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jCKxTdgkdhUfhMWVS3bqu1wMEwzKvP/Qe5TgTlQaWwI=; b=Iu8Oltj1AclVLqxZGVTh4mJSPVDcTuj61y5hBY4/CRl/XX1T8FDluuSCzOIsDi8JR7 8NUSwB2nmAImvejnASXD4dLZkHbFa6vlllA3eC+ZfkBEnNIxI3xttRw7kLgNpz/zPoWN 1H2Z6b3FFqYIfQy76uHY5peSekJSi9hklIibLmMb9N0S8MLl28pBWOCJKYlRXAe79Yy0 CPe7Ue6X52AACitwbU7iKXRu3JD0T/u36cg4oeToQwDO03//GPmszNu3zP6iw7nVjVo8 f6OY5S/B/FIOjBLWKgw7U0rRNrn0aCt+he13RVLG3tAHCtdEwvqSeLFtrslLWmO/4+tz HG9A== X-Forwarded-Encrypted: i=1; AJvYcCWS0IlzuX6mcmuVYsOy+zuYq65NcBGSGrRTt9mwrGmRd6D9JGC7I2lq80I5dZ08RSecW9D1twp9ghkv/AA=@vger.kernel.org X-Gm-Message-State: AOJu0YyhQXmo7dNiv52DtcyobETIoZe++wYYn2BOdVRQwxKUFBexqfpy npx0JqLHlzZgihaxaLSevz4v/EL2J6LbPzJmUqznmVTbo0NHYDOXJZHOIaC9MF9ck4zE5WtnpYN vKkZ+ZDtyilrqcubTx3uzWSN3zcWsg9FobOnmfHnggog99+7524kBYCnOjo+g8Pmvmt0= X-Gm-Gg: ATEYQzwTea5ks8uAhHsFkYmi+Plol+B8tkE9V4RgRDYkksgHC3t7z7CXwytXtVPYPsu qz6TF8iz7P8tprLAdpL+Ve2/sUeigXS5aW6bv0Zkhl6b3K7sajkXs8sSzXf0mY4gf9Wd1o8TAkU i3U1XDcv7cXhrX1q/vRPudDt8dNsmkR+GzW+mhZSgkYekS8qjdPF/eXiuuENTKPDUf+eqrE0tQ0 ZMD9D0d/d7WqNclujEB4Q7eysE3grhcpj7v59rjwPVbZfQ2VgZ5GLEjj8BANL9/7dvdHMSHnrcQ eb9GHJpPgS7d02f712+j2YvVf369mdYoyn/s43DBHEyQqCUxvzA8c+f0NUPvnKNye4lr6Fpz2fe yoplp86kBxolwMsP3GbkXU9thNpYIBJ5lwavwUG6zHc0lKJ7ebIeitKXkxd8KrmulVEWskXghu+ vbOtI= X-Received: by 2002:a05:620a:290e:b0:8c9:eee0:dba6 with SMTP id af79cd13be357-8cdb5b7617bmr1240590485a.7.1773655684324; Mon, 16 Mar 2026 03:08:04 -0700 (PDT) X-Received: by 2002:a05:620a:290e:b0:8c9:eee0:dba6 with SMTP id af79cd13be357-8cdb5b7617bmr1240587685a.7.1773655683933; Mon, 16 Mar 2026 03:08:03 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97cb0d2df2sm49348266b.54.2026.03.16.03.08.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:08:03 -0700 (PDT) Message-ID: Date: Mon, 16 Mar 2026 11:08:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 17/27] drm/msm/mdss: use new helper to set amsbc To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> <20260312-ubwc-rework-v3-17-b7e8f800176a@oss.qualcomm.com> <19b36a86-12c7-4710-8f80-5e27c9c00e3c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=BJ2+bVQG c=1 sm=1 tr=0 ts=69b7d685 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=Nnq6w86PQWoF-9HhF-wA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: u9PNvZ_tW6uibzq3u03cE5a2Wxh4U8oI X-Proofpoint-ORIG-GUID: u9PNvZ_tW6uibzq3u03cE5a2Wxh4U8oI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA3NyBTYWx0ZWRfXx2HdVcS47T/t 5O3KI2KneUJcyed26QYIqB75dFIH/53S77pbyNsgaQk0Nd7e7H0HBtzKp/QmI9h4SF1WiyWG9nr qXaeNnQ65WAiO0yLAcB8qT/sQvkeUrfU0LADZm+sbpkJVFkNBX5VsK+vrPoUo+x++NnM8zUGQvx VlK0Zc5temlXrRuo/LCHUUPxvpXy/XRYFH9VpMQefNHLx+gzfZYiSioviUvVFp05KBz2RBPmeow ASkzR6QGfHD57+cspGk8XMDRe2jwA4IgC6YinxP0ZerNNF3Y2Hjd7tbg2JsZedfFPQR3GlLISIK 84Zbuf7lZD3lsrm/eEgvBDpCogQF3j3WUV3qVCgU4pVLJympbbzEbKt9JHHYcywK7Zptd4KvXL7 k7iLE2Faf+w3+SxrbZ2E+YCAxmXz0L6VkaKL26llQVv2hy/4eKssf9MwEikxnhMHNuBwCnQ6qSF Zzf03p7Z3tMbHSjet+A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160077 On 3/13/26 3:26 PM, Dmitry Baryshkov wrote: > On Fri, Mar 13, 2026 at 11:19:59AM +0100, Konrad Dybcio wrote: >> On 3/12/26 2:29 PM, Dmitry Baryshkov wrote: >>> Use freshly defined helper instead of checking the UBWC version >>> directly. >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> drivers/gpu/drm/msm/msm_mdss.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c >>> index ca59bcdde7b2..04efc29f38cd 100644 >>> --- a/drivers/gpu/drm/msm/msm_mdss.c >>> +++ b/drivers/gpu/drm/msm/msm_mdss.c >>> @@ -188,7 +188,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) >>> if (qcom_ubwc_macrotile_mode(data)) >>> value |= MDSS_UBWC_STATIC_MACROTILE_MODE; >>> >>> - if (data->ubwc_enc_version == UBWC_3_0) >>> + if (qcom_ubwc_enable_amsbc(data)) >>> value |= MDSS_UBWC_STATIC_UBWC_AMSBC; >> >> I know it's already there, but fwiw downstream doesn't seem to be >> concerned with toggling AMSBC in MDSS (perhaps incorrectly?) > > Downstream enables it only for the cases where encoder and decoder > use exactly UBWC 3.0. This is not completely correct as the bit doesn't > exist for MDSS 6.x+. For 5.x this is equivalent to the code from the > patch: enable AMSBC if targeting UBWC >= 3.0 (because MDSS 5.x don't > support UBWC 4.0 or higher). Right, this seems to indeed be the case While trying to confirm that, I noticed that some lower-end MDSS 5.x chips (like Talos) report UBWC3 in the register, but the MDSS docs say they're UBWC2 - any idea? Konrad