From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Linux Documentation <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Outreachy <outreachy@lists.linux.dev>
Cc: Jonathan Corbet <corbet@lwn.net>,
Thorsten Leemhuis <linux@leemhuis.info>,
Greg KH <gregkh@linuxfoundation.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Akira Yokosawa <akiyks@gmail.com>,
Alison Schofield <alison.schofield@intel.com>,
Kloudifold <cloudifold.3125@gmail.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH] Documentation: submitting-patches: Disqualify style fixes from Fixes: tag
Date: Thu, 16 Mar 2023 09:23:28 +0100 [thread overview]
Message-ID: <fe15da9c-d03f-ccc3-ea6a-2b6401496aad@linaro.org> (raw)
In-Reply-To: <20230316082034.14191-1-bagasdotme@gmail.com>
On 16/03/2023 09:20, Bagas Sanjaya wrote:
> An interpretation of submitting-patches.rst regarding Fixes: tag
> interprets that the tag can be attributed to all kinds of issues
> (including coding style ones). However, from the discussion on Outreachy
> mailing list [1], Greg noted that the tag should not be meant for
> patches that fix coding style issues.
>
> Clarify the position on the doc.
>
> Link: https://lore.kernel.org/outreachy/ZBFPnZbvdI46Ah6r@kroah.com/ [1]
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> Documentation/process/submitting-patches.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 69ce64e03c70f8..564418e42ffc01 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -568,6 +568,9 @@ process nor the requirement to Cc: stable@vger.kernel.org on all stable
> patch candidates. For more information, please read
> Documentation/process/stable-kernel-rules.rst.
>
> +Note: Fixes: tag is appropriate only for real issues (e.g. reported bugs
> +or compiler warnings). Coding style fixes should not bear this tag.
I think it is pretty clear already. The doc says:
"If your patch fixes a bug in a specific commit,"
and you are now repeating this.
Coding style is not a bug, but that's obvious.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-16 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 8:20 Bagas Sanjaya
2023-03-16 8:23 ` Krzysztof Kozlowski [this message]
2023-03-16 8:26 ` Greg KH
2023-03-16 14:55 ` Theodore Ts'o
2023-03-16 15:01 ` Jonathan Corbet
2023-03-17 7:53 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe15da9c-d03f-ccc3-ea6a-2b6401496aad@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=akiyks@gmail.com \
--cc=alison.schofield@intel.com \
--cc=bagasdotme@gmail.com \
--cc=cloudifold.3125@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=lukas.bulwahn@gmail.com \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®