Re: [PATCH v12 0/6] Merge redmi-wmi into bitland-mifs-wmi

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Mon, 12 Oct 2026, Mingyou Chen wrote:

> This patch series consolidates the standalone 'redmi-wmi' driver into the
> 'bitland-mifs-wmi' driver to eliminate code duplication and centralize
> the maintenance of overlapping ACPI WMI event streams.
> 
> Bitland is the ODM manufacturer for various Xiaomi Redmibook models. Both
> platforms share the exact same keyboard event stream WMI GUID
> (46C93E13-EE9B-4262-8488-563BCA757FEF). While redmi-wmi previously parsed
> the 4-byte payload as a bulk u32 scancode, bitland-mifs-wmi deconstructed
> it into discrete type/id/value fields.
> 
> Redmi operations were not contained in this patch series, future reverse
> engineering is required.
> 
> This series introduce a newly reported mic-mute hotkey definition
> for Redmibooks
> and dropped the previous redmi-wmi driver.
> 
> I don't have a Redmi or other Bitland device. So I cannot work on the
> real device.
> 
> Features are working properly on my device (Lecoo Bellator N176).
> 
> I leave the future reverse engineering work to the community.
> 
> And by the way, the no_set member in bitland_profile_entry means a
> platform profile is only report by the firmware but not available for
> set.
> 
> I don't have any LLM API credits (and I don't want to order it for now),
> so I cannot run sashiko reviews. Could you share the other review comments
> to me?

Hi,

You can find the public sashiko instance comments from here:
  https://sashiko.dev

There still seems to be some valid concerns remaining.

As it's AI tool, the reviews do not always find same issues on every 
run so it's sometimes worth to take a look at the previous version 
comments if there are additional findings there.

--
 i.

> v12:
> Fix the issues mentioned in https://lore.kernel.org/all/20261008152647.1510152-1-uselessfire@gmail.com/ .
> Copy payload_data to output->data at bitland_mifs_wmi_call, not
> overwrite the entire struct.
> Correct the key name (Mic Mute) in the commit message of
> "platform/x86: bitland-mifs-wmi: Add Redmi mic-mute key entries"
> and my device doesn't have a FN-ESC key, so I renamed the enum variant to
> WMI_EVENT_MIC_MUTE.
> 
> v11:
> Add missing return_code_at_end and accept_zero_function logic
> Fallback to balanced platform profile if resume to performance failed
> 
> v10:
> Replace the previous "profile table" with dmi quirk table
> 
> v9:
> Add the missing feature introduced in the commit
> e0d6312578e1 ("platform/x86: redmi-wmi: report EC state change events").
> 
> v8:
> Correct Ilya Gladyshev's email address in the MAINTAINERS entry
> 
> v7:
> Swap low bit and high bit for WMI_EVENT_KBD_BRIGHTNESS
> in bitland_mifs_wmi_keymap
> 0x00800501 -> BI_HOTKEY_CODE(WMI_EVENT_KBD_BRIGHTNESS, 0x80, 0),
> 
> Report KEY_FN_ESC when WMI_EVENT_FNLOCK_STATE events received
> Rename the reserved names
> Use Xmas tree order in bitland_mifs_wmi_notify
> Collect the Tested-by and Reviewed-by tags
> 
> v6:
> Drop the wrong Redmi ops
> 
> v5:
> Correct Xiaomi DMI vendor name
> 
> v4:
> Map PLATFORM_PROFILE_PERFORMANCE to wmi performance mode if the device
> doesn't support full-speed mode.
> 
> 
> 
> Mingyou Chen (6):
>   MAINTAINERS: Add maintainer entry of bitland-mifs-wmi driver
>   platform/x86: bitland-mifs-wmi: Merge the function of redmi-wmi into
>     the bitland driver
>   platform/x86: bitland-mifs-wmi: Add Redmi mic-mute key entries
>   platform/x86: redmi-wmi: Drop redmi-wmi driver
>   platform/x86: bitland-mifs-wmi: Add quirks table
>   platform/x86: bitland-mifs-wmi: Fallback to balanced platform profile
>     if last performance profile is not available
> 
>  MAINTAINERS                             |   7 +-
>  drivers/platform/x86/Kconfig            |  12 -
>  drivers/platform/x86/Makefile           |   1 -
>  drivers/platform/x86/bitland-mifs-wmi.c | 345 ++++++++++++++++--------
>  drivers/platform/x86/redmi-wmi.c        | 154 -----------
>  5 files changed, 243 insertions(+), 276 deletions(-)
>  delete mode 100644 drivers/platform/x86/redmi-wmi.c
> 
> 
> base-commit: 98f039265e580291d5e76a11b2072541fbb1c393
> 

-- 
 i.