From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 650983845C1 for ; Wed, 24 Jun 2026 06:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782281335; cv=none; b=qFGKfFUc8U+7o+wNewGLI22SHEHiWbzl5bFrJwgNjDwUUs3ri8WML4wGaXcQVXeNQmThhXIY7+CCCriYAj7HubQkSQMEp1TIetc3hmSnhsHqAiMqJ/+x3uIHsm6/XYGP9gOB+I9APK1AipVfSBnMdiKFuUZVsygVYpk+2eg66Bo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782281335; c=relaxed/simple; bh=vNIxTT2dokgiFqInHnkhxTg8GSWXUULZ2W+p4tc7g5g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RLrYXioMCxxbVEVTEZUYV+zdSdNRZktYz9p8vB55DnkRRuxsxneCpkJLxj44g8NtjlWHWHgkXI7hV3E6VCdhGICFHomC9UL0hA78LoNZbzZLimnDKKWPyVLoIJkBO4TlLaIzin0gt7yp0xFzRZao3W9v76/gxUt0IpdBbkgpzJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=N2IEmFPE; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=IbboR6HT; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=N2IEmFPE; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=IbboR6HT; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="N2IEmFPE"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="IbboR6HT"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="N2IEmFPE"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="IbboR6HT" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 98B7076058; Wed, 24 Jun 2026 06:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782281332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tHGwT/QNlB7zFDQrS8ACYcuXfc0IQFO36pBFG5f00kQ=; b=N2IEmFPEaXpsNcbiusQcId1si9JU03vSUTKTQVz/9cd2Pgeg2/ygI8izcDsq74PTA/9d3m JWfmg9yZoYl+l584PFh0kn6NedpuZVGdjUgGc9ZXBwKWxwxIdg4jRv8FHSuOuYIVGK6TGC lkzjGDHq9uf/+94K3v/p9EPYFFT8wlU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782281332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tHGwT/QNlB7zFDQrS8ACYcuXfc0IQFO36pBFG5f00kQ=; b=IbboR6HTjMWvF62/6BBTgO9iwOqCbHdAhKyRdj965kR3dMgVDigbIgaLD0eWPmCntJJZHL VDp/atvOy2VtUOCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=N2IEmFPE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IbboR6HT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782281332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tHGwT/QNlB7zFDQrS8ACYcuXfc0IQFO36pBFG5f00kQ=; b=N2IEmFPEaXpsNcbiusQcId1si9JU03vSUTKTQVz/9cd2Pgeg2/ygI8izcDsq74PTA/9d3m JWfmg9yZoYl+l584PFh0kn6NedpuZVGdjUgGc9ZXBwKWxwxIdg4jRv8FHSuOuYIVGK6TGC lkzjGDHq9uf/+94K3v/p9EPYFFT8wlU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782281332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tHGwT/QNlB7zFDQrS8ACYcuXfc0IQFO36pBFG5f00kQ=; b=IbboR6HTjMWvF62/6BBTgO9iwOqCbHdAhKyRdj965kR3dMgVDigbIgaLD0eWPmCntJJZHL VDp/atvOy2VtUOCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 55684779A8; Wed, 24 Jun 2026 06:08:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1jBcE3R0O2qBRwAAD6G6ig (envelope-from ); Wed, 24 Jun 2026 06:08:52 +0000 Message-ID: Date: Wed, 24 Jun 2026 08:08:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] x86/video: Only fall back to vga_default_device() without screen info To: Mario Limonciello , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:PCI SUBSYSTEM" , Aaron Ma References: <20260623141505.1816786-1-mario.limonciello@amd.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260623141505.1816786-1-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 98B7076058 X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.com:url,canonical.com:email,suse.de:dkim,suse.de:email,suse.de:mid]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Hi Am 23.06.26 um 16:15 schrieb Mario Limonciello: > Some multi GPU systems may have a VGA compatible device, but that might > not be used for display. If due to enumeration order this device is > found before the one actually used for display then multiple devices > may show the boot_display attribute, confusing userspace. > > When screen info is valid, use it exclusively to find the primary > device so that only the device backing the framebuffer is reported. > Only when no framebuffer has been set up does it make sense to fall > back to the default VGA device. This ensures at most one primary > graphics device, preferably the one with the framebuffer. > > Suggested-by: Thomas Zimmermann > Fixes: ad90860bd10ee ("fbcon: Use screen info to find primary device") > Reported-by: Aaron Ma > Closes: https://lore.kernel.org/linux-pci/20260618081803.2790848-1-aaron.ma@canonical.com/#t > Signed-off-by: Mario Limonciello Reviewed-by: Thomas Zimmermann This looks good. Thanks for fixing this issue. Best regards Thomas > --- > v1->v2: > * Fix subject > * Keep vga_default_device() as fallback instead of remove all > together > arch/x86/video/video-common.c | 23 ++++++++++++++--------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/arch/x86/video/video-common.c b/arch/x86/video/video-common.c > index 152789f00fcda..8ed82fff7638e 100644 > --- a/arch/x86/video/video-common.c > +++ b/arch/x86/video/video-common.c > @@ -43,21 +43,26 @@ bool video_is_primary_device(struct device *dev) > if (!pci_is_display(pdev)) > return false; > > - if (pdev == vga_default_device()) > - return true; > - > #ifdef CONFIG_SCREEN_INFO > numres = screen_info_resources(si, res, ARRAY_SIZE(res)); > - for (i = 0; i < numres; ++i) { > - if (!(res[i].flags & IORESOURCE_MEM)) > - continue; > + if (numres > 0) { > + for (i = 0; i < numres; ++i) { > + if (!(res[i].flags & IORESOURCE_MEM)) > + continue; > + > + if (pci_find_resource(pdev, &res[i])) > + return true; > + } > > - if (pci_find_resource(pdev, &res[i])) > - return true; > + return false; > } > #endif > > - return false; > + /* > + * No framebuffer was set up by the firmware/bootloader, so fall back > + * to the default VGA device. > + */ > + return pdev == vga_default_device(); > } > EXPORT_SYMBOL(video_is_primary_device); > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)