mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Sven Peter <sven@svenpeter.dev>, Janne Grunau <j@jannau.net>,
	Hector Martin <marcan@marcan.st>
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/io-pgtable: Make IOMMU_IO_PGTABLE_DART invisible
Date: Tue, 27 Sep 2022 15:15:06 +0100	[thread overview]
Message-ID: <fe2b1f48-e18a-b1d9-0c62-ddddf9e6515f@arm.com> (raw)
In-Reply-To: <b0981cb5a97452af73b9dd0dd0eb03c5002f7af4.1664285626.git.geert+renesas@glider.be>

On 2022-09-27 14:36, Geert Uytterhoeven wrote:
> There is no point in asking the user about both "Apple DART Formats" and
> "Apple DART IOMMU Support", as the former is useless without the latter,
> and the latter auto-selects the former.
> 
> Fixes: 745ef1092bcfcf3b ("iommu/io-pgtable: Move Apple DART support to its own file")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Should IOMMU_IO_PGTABLE_LPAE and IOMMU_IO_PGTABLE_ARMV7S be made
> invisible, too?
> Are there users that do not select them?

The aim was for formats to be independently selectable for COMPILE_TEST 
coverage. The Arm formats are manually selectable for the sake of their 
runtime self-tests, which are self-contained, but since DART format 
doesn't do anything by itself I'd agree there's no need to prompt when 
!COMPILE_TEST here.

Thanks,
Robin.

> ---
>   drivers/iommu/Kconfig | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index dc5f7a156ff5ec73..f1affca6022e0a54 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -68,16 +68,13 @@ config IOMMU_IO_PGTABLE_ARMV7S_SELFTEST
>   	  If unsure, say N here.
>   
>   config IOMMU_IO_PGTABLE_DART
> -	bool "Apple DART Formats"
> +	bool
>   	select IOMMU_IO_PGTABLE
> -	depends on ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64)
>   	help
>   	  Enable support for the Apple DART pagetable formats. These include
>   	  the t8020 and t6000/t8110 DART formats used in Apple M1/M2 family
>   	  SoCs.
>   
> -	  If unsure, say N here.
> -
>   endmenu
>   
>   config IOMMU_DEBUGFS

  reply	other threads:[~2022-09-27 14:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 13:36 Geert Uytterhoeven
2022-09-27 14:15 ` Robin Murphy [this message]
2022-09-27 14:48   ` Geert Uytterhoeven
2022-09-27 15:09     ` Robin Murphy
2022-09-27 15:29       ` Geert Uytterhoeven
2022-09-27 15:50         ` Robin Murphy
2022-09-27 15:55           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe2b1f48-e18a-b1d9-0c62-ddddf9e6515f@arm.com \
    --to=robin.murphy@arm.com \
    --cc=geert+renesas@glider.be \
    --cc=iommu@lists.linux.dev \
    --cc=j@jannau.net \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=sven@svenpeter.dev \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®