From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753930AbdHUOQr (ORCPT ); Mon, 21 Aug 2017 10:16:47 -0400 Received: from lb1-smtp-cloud7.xs4all.net ([194.109.24.24]:52418 "EHLO lb1-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753536AbdHUOQq (ORCPT ); Mon, 21 Aug 2017 10:16:46 -0400 Subject: Re: [PATCH v7] rockchip/rga: v4l2 m2m support To: Jacob Chen , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, heiko@sntech.de, mchehab@kernel.org, linux-media@vger.kernel.org, laurent.pinchart+renesas@ideasonboard.com, hans.verkuil@cisco.com, tfiga@chromium.org, nicolas@ndufresne.ca References: <1501737812-24171-1-git-send-email-jacob-chen@iotwrt.com> From: Hans Verkuil Message-ID: Date: Mon, 21 Aug 2017 16:16:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501737812-24171-1-git-send-email-jacob-chen@iotwrt.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfJeVjYx/ut8G+w8A94xuA1YVujPBjNjIMyy8AfYLwxYM/e+ABEZBUoTwVPPpDqr1312ilvb1MKjB6NPUDHc/ro0879gpGP3UNTXOkl+p2HVdrodUwaQG czRyByivgxrPBc16aXbIbMiLe7UxbfMivCDsqHrVkcODsKGipUcKNcv94OTjfWaFXXlYVNnxDkdsAk3f8jWZEM3gdo4dPp1uIFx9R3xrPqmWpXjAlv6Zea+J hrJzzYcgPGaeUH1RCtIH8NXE9oW42M97/Sv9vE51Tc8Ndp+gZXkGFRSD7fz84jeYirR70kaas+LG5g90NdBcsjvxUdSiSz25iIUsaBZtL7u32243gnNQ6UiL uzpRZPmKHmgYlIgA+/8Vsd7skgw5Ty/KuXzRMDGl6ykE9gtzuTLjJlXJCb2LTT7VVHjROeAK56CWMbYMN4l/RR0YC8K2WTYheFNpc2XxLhw4+sl5+JWf0Dul ZKCEElXp9Y6jI56RQEAs8Iu7szxdItFAPKfuQQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacob, On 08/03/2017 07:23 AM, Jacob Chen wrote: > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha blending and image blur/sharpness > > The drvier is mostly based on s5p-g2d v4l2 m2m driver > And supports various operations from the rendering pipeline. > - copy > - fast solid color fill > - rotation > - flip > - alpha blending > > The code in rga-hw.c is used to configure regs according to operations > The code in rga-buf.c is used to create private mmu table for RGA. > > changes in V7: > - fix some warning reported by "checkpatch --strict" > > Signed-off-by: Jacob Chen Can you post the v4l2-compliance output? I gather that there is at least one colorspace-related error that appears to be a v4l2-compliance bug, so I'd like to see the exact error it gives. I'll see if I can fix it so this driver has a clean compliance output. I apologize that this driver probably won't make 4.14. Too much to review... I hope to do the v7 review within a week. Regards, Hans