From: Krzysztof Kozlowski <krzk@kernel.org>
To: Myeonghun Pak <mhun512@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Ijae Kim <ae878000@gmail.com>
Subject: Re: [PATCH] extcon: max77843: cancel the interrupt work after removing the IRQ chip
Date: Thu, 12 Nov 2026 08:52:02 +0100 [thread overview]
Message-ID: <fe2e6e14-6d2a-44f1-8c3b-17f0a1bf1213@kernel.org> (raw)
In-Reply-To: <20261112070352.38787-1-mhun512@gmail.com>
On 12/11/2026 08:03, Myeonghun Pak wrote:
> max77843_muic_remove() cancels irq_work before removing the IRQ chip,
> so an interrupt can queue it again before the MUIC regmap and driver
> data are freed. The probe error path does not cancel the work at all.
>
> Cancel irq_work after regmap_del_irq_chip() stops its producer and
> before unregistering the MUIC I2C client. Apply the same ordering to
> the probe error path and initialize the work before that path is used.
>
> Found by a static analysis tool under development.
>
> Compile-tested with W=1 for arm64 and x86_64.
> Not tested on hardware.
So you are doing the same mistakes as vulab?
Organize your work correctly. You can also read feedback vulab received.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-11-12 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 7:03 Myeonghun Pak
2026-11-12 7:52 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe2e6e14-6d2a-44f1-8c3b-17f0a1bf1213@kernel.org \
--to=krzk@kernel.org \
--cc=ae878000@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhun512@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®