From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 564AC31E83A for ; Tue, 16 Jun 2026 13:25:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781616358; cv=none; b=F3tNb5htiIjJX+D9Br+SjdAcKnoGggS5RCRI57vkZsaD2ivyjQsUg0w1cJkEy3s5m1nBkMMJzC1pJgJ8qN5oFVixm2WTj5UeGAjx4YI4fnjixJ6IRV9GklqBHFpNyqGEvmBFQ9JhhxRy2jy9R36r1swOGKkBQ4wpiP1xVhdsySk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781616358; c=relaxed/simple; bh=Ioea2Y3umLF6KJsfs6zmlpUj+peP8XvUMDhOYe7LilE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FDNU2Hfm2j/aQeOzHOxeruIHs8LSyos5SnyKDsUAmswuQEW0E9kmK50bhXnwmd9f1lg2Zwfal2+tbgOa6q9rc8N9sYLcfGlAzhiQlGpaoVz+oB8A8tziisQlWg05v4QwJqFg7u+EcJd9GkKepBZWwMkTBYVakMH3OFmW7zbfDFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hYo9RqbM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eVyBfc54; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hYo9RqbM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eVyBfc54" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GACISs3455905 for ; Tue, 16 Jun 2026 13:25:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MwjvuYt5+PoE/3vS01HiYTn+yCCieemIIEOSQmhKM4w=; b=hYo9RqbMS797uCiB /BtjaAezFPZN+3L4jWIj/VY79XiFj+X27I/Toe8k0yupi2+jkIB+e7FqIbh1bsgp 1Dd0lwvfbng5qskjlg1eUd+5FNo5ZfZPGz0khBpmqMl4XAdq5PjulXHtv6Kl2Vr4 AcM2AW71p2HjfW08bjbEdBekSI9gquZ9+qg9tK50VOMLiq/lJmGJdzLHfuG2KhHw zkzWv4TFzTs3jpfdwInL10WvnakotiRvOcXOICIbmAbOQi4jVEzxl/cpAVn8AIAo n+wi8IqUL05KUcTHJ9y3Fa2rUK18bjuG9aHlKheT1INWR2lR/0bYEBFEXTplv6cc 6JjjsA== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu4dkgue2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 13:25:56 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-6c53e2dd1d6so136108137.2 for ; Tue, 16 Jun 2026 06:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781616356; x=1782221156; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MwjvuYt5+PoE/3vS01HiYTn+yCCieemIIEOSQmhKM4w=; b=eVyBfc54YaiLG4zn+nSIr1/3jpEfFtzgyctCdwyvjHcyMd9X/rLHwtKMww4OOkMghf jbLgA5RAxUeKAMVhPSMQc6rXrJOI2y+S6veCV91yEUJ3Si5tYLWKUp3J+XU3G84NNvF6 XsCdd4joANhWX2irCh6x364gnh/4zKr12VHhiZEDn2sxBH17G903T701zgkm4I/mCUWR sR5D4iBLd3YXldTwpLx+31MU4gAxKGvJuQXEpsUHrUX0XvgZp3ZlFBc2g+XGIkRBrHoD Aw0ppqU0PgQqk8UX+l+8wEvQeQe6hdGHFjq7kLVfQxqWXL9KWZ1j/DRfGZj7SmGqOM6P gWXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781616356; x=1782221156; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MwjvuYt5+PoE/3vS01HiYTn+yCCieemIIEOSQmhKM4w=; b=mNQD8FcmsY9dXm/sVjm47XomScyD4rd9hKvimHGWKmAOJqqnzkW0fAxis3F8v58Bw1 iCRK4UUwieK15BqzbMbEmBSGIKPJBJ/VU4xJoDgcVESvwjjLZwNpHT+u0OF8nYuUti6O 6xxG+6Bjc18n24RMSj9iBf2peRZqefZGLM2bBLS2NZBIq1l5FYylUxA92HV89ZMcVRKi yzbcq57IlyylxUmSCM8uCa9i4XH3UiupYigSPOWJ0+e4Qo5PqXd4//HAQ4qMZiERthXS EPpH+F6Bz9i//SozR62k/c6auKiIujpcz2pmfIz0/XskOR1/3XbDWubTIbAjjSinB8R3 yXAg== X-Forwarded-Encrypted: i=1; AFNElJ9zmCDesVt//miWzpIsrsnMRumAINKdEtD82UBZ4NBKUj6NzcYAiTRnP0124lG4zfd91hSn+pNFajLqlR8=@vger.kernel.org X-Gm-Message-State: AOJu0YxIn0tHVI2sY4giW5oWW087A7ffCcvFLgvdxIZ7viffGOW08t4U KHq6/2n0BCkBa+vUmHcgEAZkFrlFwj26z59grsGHQoP5v/y/t1nAMipaj9qylz81oY1heECPhx8 iVtbN3PN0Ro4IBxeWHdidZjFWvQGVJK9/+bameaWv+b1kQguadntCYTpG2LGAJFt7WyI= X-Gm-Gg: Acq92OGuVdp9wUY+hKC0eBWBvtM+t/r5FNHTLH+o4K5m66IhtfqiYmOYIJCdyxfMwHC 3dCESbBczEk2cO6PXeJoJbYI6iHgAwdh/iWRxvmnOYVQI39VoCaVN5kUyj7Xwb28PsRTc2d3TT4 HAbPNRSUVg/v4sPJAXGl9fpssAJW1iz6/ajn6anYpL52eQ90hjbxI0mphaZ2tERXclaLaz1igrB 5z3EpEp6dpI/7gDlArtR2Thxgx4nCFupjeeA2fPnwuzHAzX6xMvmxC44rJXut/rczsit13djRpz NfSnxp3t35C/7LBg5B5hpllkavdZU+Dj4pa1t/Vhlerb8qlB+hLe0lbuWidT5sNEP6jZ8dSAmQc VNlQ19AJ5ulqF4QEDP/YBEpKxTrbit3Ro8ql+fcdJ8ZWRDw== X-Received: by 2002:a05:6102:3912:b0:71e:1c56:e79c with SMTP id ada2fe7eead31-71e88b60f45mr3018653137.2.1781616355602; Tue, 16 Jun 2026 06:25:55 -0700 (PDT) X-Received: by 2002:a05:6102:3912:b0:71e:1c56:e79c with SMTP id ada2fe7eead31-71e88b60f45mr3018633137.2.1781616355146; Tue, 16 Jun 2026 06:25:55 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb844060csm641401666b.46.2026.06.16.06.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 06:25:54 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 15:25:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] arm64: dts: qcom: sdm670: add default uart pinctrl nodes To: pabloyoyoista@postmarketos.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Acayan , ~postmarketos/upstreaming@lists.sr.ht References: <20260601-pabloyoyoista-debug-uart-on-rdacayan-next-v4-0-c5d51dd96ca0@postmarketos.org> <20260601-pabloyoyoista-debug-uart-on-rdacayan-next-v4-1-c5d51dd96ca0@postmarketos.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260601-pabloyoyoista-debug-uart-on-rdacayan-next-v4-1-c5d51dd96ca0@postmarketos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: Mz2Xs9O5NHfPuzqeV36A-nymMLDxzuWQ X-Proofpoint-ORIG-GUID: Mz2Xs9O5NHfPuzqeV36A-nymMLDxzuWQ X-Authority-Analysis: v=2.4 cv=Ibi3n2qa c=1 sm=1 tr=0 ts=6a314ee4 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=Gbw9aFdXAAAA:8 a=FyMMustK1Au6H1ATeJ8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=-aSRE8QhW-JAV6biHavz:22 a=9vIz8raoGPyDa4jBFAYH:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDEzNiBTYWx0ZWRfX5fPYLvLFgQze YXL9XXQCzOgI/f9bv52U7pDLbFq6c1WXG2R5Ngg/kMRYNd8j7JfFoq3smbfl2bxaMh5wy6JFuWR 4W+UUmr4sA2Gh+LzGH0UTGB7rhoIiU3zlq/vm/cezsgclOo0qnswl3rp8uyn0XQiMMTGKuywKws 2HeWt16bycgA0C+xvxPjHt6MSlGH315ZEW6jRaJwuxRd4Q3BH/3YYmBAy6Nn6uZH8qcKBPzW5XG jlKdAcjtzVtGQzEd1ErC13mbQDqAjWdl1KxgSysB+gS4ipa8cHuKXw6i7vZINiqlI5RNcXzEuKh K6MxYqYHyrJAT9BnnZAKNKOQJNzppWiLGocGRXswuv11FkD8vWxhaIvzPqsHp/XYvFXzIaQZfw0 GeTanXizIweo8kEh+QbwbQ9k6x0amAO+CMbq9DR9b7kJtpSpHp9IvaZbrpCTn8+MnQJyoJbeLZ6 rhETfNcJirFPGVpdX5Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDEzNiBTYWx0ZWRfX8tzePIAGyGcL bj81oWZoCtiQLGsYHmeIhxANREleWdxQyy+qAeQo6Vj3qK0dy3/MwI2oJnq1KloNVxucB1s+wIi 2Tim2eGwZ2peApVXifx7icViPlAFTWk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_03,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160136 On 6/1/26 6:55 PM, Pablo Correa Gómez via B4 Relay wrote: > From: Pablo Correa Gómez > > This is a pre-requisite to enable UART in sargo and bonito. Values for > the pins have been taken from sdm845, and cross-checking dowstream, > where available. > > Signed-off-by: Pablo Correa Gómez > --- [...] > + qup_uart0_default: qup-uart0-default-state { > + qup_uart0_tx: tx-pins { > + pins = "gpio2"; > + function = "qup0"; > + }; > + > + qup_uart0_rx: rx-pins { > + pins = "gpio3"; > + function = "qup0"; > + }; Let's drop the unused labels and let's bring the default config (bias-disable + drive-strength = <2>) to the SoC DT, like we have in glymur.dtsi Please also cross-check whether the pull-up you enable in your phone's DT is actually necessary (and whether it's defined as such in the vendor DT - FWIW it's not in the sdm670-pinctrl.dtsi common one) Konrad