From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751513AbdFGI4A (ORCPT ); Wed, 7 Jun 2017 04:56:00 -0400 Received: from mail-db5eur01on0050.outbound.protection.outlook.com ([104.47.2.50]:2496 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750739AbdFGIz5 (ORCPT ); Wed, 7 Jun 2017 04:55:57 -0400 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Subject: Re: [PATCH v5 5/9] nvmet: implement namespace identify descriptor list To: Johannes Thumshirn , Christoph Hellwig , Sagi Grimberg , Keith Busch References: <20170606143617.32143-1-jthumshirn@suse.de> <20170606143617.32143-6-jthumshirn@suse.de> CC: Hannes Reinecke , Linux NVMe Mailinglist , Linux Kernel Mailinglist From: Max Gurtovoy Message-ID: Date: Wed, 7 Jun 2017 11:55:03 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170606143617.32143-6-jthumshirn@suse.de> Content-Type: text/plain; charset="windows-1255"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.223.3.143] X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39850400002)(39400400002)(39840400002)(39860400002)(39410400002)(39450400003)(2980300002)(438002)(189002)(199003)(24454002)(377454003)(9170700003)(305945005)(77096006)(229853002)(356003)(3846002)(86362001)(54906002)(36756003)(4326008)(53546009)(6116002)(83506001)(7736002)(31696002)(2950100002)(6246003)(478600001)(8676002)(54356999)(65806001)(76176999)(8936002)(2906002)(106466001)(65956001)(81166006)(50986999)(5660300001)(38730400002)(6666003)(47776003)(189998001)(64126003)(4001350100001)(230700001)(50466002)(33646002)(31686004)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB1349;H:mtlcas13.mtl.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11FD031;1:+bXBwRd/gqMAad1Z4so8G51MjP8KfynWkgYRiROrTzMj/O8qPMYlGcLzZZoa9JxD54kB8RZw1aV77IyEF/am6MP6RaVUKdNSPYYT+yYmQnHoyJ5plmjFiFTSKp1/mTIFKrtKQkDbCbIXg68K96/FYb2YHSqR6HJil9APSg3uQfmA0GGeorKXotnT5Yy0uD0m8ovyjoYL7v2YkfscjPARmo43OY0aFhaz95g8kbdS8YBx7BeV4MA1bVyBrgSMfV0xkk73QMKUvAEAE92T6YOE2WTNWlJA7d6gs5GOYkx14o1Q3vTt8h4fru8YZ8SDbrkVkLwO7YddVtlIduH8ScF/Dzuaa+AvOYVfyEi/KayXOKkS4yzieKM9my7Yy+TVaBO8C3xFI9AQ+9Cy7+JYdZlytIIEBjzAzNgpvULceDX0EBkFlRZxJJUq2ZaR/tlb/g+3ihUxWdC7mL1NBpjFlxuD9DJeIAL98r85vn/K5o4T6Z9F3291zss7TlvfKQw78htm3RDToZcwL1be3rfTYjZoq5PTOOKovqqbVnlvc9l/5AJbyF6NyI3l/JTdffRDVDPuKAIqYtblD3UeCVPT2BAU7924Tf2mjxb57oG3PVOCWFYD/osreWfGjGf/GRHqVQ5W X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PR05MB1349: X-MS-Office365-Filtering-Correlation-Id: bef6f428-ed99-406f-0762-08d4ad8300c1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081);SRVR:DB5PR05MB1349; X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1349;3:DZUfZXTHx7daM/tKZ3xH+2ZZhhXTX3C4s2PkX+OmUXDf+2ArwqGn7LC0S4MduzKMqQPd7RfPtxRBpYx1RIyIDjuZ55tau/xJFxFcC5ADVjkZytyJZtJFO7LgRIZooSN4t+ZpFOc2duYyAAxO11HIdfayVCXloRNXp85M3w93aax/RGNzEqmFc/X7615VKI/Nnr4IgyplqWeZpKbJZzqoat5SW4FAfwW9USFPTk3edcqaanbjXPMtGMmOBzN70DQof8itLgmgYL2FxMPA3dw4KrSb6xZPe4G7N6BqE4LZ9Z+fX6hSwAU7in1CiVyQMs42J+KY4099dfWKmO4nuWUIzoe7/vqoeQUX3FaBy8kI4LTBMezV6i9G99jg76Wg5TrdewiBeInsuQgu2AYsb+SK1rnG2xaujWjxWeNOZkciarYkOQ58nGoKJJXeZjpCevdAh9nEK3NGcgwak1j8gtPs5h19IGEwPjRkeEcj8/UXcZ9C3w2gdToTT4Sxk2ay9AY4 X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1349;25:ONd6WZKZYLUgwSTA7cGLwXpojBVGo7EQ20w/vTDSUoFm8QAzKkuZDo/8ULOvMfz4swJJnSfI4b37tR6L2ie2ZWXobtp1iodtkYQSpTs+El5Bk4XP7TJD0VXCpVXs51v+ZzBh+MJXiJCX4J+FofXqBwRYNf2lB9NzwNIBRkbsaUhHUwQPftfcruJXKGw1lb596fZoxxQ8Lc5vesaM/wGq6AnGWEOC2iBSaOVwAGO1w/0AXSmtZdA7pKcfu8uLkdQkEcGtnp769FrDCt832Pd3ISjDvDS3iTUZaxGatqVxdWM5eyovkL0cjeY1of7U9/1b6vRrTzX+19VhGBja0H15S1joqQ1jwvYuCmzmI7Q3P2nkgfpoEKhQldMBJ18rMwylqnvmW3mKmHc83COity1tsIarB/fvjCHXos1Y199CWbmRXSS4H6Wr7FVqFZYdkCUloV+s++gAvPxismoGi41gTPFI46ROT0XZmGG2A5TjdCE=;31:FUQdIWkzOciLPEOU2V6llNv3Szc4QUIpMyV5TPfagjsjje4FlqkEpLXnLy08mnyV3YneWOtVdfpwqpPcqAXOkHxsvxd6bW3fsZQ9h4P4khb8yuhuCpSck+RThwWLmymsR6qTddy5sMbyLILgvZ4Pdy3awRcMSmCULusgoK+09ZxJGBG91III9we9KDhgUm500Reb3bWx+NfcrnpzAAeB4WivS9lFkxgpITjsioOuPkoUGhK/QIp3MdfBiC51pgwAOcRYN3FcgP/6PcZeSZKSSQ== X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1349;20:ZI9IUUAm3JS933QOm02AyvZ/Io4wvr4WL8Z2taYMTUnT6+UdHhPykmuiGbN1sFdom92QOjzuXh8ZCRIEpJKb4h+P5O6+M+VS8kPKsEXzDJ1J/XT2okf+poZ22uglFZ2zL1fwiEei4GqxdgL9/UP7LeflsuQ7tjgXsmXO7EtQQaGJHlAVIYXcDQwvdrTvMpzKB39HhivX/rZpBhy3VZCMplXeFtS0/xfO6XetTx2hjeBfz8qQJZGPJlAzO/4BfppiMHX++TIgtYK3ZggRKD7fm+01U54P9GyG84F3XHnUHyUfk9Zu5joTkjK33ZHCOyKmYGFRP8yFVe9JK9Pky02tog6+2SIT4uw9Wxs7tXByiov+rlsFM+Q7gqp3vTp7Vyb+nMc8drwLN9IhyIa2ensHdPHPDGsuIlPkRgRuQ1t4qUzMnw5nLvQGzJzf9eWmCu0fer0pncNqu4wDjx14MndThpknJKivLU+bOO4R2IdziPl0KHLTTZMrXcZO4sF601yG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(13018025)(13016025)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93004095)(6055026)(6041248)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB5PR05MB1349;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB5PR05MB1349; X-Microsoft-Exchange-Diagnostics: =?windows-1255?Q?1;DB5PR05MB1349;4:Pth1CdkrFmNa1ocuUgfZy6nGz93BVCJWaH+DVJ?= =?windows-1255?Q?/kSi6e6q/LXNnUTmuCtrH6Co3NGLQ9oSHm5LRKlhzj8S2Vg7yOzr+hr1?= =?windows-1255?Q?xTNc+Oi8tBQkG9so+bnrblVvdPllEIIDhBaJI3dPiEEGab7BxDTANeEe?= =?windows-1255?Q?rn/ViEv1Mj80JjNdB4WVingDo1uHRyZ4/ZM0Zl7anGWYfL5AdguzL/M1?= =?windows-1255?Q?a+cD51W4OP12mYULurUnDLxvV/M3GUmTmvQmMOSiHE58KvYBPi3lvto3?= =?windows-1255?Q?uYZxBE+AJoEYHuIjPBGfwWpJUTZHmY02l+wYpIa7A2Lz8T6UQO5vgBjO?= =?windows-1255?Q?5Y70S+cPv8Lw4esYwv2/Be41BLrB0k7rDuorWFGBTrvLWLBrmmWqOtXW?= =?windows-1255?Q?BhsBpnpP95r6nkqh5Hy+FHRux3L+MD23WCDaai2KTisk/e/w/43Uc0wS?= =?windows-1255?Q?0CJkBsuJq9Z91uLgAHAgZ8ppgWihXzBPAdbMRcbhTb/27iIPdyPAVlw8?= =?windows-1255?Q?yENJWYsWGNlRgLWgy2abhqlfi2mIxUuIXGnknGgqiFiEU4xD+7gnYB+s?= =?windows-1255?Q?6tGYGyUH2BedozjJFiygPY0p1VzERZ0VxpphAe304p97effqbHN+IHV5?= =?windows-1255?Q?kMxOOGAEPu97nCv0QWxJ6BA0L75BCXV3eKgcxnEpU0WufWaPh500YG79?= =?windows-1255?Q?kLqBlaXNaiPkhWVjMZ2frv0v4C9bKwglryhQuUCo3i/VMoE8b/Gtt3Io?= =?windows-1255?Q?itUehyd/V7z9HY6Z0RyOiDaWI0Fobd+YBUkEjCxaQRNRcknd1KnfNcNl?= =?windows-1255?Q?OZA543cX6RXDRxLb2xvoEtclYvuTywTfmOhsl9zXTGqJqca++v3DjTRm?= =?windows-1255?Q?eIfnz/dgEctoTJQ0I6oTmPAjke/MbUkrNxptifz0HPx2CGYaEuBio9qN?= =?windows-1255?Q?pSGuy/STjYqgW7qs7yNFt/NgQnVAf2Rpf7PJXOL+TXG9f7ed1deZzGKq?= =?windows-1255?Q?SddWyBWoQcYbX+mJT5Rbnib1wYLENdZCpjSjx5cGatZ3hB78QQtXCgK/?= =?windows-1255?Q?uORItWIwrFQRWtAWqEEz0tvKIoHDCElmn9fmjX5FZvLToq6Qlbc48mRz?= =?windows-1255?Q?7pDF+oON9IZ2hcfMtfvuHOgC67NeszYzWJ9ydXg2/ehlzThS/cc48czY?= =?windows-1255?Q?KCnepqQznMbGrK7TTfzUtZcd5yTmkb6GjWuRf5meIVE70X1jAhKCQ7jx?= =?windows-1255?Q?w7YybmFRw/RRZEaMGAMt4VJB9QwKdlpRQYkVMSy1DvFI+jqdKsURQkeZ?= =?windows-1255?Q?Fs?= X-Forefront-PRVS: 03319F6FEF X-Microsoft-Exchange-Diagnostics: =?windows-1255?Q?1;DB5PR05MB1349;23:6/eCUiPQpqxGB1YW7pt8F9jSxWVzJ5yTYxlX4?= =?windows-1255?Q?s0o/VfhT4UJ6kx4hMgZaMUBS1JieTGT7v9oJqQ60rLrrSu7QfrqsA61O?= =?windows-1255?Q?RS+dyVsE/8GhZx1/A8tfPlbl5VIHnJBOk/auCGtC85cZFUJUsRQBTlbx?= =?windows-1255?Q?64e1T5na7pLkKdCMIQqwssqNGUXg15gUjEjXm3AqH8KPMrKouefBbSmo?= =?windows-1255?Q?bsz1KUmexWeOL7AZNeYyCJDt46zsvfaX9tnUuwiHD3XwRcvskRiEfnqN?= =?windows-1255?Q?a278igGXMyTcM/g7ToYDT+5mgVz0AaOlT2lhXdWdbpiQDJVazNZ14Sn5?= =?windows-1255?Q?Da2KhoyQuujcgCI7o0qXiM42U7CwqLmpMlsN49mwhvkTTNFVrkHiCyb5?= =?windows-1255?Q?rf5SmJanhbF5WAM4uuYt8M5OdgLBKmVZIkft28R7WbYz4rM7+Xcl26X6?= =?windows-1255?Q?m6UQHy9w2Ysk0pQTOW7Bgt7E+i9HU5b6HhBpEwbqM9/GXNuyYKNXM1X2?= =?windows-1255?Q?6Lklvn01+VoPYcJmw63UXqLqgzbHIH5/ULwaZmsYoNWdbfD6UU/t+Mbz?= =?windows-1255?Q?qnip5eWqRIXyxvM/A064aF9rdWKcUy81rl6EzY4Eq+F6EP8RV1P3g7DI?= =?windows-1255?Q?HpxlGmkWCqOUfBeIs8vexasNpjzqO/6+jsG3zhqXkSbYHxi9xKQUghtV?= =?windows-1255?Q?OSOoRKJtG9WQO+oCSlmXd4djc9LNpcWBJFpp+zdUSar3AiKQBts8+XJZ?= =?windows-1255?Q?3KTlsX5IJZ4H16yau4jUXwSfSWanBRhth0TVg1UvjomlETaU6ZKaPveH?= =?windows-1255?Q?LedyK8QK+CCysf7RSLHFlXwpp72ydGGwqgxPz5a/DALYmLrlzqqi56/Q?= =?windows-1255?Q?i2spULTmCyhsZnkS4RFk5OxdfmOduKYpZyIXQac2iiMZGF+eXRzDDpwE?= =?windows-1255?Q?63W/5BspfWT0JmLBcgX8/JIU8xy3rNEXej7GO84K9safWMDDoz3b77OM?= =?windows-1255?Q?CK3qe+E7eesqFzpND9u8SHNDbm8nmd57XXbkK8vI5L1Zitkmerfp6d6L?= =?windows-1255?Q?1iAxo6QuFH/DCmAa3dr4GEI/nj7xF5qb+rI4kHoLCBcXhuJw3wZgHGWR?= =?windows-1255?Q?oaCWlUoW9k/ZoH3k0SNrYrHMxtxRObIMHNTeacUQOMmv/BHQ2FOxcC+n?= =?windows-1255?Q?ND3lZmAdQzo8bfrLfFUHWQ29sFn14XP8ybb18otlC5etpc7H6PIdoPoz?= =?windows-1255?Q?mmx5E66O6byOqAseYDdCUiJfV0N/POf/GCriIdxHxg9Z+I8oYNDYww2m?= =?windows-1255?Q?VBu79kHQwmAhTKhNHFS8PaAqaVV/nV7QKsbz0mVceG0KrCtiBfbv2vH6?= =?windows-1255?Q?0DYW6cWVobZWyPwS8QTccA1347pbnGGXy+YSSNMWiQcGLI83VfAVOA?= =?windows-1255?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1349;6:lqGOHTnjGmLOIHfJ36HE8syWGhnwS5c0sY9yrEistvNmwKoZUeyBTaKg6J09J57ZyIMw6p64r0BDviX00wK5UcJICWlQfdXU5tUH9DqWP4+UpSWZsnMc0mSafgt5LQF9xTbX1UFpur1pn/onGWznSevP1I1fMcrEot2guNzNhhZUAKeGZ7kSvy8c7np3kTFTiZy4hu1nUoGoRF64OHuDNgBvDtA4Hc8FZgnlgCMAjq12R0TI5gF4siIZy+KmRK02iApzLVJZStfsiMp9NmpHtxuOA5nEWo9wOquOUt9e+CaCBM9KCekYxuocsD2xRIFg2rLVX1jnBc9ESap5i1ojJ89kq2dVwDSi69DD+AgDmBMpD90mrkQX3QA635oqq3UESRHrSTQqvsCZmZ5u4mRcAbWhdM/M2Soy0wNvB5MP4GvawiaB4WBIyNy3ToHSKjHQdEJc88GZymNCqREA9BBPynYkdoBF03+vnXtnzkc+gq0Vd7ln4DWfgyFTsCoL3YtgabFwovxzsi3KbniBsdYtv8lf6PPggsvwB0KN7+p+keg= X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1349;5:BATqEjluZowK6a1IDG+FwwlMfPL4ZDb7jSpU6f2PL63fa3BawmhKD5zQg7DWoWVv9dKraO45QQOnBLFts+qqI9PsOY5wzz/rhO5Jwh9U3fwBVbEDxSX8puLc9hUjGnWTdFA4XVZFQOJcTnNm/UmRO5k7LFOMiCCfofEfLDaTMmJUBWXSuhMLGCFIJpWY53csjV6LKSHtT1QB6kmm5Qli9gYl9fVkAuq7bvE3EXCAVQlTJoeUQOL8ZwquY024A9PwZDLlccTKEe9yQlUWg3WAaqlkKmR1OwDAJofjOb9QRNNlqv/4voLJfTA1ktx6Paare77W9dsP2qk2MwARwzqdvvMTC7wYdEhHCSz1YeYfvyE+3NXhkp0CNr0Bw31M7sIVmQHrJTVSFDsfzlGH8L2/c03pSwah3sJKddjkbjStohLWNQdzQJUtAE2k4hyxVUyajVFJtv75OjwQJ8/QhLJxxt0nM2K5JuvhAtoiOVghuUFrA6TX8RCZhQTq8H2UUAsv;24:yGTPmGicmGlF9xjAuS9S2uadyT1gc/l1KMLIQ93oajOWlU6aun9JYUcrjuCBhBNx2CzswikPIeO3uzJbOedCuGEZxxhCf2WAbW2TnSOycdo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1349;7:pnB1iZLGY2gxmtuNz9VtFPLXfskkafTC8hRhIOAj8aLqUqdEqU5BT/SiM+pjUEV9z/MZsD/L6SW9Ct3oRC3z0IG4UygQ/SKhAiGoyenxriFH4D920e5ftYy7QsHwwFOiZMJNksAJmMIDUMB7CY+3de6ve9KR8OOvBjUuDRWoW8I+CqeykrAWbnDbdWCTMMm6fHbr1SFhO97rerUDh3YXTRORZrdBJ63MwhE+jlkCGDOpv2rCFMTVK9LkFgqlbrQeMXKk0yNfpXJIZJvFIpn13T+N/UEx1W8ltZPixEHZyDFRq02ypJxGQrU8ghvR2YWkE3XP8a2FIAS1eoukZgzzCQ== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2017 08:55:52.9025 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1349 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/6/2017 5:36 PM, Johannes Thumshirn wrote: > A NVMe Identify NS command with a CNS value of '3' is expecting a list > of Namespace Identification Descriptor structures to be returned to > the host for the namespace requested in the namespace identify > command. > > This Namespace Identification Descriptor structure consists of the > type of the namespace identifier, the length of the identifier and the > actual identifier. > > Valid types are NGUID and UUID which we have saved in our nvme_ns > structure if they have been configured via configfs. If no value has > been assigened to one of these we return an "invalid opcode" back to > the host to maintain backward compatibiliy with older implementations > without Namespace Identify Descriptor list support. > > Also as the Namespace Identify Descriptor list is the only mandatory > feature change between 1.2.1 and 1.3.0 we can bump the advertised > version as well. > > Signed-off-by: Johannes Thumshirn > Reviewed-by: Hannes Reinecke > --- Looks good, Reviewed-by: Max Gurtovoy