From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 006C0205512 for ; Mon, 3 Feb 2025 14:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738591576; cv=none; b=mmLY2qxhDhNqMPdVtiUgZfRV2a0K/wQEDHbguBYq7HLK2NZ5wUniXbUImaH1+dPRjBXquhfo7DN94sZZsrZsAV8ef5q3i9sNdG597/0XgiSvyMmq5pS6BioAr186dIYIQl8Bn+h46mVu4Iqns+ek+ynnX7YMdbuoj5vJmLs2rV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738591576; c=relaxed/simple; bh=f3nhNeQhnqOkT+ZMVNhMI11XyUbk9ojwQ5TtjrtWkXw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QVGWmZmpcI/l4UOLX7/jWufWbtnK7qTSv8sd29VA2/H71uuJlCv9/cfkI6PEH0Y4CLn6qUtiG0oXs4ttZmvCE1fHbyxHRbsSnPcHZRRxrJRX+bGBlCY3f77T4dHDYN2L3iHCGYAsKCg8SJ/DQheFlCFhob8+eTIvC9nugHhNvrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kNHl9q2+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kNHl9q2+" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 513E5Y5D002395 for ; Mon, 3 Feb 2025 14:06:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EZtNFCZgeL0FWLDNzLfu63fu2KsbwaM5gDoXUO3p8uU=; b=kNHl9q2+5MJEFKfI t27DYFOPYhpguZy0evjQ5sPVCVjtNyzSW98Usht0gghVk3yW+j+uVlFc4/z6gQik I2+xZNrj37DBpFzZJiD4NX9sNvUDihzF4IUbcCYk0oighf+Z4RQpBvhGAPvV3pK2 P1x6TYJ9ZS8FoeplQYDVc5QTDRlebVe3MYzoaZTPU4oNzVUxvfVmsC3ZjsufUkcl a8IjPGvvLyfaTlGnRceUBg7n3ZY1u/wfa97373q8B4dJ/2rsaB+qzzvfELQ2tvkX 6VTYUZ8EcVa8Cw0s0qppZz1Ku+gucgSInDR4k5zTBeBA6h1Hbmappb34u7orG63M 3tuAnw== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44jy8s802m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 03 Feb 2025 14:06:14 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6dfba8de3cdso15264976d6.0 for ; Mon, 03 Feb 2025 06:06:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738591573; x=1739196373; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EZtNFCZgeL0FWLDNzLfu63fu2KsbwaM5gDoXUO3p8uU=; b=njPQNVSl/dyZ3Rl7Cc2ZQsHKXHI7285IGXSCzksuLzI/kLPbfd0nklZnKTZDKyiogJ zvj/Be7l3oqeU+AbBmJlg8IFe1s1m1y3lxe56Zsl8htuLaIbznvdPGnmMbhYvLNKiFgN hWwkMjBaOnMGCww4WrQc9Q/dXYfIOjnjh+ob6Wwq9DaCENtcGsviVFrW3pA7JqFJROr/ lHjayUa2m1KnZ+WAvc1h1SERrKPlytpMvCqWNQnA/P7PWXbiCNi/pmiLTDpFMHymhzkx C0Ev5ve4/JHxvlWqGpo1UmdSDxohZ5RmRFXIe2V3jMQFieXxN+VBgFUnQE7wLjI3PYww 1WrQ== X-Forwarded-Encrypted: i=1; AJvYcCUnTyyXIlcaphqPjbN6CmApCbvinA7y5AECxpDx/xPPto39rY+t532Ar7Ckl2bWC9kpxt6UbFmprK7VDcU=@vger.kernel.org X-Gm-Message-State: AOJu0YzN8NVybtaSkpk+lcnkPoOjdgR8ukKomBXrHseYPI+dwmyE/CLz k1A6Lh3TDEteKbiEyZ7r94z0Vq38lyavzjafIq+gYjM9p9vrFmm2q0AwKDPXFz7EQejs4Mzy/xE gtWQhqNGvapOTOxiB+cJdP21Cc4A3DTgcwrHgy16al/5ZGyjBIArtAVxFJ9BnDlo= X-Gm-Gg: ASbGncsLJ5VDtpNL6m8omgRLeqnYLWw5egctUhLtAINlTBm+rLcHDbFM0WWBEld6lY9 t5kX54uX8x9b4smqfx8yazpPQt+74B7FILocaPELx/E2LvuW6pXhgsN9KDxmLPZf/NDwcnP8tVX WnFEz0NYfg42yo3w/GrfSxD4gLqEJRp7nydfU6u+7MHVix5Kh4IDhUR9HGBnvalesPuPx4yzx9t KJKDKx5OzOrkBlxn9WH9E+tyaS1gxGhbMF4PBWsfeCydCnoIpIYl4nj39wVTEmTkLZn0ZHZCtAy xvKLPn+wbZfVr9Z/lM4anZmkvTshUCxSXRm8112UoCb+96MtCNnKI0a7OU4= X-Received: by 2002:a05:620a:2894:b0:7a9:bf88:7d9a with SMTP id af79cd13be357-7c009b82e2bmr945576985a.10.1738591572560; Mon, 03 Feb 2025 06:06:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPDP0qol6PEmtndJ/qVx5GfFuI5eDR2ztN60QRNYMzKfDc3SNz9DsOhMZSkcbvAKF0wFjIyQ== X-Received: by 2002:a05:620a:2894:b0:7a9:bf88:7d9a with SMTP id af79cd13be357-7c009b82e2bmr945575185a.10.1738591572176; Mon, 03 Feb 2025 06:06:12 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e45ccd6dsm757393166b.0.2025.02.03.06.06.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Feb 2025 06:06:11 -0800 (PST) Message-ID: Date: Mon, 3 Feb 2025 15:06:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: sm8650: add all 8 coresight ETE nodes To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yuanfang Zhang Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20250129-topic-sm8650-upstream-add-all-coresight-cpus-v2-1-c62549307e01@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250129-topic-sm8650-upstream-add-all-coresight-cpus-v2-1-c62549307e01@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: gfv4MEVdzalgTrJoD9MdG-QYtUdWMOgq X-Proofpoint-ORIG-GUID: gfv4MEVdzalgTrJoD9MdG-QYtUdWMOgq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-03_06,2025-01-31_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 mlxscore=0 spamscore=0 malwarescore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502030104 On 29.01.2025 4:08 PM, Neil Armstrong wrote: > Only CPU0 Embedded Trace Extension (ETE) was added, but there's one > for all 8 CPUs, so add the missing ones. > > Fixes: 256e6937e48a ("arm64: dts: qcom: sm8650: Add coresight nodes") > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Neil Armstrong > --- > Changes in v2: > - fixed the 7/8 cpu wording > - added the sm8650 prefix > - add review tag > - Link to v1: https://lore.kernel.org/r/20250129-topic-sm8650-upstream-add-all-coresight-cpus-v1-1-96996d37df8e@linaro.org > --- > arch/arm64/boot/dts/qcom/sm8650.dtsi | 163 ++++++++++++++++++++++++++++++++++- > 1 file changed, 161 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi > index 86684cb9a9325618ddb74458621cf4bbdc1cc0d1..d925d5e2c8182d522dd5b8e1fa0e253f5de2f7a7 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi > @@ -365,7 +365,7 @@ cluster_sleep_1: cluster-sleep-1 { > }; > }; > > - ete0 { > + ete-0 { > compatible = "arm,embedded-trace-extension"; > > cpu = <&cpu0>; > @@ -379,15 +379,174 @@ ete0_out_funnel_ete: endpoint { > }; > }; > > + ete-1 { > + compatible = "arm,embedded-trace-extension"; > + > + cpu = <&cpu1>; > + > + out-ports { > + port { > + ete1_out_funnel_ete: endpoint { > + remote-endpoint = <&funnel_ete_in_ete1>; > + }; > + }; > + }; > + }; These bindings are kinda tragic, imagine this on a 128 core chip :/ But alas Reviewed-by: Konrad Dybcio Konrad