From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA72C433DF for ; Sun, 17 May 2020 12:33:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7F1620727 for ; Sun, 17 May 2020 12:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727969AbgEQMdT convert rfc822-to-8bit (ORCPT ); Sun, 17 May 2020 08:33:19 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:52894 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727893AbgEQMdS (ORCPT ); Sun, 17 May 2020 08:33:18 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-77-e_XcCBs3NxeTTdl9ilXcdg-1; Sun, 17 May 2020 13:33:14 +0100 X-MC-Unique: e_XcCBs3NxeTTdl9ilXcdg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Sun, 17 May 2020 13:33:14 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Sun, 17 May 2020 13:33:14 +0100 From: David Laight To: 'Masahiro Yamada' , "linux-kbuild@vger.kernel.org" CC: Jessica Yu , Michal Marek , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 09/29] kbuild: disallow multi-word in M= or KBUILD_EXTMOD Thread-Topic: [PATCH 09/29] kbuild: disallow multi-word in M= or KBUILD_EXTMOD Thread-Index: AQHWLDCKQVfb3e05HkmP445tLCctkqisNZ6A Date: Sun, 17 May 2020 12:33:13 +0000 Message-ID: References: <20200517094859.2376211-1-masahiroy@kernel.org> <20200517094859.2376211-10-masahiroy@kernel.org> In-Reply-To: <20200517094859.2376211-10-masahiroy@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada > Sent: 17 May 2020 10:49 > $(firstword ...) in scripts/Makefile.modpost was added by commit > 3f3fd3c05585 ("[PATCH] kbuild: allow multi-word $M in Makefile.modpost") > to build multiple external module directories. > > This feature has been broken for a while. Remove the bitrotten code, and > stop parsing if M or KBUILD_EXTMOD contains multiple words. ISTR that one of the kernel documentation files says that it is possible to build multiple modules together in order to avoid 'faffing' with exported symbol lists. So the docs need updating to match. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)