From: Joe Perches <joe@perches.com>
To: Jerome Pouiller <Jerome.Pouiller@silabs.com>,
linux-wireless@vger.kernel.org, Kalle Valo <kvalo@kernel.org>
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 03/10] staging: wfx: format comments on 100 columns
Date: Mon, 28 Feb 2022 17:12:28 -0800 [thread overview]
Message-ID: <fe3c21a9c0178a2f0fcea698b8e6405a99747dea.camel@perches.com> (raw)
In-Reply-To: <20220225112405.355599-4-Jerome.Pouiller@silabs.com>
On Fri, 2022-02-25 at 12:23 +0100, Jerome Pouiller wrote:
> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> A few comments were not yet formatted on 100 columns.
IMO, none of these changes are necessary or good changes.
80 columns is preferred.
Really comments should most always use 80 columns, and
only occasionally should code be more than 80 columns
and almost never should code be more than 100 columns.
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
[]
> @@ -117,9 +117,7 @@ static int wfx_tx_policy_get(struct wfx_vif *wvif, struct ieee80211_tx_rate *rat
> if (idx >= 0) {
> *renew = false;
> } else {
> - /* If policy is not found create a new one using the oldest
> - * entry in "free" list
> - */
> + /* If policy is not found create a new one using the oldest entry in "free" list */
> *renew = true;
> entry = list_entry(cache->free.prev, struct wfx_tx_policy, link);
> memcpy(entry->rates, wanted.rates, sizeof(entry->rates));
> @@ -494,9 +492,7 @@ void wfx_tx_confirm_cb(struct wfx_dev *wdev, const struct wfx_hif_cnf_tx *arg)
> wfx_tx_fill_rates(wdev, tx_info, arg);
> skb_trim(skb, skb->len - tx_priv->icv_size);
>
> - /* From now, you can touch to tx_info->status, but do not touch to
> - * tx_priv anymore
> - */
> + /* From now, you can touch to tx_info->status, but do not touch to tx_priv anymore */
> /* FIXME: use ieee80211_tx_info_clear_status() */
> memset(tx_info->rate_driver_data, 0, sizeof(tx_info->rate_driver_data));
> memset(tx_info->pad, 0, sizeof(tx_info->pad));
> diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
[]
> @@ -210,8 +210,8 @@ bool wfx_tx_queues_has_cab(struct wfx_vif *wvif)
> if (wvif->vif->type != NL80211_IFTYPE_AP)
> return false;
> for (i = 0; i < IEEE80211_NUM_ACS; ++i)
> - /* Note: since only AP can have mcast frames in queue and only
> - * one vif can be AP, all queued frames has same interface id
> + /* Note: since only AP can have mcast frames in queue and only one vif can be AP,
> + * all queued frames has same interface id
> */
> if (!skb_queue_empty_lockless(&wvif->tx_queue[i].cab))
> return true;
> @@ -253,9 +253,8 @@ static struct sk_buff *wfx_tx_queues_get_skb(struct wfx_dev *wdev)
> skb = skb_dequeue(&queues[i]->cab);
> if (!skb)
> continue;
> - /* Note: since only AP can have mcast frames in queue
> - * and only one vif can be AP, all queued frames has
> - * same interface id
> + /* Note: since only AP can have mcast frames in queue and only one vif can
> + * be AP, all queued frames has same interface id
> */
> hif = (struct wfx_hif_msg *)skb->data;
> WARN_ON(hif->interface != wvif->id);
next prev parent reply other threads:[~2022-03-01 1:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 11:23 [PATCH 00/10] staging: wfx: usual maintenance Jerome Pouiller
2022-02-25 11:23 ` [PATCH 01/10] staging: wfx: sta.o was linked twice Jerome Pouiller
2022-02-25 11:23 ` [PATCH 02/10] staging: wfx: fix struct alignment Jerome Pouiller
2022-02-25 11:23 ` [PATCH 03/10] staging: wfx: format comments on 100 columns Jerome Pouiller
2022-03-01 1:12 ` Joe Perches [this message]
2022-03-01 17:13 ` Jeff Johnson
2022-02-25 11:23 ` [PATCH 04/10] staging: wfx: format code " Jerome Pouiller
2022-02-25 11:24 ` [PATCH 05/10] staging: wfx: remove useless variable Jerome Pouiller
2022-02-25 11:24 ` [PATCH 06/10] staging: wfx: drop useless include Jerome Pouiller
2022-02-25 11:24 ` [PATCH 07/10] staging: wfx: remove duplicated code in wfx_cmd_send() Jerome Pouiller
2022-02-25 11:24 ` [PATCH 08/10] staging: wfx: prefer to wait for an event instead to sleep Jerome Pouiller
2022-02-25 11:24 ` [PATCH 09/10] staging: wfx: ensure HIF request has been sent before polling Jerome Pouiller
2022-02-25 11:24 ` [PATCH 10/10] staging: wfx: flags for SPI IRQ were ignored Jerome Pouiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe3c21a9c0178a2f0fcea698b8e6405a99747dea.camel@perches.com \
--to=joe@perches.com \
--cc=Jerome.Pouiller@silabs.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®