From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78A7C39DBD6 for ; Sat, 13 Jun 2026 09:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781342553; cv=none; b=g23QqaiTRT81tTYfQH4I+/9Amx15NIcbIjryfEtde0Xo43ahz/ebra2TP3W+kqYDvYJipIuEBZiI3Rg3FoZV9PyLEczqUbkK0eO1B+NFvB4DxswCmbH6/RASH73uYjxSzCpqSNG4pmq0Yj8FDtWmA+Xw64GdnjWB2j+tFivp9yQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781342553; c=relaxed/simple; bh=helDrwuxiWtrf/iPIy4Y9R/hkLMVrwdS0rRl6C7Dn4Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cr79Cj4/YEZ2EUuYO6gAYUi7yFocWWWTxplwCgDp09IZM7eT5feUvp+r3tJj+CzLXNyNc7255XbkxZCYnurIP9ewyoRQycpehxa1/CJZ5GgadqWFkibngWcBmTZgzAmwx9h4P/nrIrUC9Ct/C4L6NBLdMCsww1r1QP66bG8Y1JM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SU2szgcH; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=n7ACzOLv; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SU2szgcH"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="n7ACzOLv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781342551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dkSlrlMGjyQ/p88XPP6jRxfxndrJ9//6XRAvhwfy0VE=; b=SU2szgcHslCPncWD9tsy586twxeQlC764t/fb2mUd2aFwCNL28BcF244eSFlm3fUBX822o dCBRLhNZe0JD6m3TUCQn4/0XjYV+gljQF7GRLDYoivB6OpsnzU+tCUQn0zzlfwujGA1Nq+ FnmY+2jhfA819gefcJR5ydlPhl+ULpA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-IqReYGhjPk6gJCRt19bWZw-1; Sat, 13 Jun 2026 05:22:30 -0400 X-MC-Unique: IqReYGhjPk6gJCRt19bWZw-1 X-Mimecast-MFC-AGG-ID: IqReYGhjPk6gJCRt19bWZw_1781342550 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-91598ab3a1aso203312485a.3 for ; Sat, 13 Jun 2026 02:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781342549; x=1781947349; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dkSlrlMGjyQ/p88XPP6jRxfxndrJ9//6XRAvhwfy0VE=; b=n7ACzOLv+WOrWvtffgBSHFCd1sqwAVcuLe0N4EwnK1hGqBRwEJdin2TthCBO/6a8mw Ht1esjvYudGXsl57gJWIQ8Hee9yAgEPB4Ij3+0wMZSrabFC3cWTlsDbmnlIipEnFXF9G FykR9mRnpzk2VNZf/fpDibTE10PTSfeF4A1DDIfeNJQZWpH5k/6sgq/XgkLVHJNOFOEv 7ZLrzbYESpAmIEa+SkDTnPRpMLa41XZjPOyrpPNYEnO/HLnhNtjF0vzk9qvkUF/NSzZD ozyJz90OYTYAwjbO9dvhDpfJ/cuMy7EEEdTxY/cYMC9y2aOmf+tNYmjr2HI0ys22ctnP 06CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781342549; x=1781947349; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dkSlrlMGjyQ/p88XPP6jRxfxndrJ9//6XRAvhwfy0VE=; b=onMS5rEtph5/sXuQkeVrpgmqJcXpz+LQ3gkobaS26ub+payQmeE0UIneu771FmTseZ QTS0h+a7f3Yf1g3t24+9Lhu8G6MZCLQtjybwbmPmD7RSG/BTWspdXPW/no0+JKF0mCyS ZnlYX40GRolh5CwLXtFBqKOlpmn7V5LGKXLelKusnmdbTQLUIGyF9BplivMHEJci8sKX 1plo3ozh2Em+WNR+r2Sykb6GCWrLC9EcWozgmDAon6XE8VPJjiT24WTuRvqG5NG2nDmY b35JfFYUX3eryBnPvpuAQs+Mn34d3pL566SJDtDZoG9tg8XPKtjL5zdkL5UI/osbl8vF M5gQ== X-Gm-Message-State: AOJu0Yzd0PbtjxAZOc9u34emgmT4eSpX7vJuseBFfkYwQh3g+4/RqtME x+VD7Sq/D5KXVFO1Ee780AM7dulR1hNSEwEa/8IS8Z0nNq09Mx8etUKjV8OxArESxQ65UU/QhGD BHGtFYy/2EckrNNDG+/3vXfZ0eL+uCyswZZRbtCTOJCyJcqflnMKzX5TFMNe+JaYnfg== X-Gm-Gg: Acq92OEGb0Co4Gd2zrySu5k9ZLSWj97U2xV2tAJgnC7PF3QrgKmj26n6eyEc6wGm+Aw zPuxOAV8SOkwUOsBY3WC/OO/1+p2atPYd1ta5AP1kdeEdtxOs3aCZd3AXyEVUel7ZdQgw5AsWa+ ds2JYz69Ctfqnbf3bwJlPwbF9P9WQfwHbPIWvqitH6ZCVtzQopupFo9czAjacAEKtKITJDi3wJw U8FDLRY4GkJJIcOKqHsk5crJgcoNgi1oHP5aEMm9eZcUTTweiokfue4HxQbHt2f+3rEzxS69xDU p+xuan77dw1T2fSgsBBdrus9iNI0pJs8NWSTs6KunCmuDeQxrTu4x7iYmQgGB0Y3QQML/ZzOn10 b7Va9vOQCCl5xFvIyqeK0zkTZi8Pqh55lAyJgQhTBpBVnpWSMUyKBq3k= X-Received: by 2002:a05:620a:4708:b0:915:cf88:1e41 with SMTP id af79cd13be357-9161bf6c4bfmr926952485a.45.1781342549612; Sat, 13 Jun 2026 02:22:29 -0700 (PDT) X-Received: by 2002:a05:620a:4708:b0:915:cf88:1e41 with SMTP id af79cd13be357-9161bf6c4bfmr926950585a.45.1781342549179; Sat, 13 Jun 2026 02:22:29 -0700 (PDT) Received: from [192.168.88.32] ([150.228.25.72]) by smtp.gmail.com with ESMTPSA id af79cd13be357-91619f3c324sm454992285a.21.2026.06.13.02.22.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2026 02:22:28 -0700 (PDT) Message-ID: Date: Sat, 13 Jun 2026 11:22:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 0/4] m68k: coldfire: fix non-standard readX()/writeX() functions To: Greg Ungerer , linux-m68k@lists.linux-m68k.org Cc: linux-kernel@vger.kernel.org, arnd@kernel.org, wei.fang@nxp.com, frank.li@nxp.com, shenwei.wang@nxp.com, imx@lists.linux.dev, netdev@vger.kernel.org, nico@fluxnic.net, adureghello@baylibre.com, ulfh@kernel.org, linux-mmc@vger.kernel.org, linux-can@vger.kernel.org, linux-spi@vger.kernel.org, olteanv@gmail.com References: <20260609142139.1563360-1-gerg@linux-m68k.org> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260609142139.1563360-1-gerg@linux-m68k.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/9/26 4:12 PM, Greg Ungerer wrote: > This odd collection of patches is aimed at fixing the non-standard ColdFire > set of readX()/writeX() IO access functions. Instead switching to using the > asm-generic definitions in include/asm-generic/io.h. The difficulty comes > in trying not to break any drivers with this change. > > The implementation of the readX()/writeX() family of IO access functions > is non-standard on ColdFire platforms. They either return big-endian (that > is native endian) data, or on platforms with PCI bus support check the > supplied address and return either big or little endian data based on that > check. This is non-standard, they are expected to always return > little-endian byte ordered data. Unfortunately this behavior also means > that ioreadX()/iowroteX() and their big-endian counter parts > ioreadXbe()/iowriteXbe() are currently broken because they are implemented > using the readX()/writeX() functions. > > Patches 1, 2 and 3 in this series are specific driver changes that can be > made independently of the final ColdFire readX()/writeX() change. > > Patch 4 is the actual switch to ColdFire building using asm-generic > readX()/writeX(), but also contains three driver fixes that are not easily > handled independently. > > Note that I don't have access to all supported hardware needed to fully > test all these changes. I have tested what I have, a bunch of the standard > Freescale ColdFire eval boards, and inspected generated code for differences. > > Note also that patch 3 relies on changes that are currently only in > linux-next, and are scheduled to hit mainline during the next v7.2 > merge window. Those changes are also available in an immutable git tree > at git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git > cf-internal-io branch. I understand that with this series you are targeting the m68K tree, am I correct? A possibly better option would be, after that the pre-req patches land into Linus's tree, to share an immutable branch for this series, so that both m68k and net-next could pull it. /P