mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: linux-c6x-dev@linux-c6x.org, Mark Salter <msalter@redhat.com>,
	Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
Subject: Re: [PATCH -next] c6x: fix build of signal.c using _TIF_SIGNALs
Date: Sat, 12 Dec 2020 09:17:49 -0700	[thread overview]
Message-ID: <fe4f2b2e-66e6-94f2-d878-08a8e926cd4d@kernel.dk> (raw)
In-Reply-To: <20201210031742.14534-1-rdunlap@infradead.org>

On 12/9/20 8:17 PM, Randy Dunlap wrote:
> kernel/signal.c in arch/c6x/ needs <asm/asm-offsets.h> to build
> since it contains _TIF_SIGNALfoobar #defines, so add it.
> 
> Placates these build errors:
> 
> ../arch/c6x/kernel/signal.c: In function 'do_notify_resume':
> ../arch/c6x/kernel/signal.c:316:27: error: '_TIF_SIGPENDING' undeclared (first use in this function); did you mean 'TIF_SIGPENDING'?
>   316 |  if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
>       |                           ^~~~~~~~~~~~~~~
> ../arch/c6x/kernel/signal.c:316:27: note: each undeclared identifier is reported only once for each function it appears in
> ../arch/c6x/kernel/signal.c:316:45: error: '_TIF_NOTIFY_SIGNAL' undeclared (first use in this function); did you mean 'TIF_NOTIFY_SIGNAL'?
>   316 |  if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
>       |                                             ^~~~~~~~~~~~~~~~~~

Thanks Randy, folded in.

-- 
Jens Axboe


      reply	other threads:[~2020-12-12 16:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  3:17 Randy Dunlap
2020-12-12 16:17 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe4f2b2e-66e6-94f2-d878-08a8e926cd4d@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=jacquiot.aurelien@gmail.com \
    --cc=linux-c6x-dev@linux-c6x.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msalter@redhat.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome